Stored procedure from VBA Excel not running - sql-server

Question

I'm calling from VBA a stored procedure from a PC and it is working okay. In another PC and different user it is not working. A single query though, it is working in both PCs.
I'm calling the stored procedure as follows:
Dim rst As New ADODB.Recordset
Dim ConnectionString As String
Dim StrQuery As String
' Connection string for accessing MS SQL database
ConnectionString = <Connection details>
' Opens connection to the database
cnn.Open ConnectionString
' Timeout error in seconds for executing the entire query; The stored procedure normally runs for around 20 min
cnn.CommandTimeout = 2400
' Process execution
StrQuery = "exec [00_Main] #date = '01/31/2018' "
rst.Open StrQuery, cnn
rst.Close
I'm guessing that I have an error message when executing the stored procedure, but I don't know how to capture it.
I tried the following, but I don't get anything as an output
' Process execution
StrQuery = "exec [00_Main] #date = '01/31/2018' "
rst.Open StrQuery, cnn
Debug.Print rst.Fields.Count
Debug.Print rst.RecordCount
Debug.Print rst
rst.Close
When I run the stored procedure in SQL Management studio I just get output messages as the stored procedure just updates tables. Like:
(29145907 rows affected)
(330527 rows affected)
I tried also adding Error Information following link here, but the process runs without giving me any error. Like:
' Process execution
DateSelection = Sheets("STB Check").Range("F1")
'StrQuery = "exec [00_Main] #date = '" & DateSelection & "' "
StrQuery = "exec [00_Main] #date = '01/31/2018' "
rst.Open StrQuery, cnn
Done:
rst.Close
Exit Sub
AdoError:
Dim errLoop As Error
Dim strError As String
i = 1
' Process
StrTmp = StrTmp & vbCrLf & "VB Error # " & Str(Err.Number)
StrTmp = StrTmp & vbCrLf & " Generated by " & Err.Source
StrTmp = StrTmp & vbCrLf & " Description " & Err.Description
' Enumerate Errors collection and display properties of
' each Error object.
Set Errs1 = cnn.Errors
For Each errLoop In Errs1
With errLoop
StrTmp = StrTmp & vbCrLf & "Error #" & i & ":"
StrTmp = StrTmp & vbCrLf & " ADO Error #" & .Number
StrTmp = StrTmp & vbCrLf & " Description " & .Description
StrTmp = StrTmp & vbCrLf & " Source " & .Source
i = i + 1
End With
Next
MsgBox StrTmp
' Clean up Gracefully
On Error Resume Next
GoTo Done
Any ideas?

Answer 1

Use proper parameterization, and treat dates as Date, not as strings.
Instead of running that straight off ADODB.Recordset, use an ADODB.Command; set the command text to just the name of the stored procedure, and add an ADODB.Parameter to its Parameters collection, providing the cell value (after validating that IsDate returns True for that cell value) - like on learn.microsoft.com:
Dim theDate As Date
theDate = Sheets("STB Check").Range("F1").Value
Dim cmd As ADODB.Command
Set cmd = New ADODB.Command
Set cmd.ActiveConnection = cnn
cmd.CommandType = adCmdStoredProc
cmd.CommandText = "[00_Main]"
Dim dateParam As ADODB.Parameter
Set dateParam = cmd.CreateParameter("date", adDate, adParamInput)
dateParam.Value = theDate
cmd.Parameters.Append dateParam
Dim results As ADODB.Recordset
Set results = cmd.Execute