javafx2 tableview issue : callback and editable combobox in cell - combobox

Question

I have an issue with a tableview and its cells. I want to customize a cell with an editable combobox. Here my code of the combobox :
public class CbbxEditSuppr extends ComboBox<BoxItem> {
private TextField editor = null;
private ObservableList<BoxItem> items = null;
private double prefWidth = 0.0;
/**
* Constructeur.
*
* #param addedItems ObservableList<String>
* #param prefWidth double largeur préférée
*/
public CbbxEditSuppr(ObservableList<String> addedItems, final double prefWidth) {
// initialisation des attributs
editor = this.getEditor();
items = this.getItems();
this.prefWidth = prefWidth;
this.setPrefWidth(prefWidth);
// initialisation du contenu de la cellule
this.setCellFactory(new Callback<ListView<BoxItem>, ListCell<BoxItem>>() {
#Override
public ListCell<BoxItem> call(ListView<BoxItem> p) {
final ListCell<BoxItem> cell = new ListCell<BoxItem>() {
#Override
protected void updateItem(BoxItem t, boolean bln) {
super.updateItem(t, bln);
if (t != null) {
setGraphic(t);
} else {
setGraphic(null);
}
}
};
return cell;
}
});
// déininition du converter
this.setConverter(new StringConverter<BoxItem>() {
#Override
public String toString(BoxItem cbbx) {
if (cbbx == null) {
return null;
} else {
return cbbx.getName();
}
}
#Override
public BoxItem fromString(String id) {
if (id != null) {
final BoxItem box = new BoxItem(id, items, prefWidth);
return box;
} else {
return null;
}
}
});
/* ajout des valeurs a la liste d'items */
if (addedItems != null && addedItems.size() > 0) {
for (String stg : addedItems) {
if (stg != null) {
final BoxItem hbox = new BoxItem(stg, items, this.prefWidth);
items.add(hbox);
}
}
}
// permet de prendre en compte la touche ENTER, et ajouter des valeurs a la liste
this.addEventFilter(KeyEvent.KEY_PRESSED, new EventHandler<KeyEvent>() {
public void handle(final KeyEvent event) {
if (event != null && event.getCode().equals(KeyCode.ENTER)) {
if (editor.getText().trim().length() > 0) {
addItem(editor.getText(), prefWidth);
editor.clear();
}
}
}
});
// propriétés editable et selection du premier element
this.setEditable(true);
this.getSelectionModel().selectFirst();
// ajout de l'affichage du menu popup lors du focus du textfield d'edition de la combobox
editor.focusedProperty().addListener(new ChangeListener<Boolean>() {
#Override
public void changed(ObservableValue<? extends Boolean> arg0, Boolean arg1, Boolean arg2) {
if (arg0 != null && arg2) {
showpopupMenu();
}
}
});
}
/**
* Permet l'affichage du menu popup dans une cellule.
*/
private void showpopupMenu() {
if (!isShowing() && this != null) {
this.show();
}
}
/**
* Ajoute un item à la liste
*
* #param stg String nom de l'item
* #param width double taille préférée
*/
public void addItem(String stg, double width) {
if (stg != null) {
items.add(new BoxItem(stg, items, width));
}
}
/**
* Retourne la description du contenu de la liste
*/
public String toString() {
final StringBuilder stgBuilder = new StringBuilder("[ ");
if (items != null && items.size() > 0) {
final BoxItem lastItem = items.get(items.size() - 1);
for (BoxItem item : items) {
if (item != null) {
stgBuilder.append(item.getName());
if (!item.equals(lastItem)) {
stgBuilder.append(", ");
}
}
}
}
stgBuilder.append(" ]");
return stgBuilder.toString();
}
public class BoxItem extends HBox {
private Label lbl = null;
private Button btn = null;
private ObservableList<BoxItem> listItems;
/**
* Constructeur.
*
* #param stg String nom de la box
* #param items ObservableList<BoxItem> liste d'items de la combobox
* #param prefWidth int largeur de la combobox
*/
public BoxItem(String stg, final ObservableList<BoxItem> items, double prefWidth) {
super();
this.listItems = items;
if (stg != null) {
this.setSpacing(40);
lbl = new Label(stg);
lbl.setPrefWidth(prefWidth);
btn = new Button("x");
this.getChildren().addAll(lbl, btn);
btn.setOnMousePressed(new EventHandler<Event>() {
#Override
public void handle(Event arg0) {
final BoxItem bx = (BoxItem) btn.getParent();
if (bx != null) {
listItems.remove(bx);
}
}
});
}
}
/**
* Retourne le texte inscrit dans le label
*
* #return String
*/
public String getName() {
if (lbl != null) {
return lbl.getText();
}
return null;
}
/**
* retourne le bouton contenu dans une box
*
* #return Button
*/
public Button getBtn() {
return btn;
}
}
}
then I initilise my colum like this with this callbak :
Callback<TableColumn<DonorData, ObservableList<BoxItem>>, TableCell<DonorData, ObservableList<BoxItem>>> cellFactoryEditingCell = new Callback<TableColumn<DonorData, ObservableList<BoxItem>>, TableCell<DonorData, ObservableList<BoxItem>>>() {
public TableCell<DonorData, ObservableList<BoxItem>> call(TableColumn<DonorData, ObservableList<BoxItem>> data) {
return new CbbxEditingCell<DonorData, ObservableList<BoxItem>>();
}
};
colDonorOtherRef.setCellValueFactory(new PropertyValueFactory<DonorData, ObservableList<BoxItem>>("othersRef"));
colDonorOtherRef.setCellFactory(cellFactoryEditingCell);
colDonorOtherRef.setOnEditCommit(new EventHandler<CellEditEvent<DonorData, ObservableList<BoxItem>>>() {
#Override
public void handle(CellEditEvent<DonorData, ObservableList<BoxItem>> event) {
final DonorData rec = event.getTableView().getItems().get(event.getTablePosition().getRow());
//TODO action
}
});
with : CbbxEditingCell.java
public class CbbxEditingCell<S, T> extends TableCell<S, T> {
private CbbxEditSuppr cbbx;
private ObservableList<String> listValues = null;
private boolean isSelectFirst = false;
public CbbxEditingCell() {
listValues = FXCollections.observableArrayList(new ArrayList());
}
#Override
public void startEdit() {
if (!isEmpty()) {
super.startEdit();
createTextField();
setText(null);
setGraphic(cbbx);
}
}
#Override
public void cancelEdit() {
super.cancelEdit();
try {
if (!getItem().toString().equals("null")) {
setText(cbbx.toString());
}
} catch (Exception e) {
}
setGraphic(null);
}
#Override
public void updateItem(T item, boolean empty) {
super.updateItem(item, empty);
if (empty) {
setText(null);
setGraphic(null);
} else {
if (isEditing()) {
setText(null);
setGraphic(cbbx);
} else {
if (getItem() != null && cbbx != null) {
setText(cbbx.toString());
} else {
setText(null);
}
setGraphic(null);
}
}
}
private void createTextField() {
final double width = this.getWidth() - this.getGraphicTextGap() * 2;
cbbx = new CbbxEditSuppr((ObservableList<String>) listValues, width);
if (isSelectFirst) {
cbbx.getSelectionModel().selectFirst();
}
cbbx.setMinWidth(width);
cbbx.setOnKeyReleased(new EventHandler<KeyEvent>() {
#Override
public void handle(KeyEvent t) {
if (t.getCode() == KeyCode.ENTER) {
commitEdit((T) cbbx.getItems());
} else if (t.getCode() == KeyCode.ESCAPE) {
cancelEdit();
}
}
});
cbbx.focusedProperty().addListener(new ChangeListener<Boolean>() {
#Override
public void changed(ObservableValue<? extends Boolean> observable, Boolean oldValue, Boolean newValue) {
if (!newValue) {
commitEdit((T) cbbx.getItems());
}
}
});
}
public void selectFirstItem() {
isSelectFirst = true;
}
}
My problem : when I click on a cell, I have always an empty combobox. I don't know how modify my callback in order to obtain the reference of the line or of the data represented in this cell.
Do you have any ideas ?
Thanks

Answer 1

I think the problem arises because BoxItem is a Node subclass - i.e. you are mixing view types and data types. (You have BoxItem t; and setGraphic(t); in your updateItem() method.) This is especially bad with a ComboBox, because the selected item ends up trying to appear twice in the scene graph (once in the ComboBox's drop down and once in the "button cell" displaying what's selected).
See "A warning about inserting Nodes into the ComboBox items list" in the ComboBox Javadocs.
Instead, use different classes to represent the data you are displaying and the UI controls to display them.