Tic Tac Toe Game In C [closed] - c

Question

Closed. This question needs details or clarity. It is not currently accepting answers.
Want to improve this question? Add details and clarify the problem by editing this post.
Closed 5 days ago.
Improve this question
I'm a rusty c programmer. I created a tictactoe program in python and wanted to do the same in c. Unfortunately, the compiler I installed is running my much older attempt at a tic tac toe game and the online compilers seem to be stuck on the while loops that are involved in decision-making. The while loops are marked out by comments in the code below
#include <stdio.h>
#include <stdlib.h>
#include <stdbool.h>
int main(int argc, char *argv[]) {
int XO, E, turn = 1;
char A[9] = " ";
srand(time(0));
printf(" | | \n | | \n--------------\n | | \n | | \n--------------\n | | \n | | \n");
printf("Enter '1' for x and '-1' for o: ");
scanf("%d", &XO);
while(true)
{
if(turn == -XO)
{
do
{
E = rand() % 9;
}while(A[E] != " "); #Is stuck on this
if(-XO == -1)
{
A[E] = "o";
}
else
{
A[E] = "x";
}
turn *= -1;
}
else if(turn == XO)
{
do
{
printf("Enter the position you want to put yours in. 0 for top left. 1 for top middle. 3 for middle left. 4 for middle middle and so on...\n");
scanf("%d", &E);
}while(A[E] != " "); #Is stuck on this
if(XO == -1)
{
A[E] = "o";
}
else
{
A[E] = "x";
}
turn *= -1;
}
printf(" %c | %c | %c \n | | \n--------------\n %c | %c | %c \n | | \n--------------\n %c | %c | %c \n | | ", A[0], A[1], A[2], A[3], A[4], A[5], A[6], A[7], A[8]);
if (((A[0] == "o" && A[1] == "o" && A[2] == "o") || (A[3] == "o" && A[4] == "o" && A[5] == "o") || (A[6] == "o" && A[7] == "o" && A[8] == "o") || (A[0] == "o" && A[4] == "o" && A[8] == "o") || (A[2] == "o" && A[4] == "o" && A[6] == "o") && XO == 1) || ((A[0] == "x" && A[1] == "x" && A[2] == "x") || (A[3] == "x" && A[4] == "x" && A[5] == "x") || (A[6] == "x" && A[7] == "x" && A[8] == "x") || (A[0] == "x" && A[4] == "x" && A[8] == "x") || (A[2] == "x" && A[4] == "x" && A[6] == "x") && XO == -1))
{
printf("You won!");
break;
}
else if (((A[0] == "o" && A[1] == "o" && A[2] == "o") || (A[3] == "o" && A[4] == "o" && A[5] == "o") || (A[6] == "o" && A[7] == "o" && A[8] == "o") || (A[0] == "o" && A[4] == "o" && A[8] == "o") || (A[2] == "o" && A[4] == "o" && A[6] == "o") && XO == -1) || ((A[0] == "x" && A[1] == "x" && A[2] == "x") || (A[3] == "x" && A[4] == "x" && A[5] == "x") || (A[6] == "x" && A[7] == "x" && A[8] == "x") || (A[0] == "x" && A[4] == "x" && A[8] == "x") || (A[2] == "x" && A[4] == "x" && A[6] == "x") && XO == 1))
{
printf("You lost!");
break;
}
}
return 0;
}
Here's the version that's on the compiler I installed:
#include <stdio.h>
#include <stdlib.h>
int main(int argc, char *argv[]) {
int XO, E, turn = 1;
char A[9] = " ";
srand(time(0));
printf(" | | \n | | \n--------------\n | | \n | | \n--------------\n | | \n | | ");
printf("Enter '1' for x and '-1' for o");
scanf("%d", &XO);
while(1)
{
if(turn == -XO)
{
do
{
E = rand() % 9;
}while(A[E] != " ");
if(-XO == -1)
{
A[E] = "o";
}
else
{
A[E] = "x";
}
turn *= -1;
}
else if(turn == XO)
{
do
{
printf("Enter the position you want to put yours in. 0 for top left. 1 for top middle. 3 for middle left. 4 for middle middle and so on...");
scanf("%d", &E);
}while(A[E] != " ");
if(XO == -1)
{
A[E] = "o";
}
else
{
A[E] = "x";
}
turn *= -1;
}
printf(" %c | %c | %c \n | | \n--------------\n %c | %c | %c \n | | \n--------------\n %c | %c | %c \n | | ", A[0], A[1], A[2], A[3], A[4], A[5], A[6], A[7], A[8]);
if (((A[0] == "o" && A[1] == "o" && A[2] == "o") || (A[3] == "o" && A[4] == "o" && A[5] == "o") || (A[6] == "o" && A[7] == "o" && A[8] == "o") || (A[0] == "o" && A[4] == "o" && A[8] == "o") || (A[2] == "o" && A[4] == "o" && A[6] == "o") && XO == 1) || ((A[0] == "x" && A[1] == "x" && A[2] == "x") || (A[3] == "x" && A[4] == "x" && A[5] == "x") || (A[6] == "x" && A[7] == "x" && A[8] == "x") || (A[0] == "x" && A[4] == "x" && A[8] == "x") || (A[2] == "x" && A[4] == "x" && A[6] == "x") && XO == -1))
{
printf("You won!");
break;
}
else if (((A[0] == "o" && A[1] == "o" && A[2] == "o") || (A[3] == "o" && A[4] == "o" && A[5] == "o") || (A[6] == "o" && A[7] == "o" && A[8] == "o") || (A[0] == "o" && A[4] == "o" && A[8] == "o") || (A[2] == "o" && A[4] == "o" && A[6] == "o") && XO == -1) || ((A[0] == "x" && A[1] == "x" && A[2] == "x") || (A[3] == "x" && A[4] == "x" && A[5] == "x") || (A[6] == "x" && A[7] == "x" && A[8] == "x") || (A[0] == "x" && A[4] == "x" && A[8] == "x") || (A[2] == "x" && A[4] == "x" && A[6] == "x") && XO == 1))
{
printf("You lost!");
break;
}
}
return 0;
}

Answer 1

First of all, there are quite a lot of warnings and logic operations to fix. Some people already provided fixes in comments that you should apply.
Your program does not handle a fully filled array A. If A happens to become full without any win, you end up with infinite loops where you put comments. I think this is the source of the bug.
Also, at the end of your main loop, when you look for any win or defeat, you do not look for any "vertical win" by verifying (A[0] == 'x') && (A[3] == 'x') && (A[6] == 'x') for example.
Finally, adding #include <time.h> will fix the implicit declaration warning.