changed comments in c program and its resulting in segmentatoin fault [closed] - c

Question

Closed. This question is not reproducible or was caused by typos. It is not currently accepting answers.
This question was caused by a typo or a problem that can no longer be reproduced. While similar questions may be on-topic here, this one was resolved in a way less likely to help future readers.
Closed last month.
Improve this question
this the difference between commits, which is just different comments and line spaces, but the old commit runs normally and the new result in a seg fault:
Binary files a/recover/recover and b/recover/recover differ
diff --git a/recover/recover.c b/recover/recover.c
index f0ffdf6..02ab42b 100644
--- a/recover/recover.c
+++ b/recover/recover.c
## -1,34 +1,32 ##
-#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
+#include <stdint.h>
#include <string.h>
typedef enum
{
- false,
- true
-} bool;
+ true,
+ false
-typedef uint8_t BYTE;
+} bool;
typedef char *string;
+typedef uint8_t BYTE;
int BLOCK_SIZE = 512;
int main(int argc, char *argv[])
{
- // Check if a file name was provided as an argument
- if (argc < 2)
+ if (argc != 2)
{
- fprintf(stderr, "Error: No file name provided.\n");
+ fprintf(stderr, "Usage: recover {filename}\n");
return 1;
}
-
- // Open the file for reading
- FILE *raw_file = fopen(argv[1], "r");
+ string fpath = argv[1] == NULL ? "./card.raw" : argv[1];
+ FILE *raw_file = fopen(fpath, "r");
if (raw_file == NULL)
{
- fprintf(stderr, "Error: Could not open file.\n");
+ fprintf(stderr, "Error: filename not valid!\n");
return 2;
}
## -38,33 +36,31 ## int main(int argc, char *argv[])
FILE *img = NULL;
bool opened = false;
- // Read blocks of size BLOCK_SIZE from the file
while (fread(buffer, 1, BLOCK_SIZE, raw_file) == BLOCK_SIZE)
{
- // If start of new JPEG
+ // if start of new jpeg
if (buffer[0] == 0xff && buffer[1] == 0xd8 && buffer[2] == 0xff && (buffer[3] & 0xf0) == 0xe0)
{
- // If a JPEG file is already open, close it and free the filename
+ // if opened
if (opened)
{
free(fname);
fclose(img);
}
- // Allocate memory for the new filename and create a new JPEG file
+ // opened or not
fname = malloc(sizeof(char) * 8);
sprintf(fname, "%03i.jpg", i);
img = fopen(fname, "w");
opened = true;
i++;
}
- // If a JPEG file is open, write the block to it
+ // if opened jpeg start or not
if (opened)
{
fwrite(buffer, 1, BLOCK_SIZE, img);
}
}
-
- // If a JPEG file is open, close it and free the filename
+ // when gone over entire disk image
if (opened)
{
free(fname);
It's basically the same program just different formatting and comments, it doesn't make sense at all.
I don't any difference or error in the code, if you can, please share with us!
expected: running normally
got: segmentation fault (core dumped)

Answer 1

The statement “It's basically the same program just different formatting and comments” is ludicrous. The commit changes:
false,
true
to:
true,
false
with the result that the values for false and true of 0 and 1, respectively, are changed to 1 and 0, respectively.
The code declares opened to be bool and uses it in if (opened). This obviously uses the wrong sense for opened.