Express SQL Server Connection Pools - sql-server

Question

I've got an app that connects to a SQL Server database. It has 3 post API's that are going to get A LOT of traffic. I'm having trouble with connection timeout and want to make sure I have Connection Pooling setup correctly or figure out where I'm going wrong. I have a DBConfig.js file setup as follows
var sql = require('mssql');
let curacaopool = null;
const curacao = () => {
let config;
if (null !== curacaopool) {
return curacaopool;
}
if (process.env.APP_ENV === 'prod') {
config = {
user: 'user',
password: 'password',
server: 'IP Address',
port: 51678,
database: 'Database',
connectionTimeout: 15000,
//requestTimeout: 45000,
pool: {
max: 10,
min: 1,
idleTimeoutMillis: 30000
}
};
}
curacaopool = new sql.ConnectionPool(config).connect();
return curacaopool;
};
module.exports = { curacao };
My API's are setup as follows. I have 3 of them. The first API gets called and returns an ID then the next two API's get called
APIs
var express = require('express');
var router = express.Router();
var sql = require('mssql');
const { curacao } = require('../../../repository/getDbConfig');
router.post('/workstation', async function (req, res, next) {
curacao()
.then((pool) => pool.request())
.then((request) => {
for (const [key, value] of Object.entries(dbColumns)) {
if (typeof value !== 'undefined' && value !== '') {
request.input(key, dbTypes[key], value);
}
}
request.input('ip_address', sql.VarChar, ip_address);
request.output('workstationId', sql.Int);
request.execute('Gumshoe.dbo.InsertWorkstations', (err, result) => {
if (err) {
res.status(500).json({ 'Workstation Error': err });
}
res.status(200).json({
status: 200,
message: 'Data Saved',
workstationId: result.output.workstationId
});
});
})
.catch((err) => {
console.log('Workstations Error', err);
res.status(500).json({ 'Workstations Error': err });
});
});
router.post('/packages', async function (req, res, next) {
const sentdata = req.body;
var table = new sql.Table('Database.dbo.Packages');
table.create = false;
table.columns.add('workstation_id', sql.Int, { nullable: true });
table.columns.add('pkg_name', sql.VarChar, { nullable: true });
table.columns.add('pkg_ver', sql.VarChar, { nullable: true });
table.columns.add('appWizName', sql.VarChar, { nullable: true });
table.columns.add('appWizPublisher', sql.VarChar, { nullable: true });
table.columns.add('appWizInstalledOn', sql.Date, { nullable: true });
table.columns.add('appWizVersion', sql.VarChar, { nullable: true });
table.columns.add('appWizSize', sql.VarChar, { nullable: true });
table.columns.add('customTrack1', sql.VarChar, { nullable: true });
table.columns.add('customTrack2', sql.VarChar, { nullable: true });
table.columns.add('customTrack3', sql.VarChar, { nullable: true });
if (sentdata.length > 0) {
sentdata.forEach((item) => {
if (parseInt(item.workstation_id) > 0 && item.pkg_name.length > 1) {
return table.rows.add(
item.workstation_id,
item.pkg_name,
item?.pkg_ver || null,
item?.appWizName || null,
item?.appWizPublisher || null,
item?.appWizInstalledOn ? (dateCheck(item.appWizInstalledOn) === true ? item.appWizInstalledOn : null) : null,
item?.appWizVersion || null,
item?.appWizSize || null,
item?.customTrack1 || null,
item?.customTrack2 || null,
item?.customTrack3 || null
);
}
});
curacao()
.then((pool) => pool.request())
.then((request) =>
request
.bulk(table, (err, result) => {
if (err) {
console.log('Package Bulk Error:', err);
res.status(500).json({ 'Bulk Packages': err });
}
res.status(200).json(result);
})
.catch((err) => {
console.log('Packages Error', err);
res.status(500).json({ 'Packages Error': err });
})
);
} else {
console.log('Package sent data was empty Array', sentdata);
res.status(500).send('Package empty Array');
}
});
The first API calls a stored proc, this stored proc deletes data from the tables for the next two APIs. The next two (both setup the same) do Bulk Inserts to two other tables
I'm having a lot of trouble with Timeout Errors
Webserver
returned:{"status":500,"pool_error":{"code":"ETIMEOUT","originalError":{"message":"Timeout:
Request failed to complete in 15000ms
I've tried increasing the pool Max to 25. I've tried increased the requestTimeout value. Both of those haven't worked or helped. These work in test when not under heavy load so wondering what I look to next to get this resolved.
Thanks for any assistance