I have a userContext like this :
import React, { useContext, useEffect, useState } from "react";
import * as userService from "./services/appService";
const UserContext = React.createContext();
export function useUserContext() {
return useContext(UserContext);
}
export function UserProvider({ children }) {
const [user, setUser] = useState();
useEffect(() => {
const fetchData = async () => {
const { data } = await userService.allDetails();
setUser(data);
};
fetchData();
}, []);
return <UserContext.Provider value={user}>{children}</UserContext.Provider>;
}
I'm wrapping routes with User Provider like this
<UserProvider>
<Route path="/signup" component={Signup} />\
<Route path="/login" component={Login} />\
<ProtectedRoute path="/resetpassword" component={Reset} />
<ProtectedRoute path="/settings" component={Settings} />
<UserProvider>
I'm trying to access it inside a functional component like this:
function Settings(){
const user = useUserContext();
const id = user.id
useEffect(() => {
console.log(id)
},[])
return (
.......
)
}
I'm getting user as undefined in Settings component.
In the UserProvider component, you defined a state user with initial value of undefined, because you did not pass any value to useState. Even though you are making an API call to update the state of user state, but keep in mind that fetching is an asynchronous operation and may take time to finish, which is why when you try to access user context in Settings component, the value is still undefined. You could add an if statement check here to see if user context is truthy or not and use it if it's truthy only, which means that the fetch finished and user state has been updated
Since the user is only loaded as an Effect after the first render of UserProvider, it is still undefined during the first render.
I suggest you suspend rendering the UserProvider and its contents until the fetch completed:
export function UserProvider({ children }) {
const [user, setUser] = useState();
useEffect(() => {
userService.allDetails()
.then(({ data }) => setUser(data));
}, []);
return !user ? null : (
<UserContext.Provider value={user}>
{children}
</UserContext.Provider>
);
}
Related
I'm trying to get some auth experience and I've got React with React Router, I found a custom auth check for routes that I thought looked good, and tried to implement. Basically it would sign the user in, change the auth value to true and be able to call on that auth value from the hook to check.
Here's my codesandbox, my problem is I have to use AWS Cognito for this project so the sign in call has to be from an async function and not through a promise...
Clicking 'sign in check' calls handleLogin and starts the async function in the useAuthHook with signIn, which sets authed to true via an effect hook. That change is reflected by using the 'auth check' button, but when trying to navigate to a protected route the console logs the default values.
Here's the steps;
...
<Button variant="primary" onClick={handleLogin} type="button">
sign in check
</Button>
...
const handleLogin = () => {
signIn();
};
Now the signIn hook from useAuthHook;
async signIn() {
const user = "totally real"; //AWS await request
testValue = "a diff string";
if (user) {
setUser(user);
console.log(authed, user);
return "/storageSolution";
}
}
the effect hook that updates a ref hook and a useState hook(testing both cases);
React.useEffect(() => {
if (user) {
authed.current = true;
setStateAuth(true);
}
}, [user]);
both stateAuth and the authed ref are returned along with the earlier signIn, and used in RequireAuth before my routes;
export function RequireAuth({ children }) {
const location = useLocation();
const { authed, user, stateAuth } = useAuth();
console.log(authed, user, stateAuth);
return authed === true ? (
children
) : (
<Navigate to="/" replace state={{ path: location.pathname }} />
);
}
but clicking protected route check after signing in shows default values in the console, whereas clicking auth check shows the updates values.
I found https://reactjs.org/docs/hooks-faq.html#why-am-i-seeing-stale-props-or-state-inside-my-function this on stale state, but neither of the reasons it gives seem to be the problem. I've got several different ways of updating and reading that value, but none work. What am I missing?
React hooks don't share state. Move all the state and logic from the useAuth hook into the AuthProvider component. After this is done the useAuth hook simply returns the current authContext value.
Example:
const authContext = React.createContext();
export function useAuth() {
return React.useContext(authContext);
}
export function AuthProvider({ children }) {
const authed = React.useRef(false);
const [user, setUser] = React.useState();
const [stateAuth, setStateAuth] = React.useState(false);
let testValue = "some string";
React.useEffect(() => {
if (user) {
authed.current = true;
setStateAuth(true);
}
}, [user]);
return (
<authContext.Provider
value={{
authed,
user,
testValue,
stateAuth,
async signIn() {
const user = "totally real"; // where the await auth req would be
testValue = "a diff string";
if (user) {
setUser(user);
console.log(authed, user);
return "/storageSolution";
}
}
}}
>
{children}
</authContext.Provider>
);
}
index.js
Import and wrap the app with the AuthProvider component.
...
import { RequireAuth, AuthProvider } from "./useAuthHook";
...
const rootElement = document.getElementById("root");
ReactDOM.render(
<React.StrictMode>
<AuthProvider>
<BrowserRouter>
<Routes>
<Route path="/" element={<LoginSignup />} />
<Route
path="/storageSolution"
element={
<RequireAuth>
<StorageSolution />
</RequireAuth>
}
/>
<Route path="/secret" element={<SecretRoute />} />
</Routes>
</BrowserRouter>
</AuthProvider>
</React.StrictMode>,
rootElement
);
I am trying to implement private routing to my react web application. I have a login, a sign app and a home page, and i want the user to access the homepage only if he is logged in or signed in. I am using Firebase authentication.
I know that my private route component is wrong but because i am new i don't know how to fix it.
I get the error that currentuser is undefined.
Thank you!
PrivateRoute.js
export default function PrivateRoute({ children }) {
const currentUser = useAuth()
console.log(currentUser.email)
return currentUser ?(
<Navigate to="/home" />
) : (
<Navigate to="/signin" />
);
App.js
function App() {
return (
<Routes>
<Route restricted={true} path='/signin' element={<SignInSide/>}/>
<Route
path="/home"
element={
<PrivateRoute>
<Home/>
</PrivateRoute>
}
/>
<Route path='/signup' element={<SignUpside/>}/>
</Routes>
useAuth function in firebase.js
// Initialize Firebase
export const app = initializeApp(firebaseConfig);
export const auth = getAuth(app);
export function useAuth() {
const [ currentUser, setCurrentUser ] = useState();
useEffect(() => {
const unsub = onAuthStateChanged(auth, user => setCurrentUser(user));
return unsub;
}, [])
return currentUser;
}
Your PrivateRoute component does not make sense, since it is not using the children prop. You should either redirect to the signin page when you don't have a user, or display the children, when you have a user, isn't it ?
It could look like this :
export const PrivateRoute = ({ children }) => {
const currentUser = useAuth()
return currentUser ? children : <Navigate to="/signin" />;
};
However, your error doesn't come from the router, but rather from your useAuth hook it seems. Initially, your user is undefined, so it is normal that you get an error saying this.
If you want to logout the email of the user, try to do the following instead:
if(currentUser)
console.log(currentUser.email)
This way, it will not be undefined.
Furthermore, there is no restricted prop in the Route component of react-router, in the v6.
I hope it solves your issue, otherwise please provide a reproducible example, so it is easier to locate the issue you are facing.
I actually found the problem.
i needed to use context provider and then wrap the app with it
export const AuthContext = createContext();
export const AuthProvider = ({ children }) => {
const [currentUser, setCurrentUser] = useState(null);
const [pending, setPending] = useState(true);
useEffect(() => {
auth.onAuthStateChanged((user) => {
setCurrentUser(user)
setPending(false)
});
}, []);
if(pending){
return <>Loading...</>
}
return (
<AuthContext.Provider
value={{
currentUser
}}
>
{children}
</AuthContext.Provider>
);
};
i seem to be getting the following error when using useEffect hook.
Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
I believe it has something to do with the async function i am calling to set if the user is authenticated or not.
ProtectedRoute.tsx
export function ProtectedRoute({ ...routeProps }: ProtectedRouteProps): ReactElement | null {
const context = useContext(AppContext);
const [isAuthenticated, setIsAuthenticated] = useState(false);
useEffect(() => {
isUserAuthenticated(context.token).then(setIsAuthenticated).catch(setIsAuthenticated);
});
if (isAuthenticated) {
return <Route {...routeProps} />;
} else {
return <Redirect to={{ pathname: "login" }} />;
}
}
const isUserAuthenticated = async (token: any): Promise<boolean> => {
try {
const response = await VerifyAuthentication(token);
console.log("VerifyAuthentication", response);
if (response.status !== 200) {
return false;
}
return true;
} catch (err) {
return false;
}
};
App.tsx
class App extends Component<Props, State> {
renderRouter = () => {
return (
<Router>
<Switch>
<ProtectedRoute exact path="/" component={Dashboard} />
<Route exact path="/login" component={Login} />
</Switch>
</Router>
);
};
render(): ReactElement {
return (
<div className="App">
<AppProvider>
<Theme>
<Sidebar>{this.renderRouter()}</Sidebar>
</Theme>
</AppProvider>
</div>
);
}
}
Presumably this redirects the user to a route which doesn't have this component:
return <Redirect to={{ pathname: "login" }} />;
Which means the component is unmounted, or generally unloaded from active use/memory. And this always happens, because this condition will never be true:
if (isAuthenticated) {
Because when the component first renders that value is explicitly set to false:
const [isAuthenticated, setIsAuthenticated] = useState(false);
So basically what's happening is:
You fire off an asynchronous operation to check if the user is authenticated.
Before waiting for the response, you decide that the user is not authenticated and redirect them.
The component is unloaded because the user has left this page.
The asynchronous response is received and tries to update state for a component that is no longer loaded/mounted.
It's not entirely clear how this component is intended to fit into your overall structure, but you're going to need to change that structure. Either checking for authentication would need to be synchronous or you'd need to wait for the asynchronous operation to complete before redirecting. An example of the latter could be as simple as:
export function ProtectedRoute({ ...routeProps }: ProtectedRouteProps): ReactElement | null {
const context = useContext(AppContext);
const [isAuthenticated, setIsAuthenticated] = useState(false);
const [isLoading, setIsLoading] = useState(true);
useEffect(() => {
isUserAuthenticated(context.token)
.then(x => {
setIsAuthenticated(x);
setIsLoading(false);
})
.catch(e => {
setIsAuthenticated(false);
setIsLoading(false);
console.log(e);
});
});
if (isLoading) {
return <div>Loading...</div>;
} else if (isAuthenticated) {
return <Route {...routeProps} />;
} else {
return <Redirect to={{ pathname: "login" }} />;
}
}
In that scenario a separate state value of isLoading is used to track whether the asynchronous operation is still taking place, so the component "waits" until the data is loaded before deciding to redirect the user or not.
But overall I don't see why the authentication check can't be synchronous. Something higher-level, such as a provider component that wraps the entire application structure within <App/>, can have this same logic above, essentially performing the async operation and keeping the result in state. Then that state can be provided via useContext or Redux or even just passing as props to all child components.
You shouldn't need to re-check for authentication over and over in child components. That's an application-level concern.
You can use a variable to check component is mount or unmount when call setIsAuthenticated
useEffect(() => {
let isMouted = true;
isUserAuthenticated(context.token)
.then((val) => isMouted && setIsAuthenticated(val))
.catch(setIsAuthenticated);
return () => {
isMouted = false;
};
});
I'm using code from a tutorial, which uses createContext and I'm kind of confused on what exactly it's doing, and I believe that it's causing errors where I wouldn't necessarily expect. I have two components, Dashboard and Login which are different pages of my web app. It generates the error: Unhandled Rejection (TypeError): Cannot read property 'data' of undefined For some reason, the following line in Dashboard.js:
function Dashboard() {
const [favPokemons, setFavPokemons] = useState([]);
const { userData, setUserData } = useContext(UserContext);
setFavPokemons(userData.user.favPokemon); // This line is the problematic line
}
causes an error in Login.js in its try catch clause:
import UserContext from "../../context/userContext";
import ErrorNotice from "../misc/ErrorNotice";
function Login () {
const [email, setEmail] = useState();
const [password, setPassword] = useState();
const [error, setError] = useState();
const { setUserData } = useContext(UserContext);
const history = useHistory();
const submit = async (e) => {
e.preventDefault();
try{
const loginUser = {email, password};
const loginResponse = await axios.post("https://minipokedexbackend.herokuapp.com/users/login", loginUser);
console.log(userData); // line Login.js:21 is in image below line 22
console.log(loginResponse) // line Login.js:22, log is in image below
setUserData({
token: loginResponse.data.token,
user: loginResponse.data.user
});
localStorage.setItem("auth-token", loginResponse.data.token);
history.push("/dashboard");
} catch(err) {
err.response.data.msg && setError(err.response.data.msg)
}
};
Could someone explain what createContext and why it would be causing an error in two seemingly unrelated components? I have a feeling that it has to do with userData not quite being generated when Dashboard is rendered?
EDIT:
Sorry for the lack of information, data referenced in the Login.js file is data from my server accessing mongoDB. Its response contains token and user info, which includes their id, displayname and an array of favpokemon
Here's userContext.js:
import { createContext } from 'react';
export default createContext(null);
Here's App.js:
function App() {
const [ userData, setUserData] = useState({
token: undefined,
user: undefined
});
return (
<BrowserRouter>
<UserContext.Provider value={{ userData, setUserData }}>
<Header />
<Switch>
<Route exact path="/" component={Home} />
<Route path="/register" component={Register} />
<Route path="/login" component={Login} />
<Route path='/dashboard' component={Dashboard}/>
</Switch>
</UserContext.Provider>
</BrowserRouter>
);
}
App.js also contains some functions to check if the user is logged in.
With the info you provided in the question, I managed to create a structure of your code. There might be logic or syntax errors because of the lack of information, but I want you to have a general idea how to use Context Hook during login.
UserContext.tsx
import React, { createContext, useState } from "react";
//create the context
export const UserContext = createContext<any>(undefined);
//create the context provider, we are using useState to ensure that we get reactive values from the context
export const UserProvider: React.FC = ({ children }) => {
//the reactive values
const [email, setEmail] = useState<string>("");
const [password, setPassword] = useState<string>("");
const [userData, setUserData] =setUserData({
token: '',
user: ''
});
//the store object
let state = {
email,
setEmail,
password,
setPassword,
userData.
setUserData
};
//wrap the application in the provider with the initialized context
return <UserContext.Provider value={state}>{children}</UserContext.Provider>;
};
export default UserContext;
Login.tsx
import UserContext from "../../context/userContext";
import ErrorNotice from "../misc/ErrorNotice";
function Login () {
const [error, setError] = useState();
const { email, setEmail, password, setPassword, userData, setUserData } = useContext(UserContext);
const history = useHistory();
const submit = async (e) => {
e.preventDefault();
try{
const loginUser = {email, password};
const loginResponse = await axios.post("https://minipokedexbackend.herokuapp.com/users/login", loginUser);
console.log(userData); // line Login.js:21 is in image below line 22
console.log(loginResponse) // line Login.js:22, log is in image below
setUserData({
token: loginResponse.data.token,
user: loginResponse.data.user
});
localStorage.setItem("auth-token", loginResponse.data.token);
history.push("/dashboard");
} catch(err) {
err.response.data.msg && setError(err.response.data.msg)
}
};
export default Login;
Dashboard.tsx
import UserContext from "../../context/userContext";
import ErrorNotice from "../misc/ErrorNotice";
import React, { useState, useEffect } from "react";
const Dashboard: React.FC = () => {
const [favPokemons, setFavPokemons] = useState([]);
const { userData, setUserData } = useContext(UserContext);
useEffect(() => {
setFavPokemons(userData?.user?.favPokemon);
}, []);
}
}
export default Dashboard;
App.tsx
Here I'm using a ternary expression. If (userData.token), got to dashboard otherwise go to Login Page.
function App() {
const { userData} = useContext(UserContext);
return (
<UserProvider>
<BrowserRouter>
<Header />
<Switch>
{!userData?.token ? (
<>
<Route path="/register" component={Register} />
<Route path="/login" component={Login} />
<Redirect exact from="/" to="/login" />
</>
) : (
<>
<Route exact path="/" component={Home} />
<Route path='/dashboard' component={Dashboard}/>
<Redirect exact from="/" to="/dashboard" />
</>
)
</Switch>
</BrowserRouter>
</UserProvider>
);
}
Try to make a habit of using null checks when you’re accessing nested values of a response.
setFavPokemons(userData.user.favPokemon);
Here, modify this line to:
setFavPokemons(userData?.user?.favPokemon);
Also, do you mind doing a console log on userData object or share the corresponding reducer to check whether the shape of the data is same or not?
The server is returning user data. In particular, I am interested in his rights. With these rights, I will render the components. I am thinking of passing this data to components and doing some checks. All routes are in the index.js
import {Notfound404} from './components/404/404NotFound'
import {UserContext} from './UserContext'
const Router = () => {
const [user, setUser] = useState(null)
return (
<React.StrictMode>
<UserContext.Provider value={{user, setUser}}>
<CookiesProvider>
<BrowserRouter>
<Switch>
<Route exact path={'/'} component={Auth}/>
<Route exact path={'/settings'} component={Settings}/>
<Route exact path={'/event-logs'} component={EventLog}/>
<Route component={Notfound404} status={404}/>
</Switch>
</BrowserRouter>
</CookiesProvider>
</UserContext.Provider>
</React.StrictMode>
)
}
setting user data in Auth.js
import {UserContext} from '../../UserContext'
export const Auth = () => {
const {user, setUser} = useContext(UserContext)
const [username, setUsername] = useState('')
const [password, setPassword] = useState('')
const [token, setToken] = useCookies(['qr-token'])
useEffect(() => {
if (token['qr-token']) window.location.href = '/settings'
}, [token])
const credentials = {
username: username,
password: password
}
const sendCredentials = () => {
axios.post(`http://127.0.0.1:8000/api/v1/auth/`, credentials, {
headers: {
'Content-type': 'application/json',
}
})
.then(resp => {
setToken('qr-token', resp.data.token);
setUser(resp.data)
})
.catch(error => console.log(error.response))
}
return !token['qr-token'] &&
<div className={styles.authContainer}>
<label htmlFor={'username'}>Username</label>
<input id={'username'} type={'text'} placeholder={'username'}
onChange={evt => setUsername(evt.target.value)}
/>
<label htmlFor={'password'}>Password</label>
<input id={'password'} type={'password'} onChange={evt =>
setPassword(evt.target.value)}/>
<button onClick={sendCredentials}>Sign In</button>
</div>
)
}
In the index.js I am getting user data after authorization. But in settings.js use data is null
export const Settings = () => {
const {user, setUser} = useContext(UserContext)
console.log(user) # null
....
}
Probably I am doing something wrong and I am asking for your help. Thanks.
As Saba indicated, the issue is about refreshing the page which clears the context. This is done by these lines:
useEffect(() => {
if (token['qr-token']) window.location.href = '/settings'
}, [token])
Don't use the usual redirect methods in Single Page Applications. Instead, use
const history = useHistory();
useEffect(() => {
if (token['qr-token'])
history.push('/settings');
}, [token])
This won't cause a reload of the page and therefore keeps your context alive.
I think a refresh is happening while redirecting to the setting page. That reload cause the context value to get cleared (simply, because the value of the context is coming from a state and that state gets lost as a result of refresh). To fix this, you can store the auth data data in localStorage and assign the context value to it whenever it gets null.
useContext() provides a dispatch function that has been passed down
from the Store component. The dispatch function accepts two arguments,
a type of action, and a payload for updating the global state. The
useContext() function will then return an updated global state.
const { state, dispatch } = useContext(MyContext);
In your code setUser must be triggered with the parameter contains action type and payload.
For example.
setUser({
type: "SET_USER",
payload: resp.data
})