Activate a relay on Schedule - c

Question

I have a problem to well understand what'is happening here.
I'm tring to activate a relay base on time with the user selected schedule.
The problem is when the stop time is after midnight and the start if before.
My function to check if it is the moment to toggle is:
bool lightsOn = false;
void checkOnOff() {
//Check time for ON/OFF the ligth
struct tm *curTime = getTime();
unsigned int now = curTime->tm_hour * 100 + curTime->tm_min;
unsigned int start = config.ligths_on_time.tm_hour * 100 + config.ligths_on_time.tm_min;
unsigned int stop = config.ligths_off_time.tm_hour * 100 + config.ligths_off_time.tm_min;
if ( (now >= start || now < stop) && (now <= stop) ) { //<-- this line is hard to have it in mind
if(!lightsOn) enableLights();
} else {
if(lightsOn) disableLights();
}
}
void enableLights() { //the same for disableLights() but with false, reverse HIGH/LOW and 0
lightsOn = true;
digitalWrite(EXTRA_LED_PIN, HIGH);
digitalWrite(ON_OFF_RELAY_PIN, HIGH);
sendLightsOnOffToServer(1);
Serial.println(F("Lights enabled."));
}
struct tm *getTime() {
//if (NTP_TIME_SETTED) {
time_t now = time(nullptr);
//gmtime_r(&now, &timeinfo); //utc
return localtime(&now);
//}
}
Is someone can explain to me how to do that ?

Answer 1

Adjust the stop time by 24 hours if it is smaller than start
Adjust the now time by 24 hours if the stop time is tomorrow, and the ON_OFF state is ON, and now < start.
Re-order your logic to use the ON_OFF state to determine whether to check for start or stop
#define HOUR 100
#define DAY (HOUR * 24)
#define ON true
#define OFF false
unsigned int now = curTime->tm_hour * HOUR +
curTime->tm_min ;
unsigned int start = config.ligths_on_time.tm_hour * HOUR +
config.ligths_on_time.tm_min;
unsigned int stop = config.ligths_off_time.tm_hour * HOUR +
config.ligths_off_time.tm_min;
// Fix-up stop and now time to account for stop in next day
if( stop < start)
{
stop += DAY ;
if( ON_OFF == ON && now < start )
{
now += DAY ;
}
}
// If OFF, check for start condition
if( ON_OFF == OFF && now >= start )
{
enableLight() ;
}
// ... otherwise if ON, check for stop condition
else if( ON_OFF == ON && now >= stop )
{
disableLight() ;
}