** I think I just struggle with this long enough to ask here...so what is the difference between onChange and value here in the input element? To me it seems that both are setting the term to the input text**
class SubmitForm extends React.Component {
state = { term: '' };
render() {
return(
<form>
<input
type='text'
className='input'
placeholder='Enter Item'
value={this.state.term}
onChange={(e) => this.setState({term: e.target.value})}
/>
<button className='button'>Submit</button>
</form>
);
}
}
value is the value of the input text box to the letter. when you are trying to update the input text box, onChange event will be emitted and here, you should update the variable that indicates value.
If you don't specify onChange event, input textbox is not updated even though you press any key because input box value is always indicated with the same value - this.state.term.
This is not specific to reactJS, the value attribute on an html input is what the current value of the input is, the onChange attribute does something (in your case updating the state thus updating the value) whenever the a change happens to the input.
Related
import React, { useState } from "react";
import "../styles.css";
const FormBox = () => {
const [value, setValue] = useState({
fName: "",
lName: "",
});
const [textArea, setTextArea] = useState("");
const handleSumbit = (e) => {
e.preventDefault();
console.log(value);
console.log(textArea);
};
return (
<div className="center">
<form onSubmit={handleSumbit}>
<div>
{/*This is how to set a control form box */}
<input
placeholder="First Name"
type="text"
value={value.fName}
onChange={(e) => setValue(e.target.value)}
/>
</div>
<div>
{/*This is how to set a control form box */}
<input
placeholder="Last Name"
type="text"
value={value.lName}
onChange={(e) => setValue(e.target.value)}
/>
</div>
<div>
<textarea
value={textArea}
onChange={(e) => setTextArea(e.target.value)}
></textarea>
<div>
<input type="submit" />
</div>
</div>
</form>
</div>
);
};
export default FormBox;
I'm working on a basic React project and I'm currently getting the message "Warning: A component is changing a controlled input to be uncontrolled. This is likely caused by the value changing from a defined to undefined, which should not happen. Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://reactjs.org/link/controlled-components
input"
Another problem is that I'm not getting any info when typing in first name field box. I do get back last name and textarea.
Thank you so much and happy holiday
You are having two issues:
Not getting info from the first name field
The uncontrolled vs controlled warning
Issue 1.
This actually happens because on both the first name and last name inputs you are doing setValue(e.target.value). setValue() sets the object that is originally initialized as { fName: '', lName: '' }. This means that even though the value is an object at first, when writing on any of the fields, it will become a simple string, either the first or last name.
This problem does not happen with the text area, since you keep track of its value on a separate state, textArea. That's one way to fix your issue, hold both fName and lName on separate useState calls. Another way is to replace the old value object with a new one that works as expected, for example:
<input
placeholder="First Name"
type="text"
value={value.fName}
onChange={(e) => setValue({ ...value, fName: e.target.value })}
/>
I would also suggest avoiding abbreviations whenever possible. You could've used firstName and lastName instead as variable names. It really goes a long way improving readability.
Issue 2.
This warning is a side effect of the first issue. It appears because you are using controlled inputs but when writing on one of them the object is turned into a string and both value.fName and value.lName are undefined. Controlled inputs are not supposed to have undefined as a value, since that's usually an indicator that you want to use uncontrolled inputs. The empty value should be an empty string, which was intended and will be fixed if you fix the first issue.
There's another stack overflow sharing the differences between controlled and uncontrolled components: What are React controlled components and uncontrolled components?
A Controlled Component is one that takes its current value through props and notifies changes through callbacks like onChange. A parent component "controls" it by handling the callback and managing its own state and passing the new values as props to the controlled component. You could also call this a "dumb component".
A Uncontrolled Component is one that stores its own state internally, and you query the DOM using a ref to find its current value when you need it. This is a bit more like traditional HTML.
The important bit to note here is that an uncontrolled component doesn't receive a value prop and hence its value is undefined.
I was just playing a bit with a more generic way of dealing with form data, and figured that setting a single onChange listener on the wrapping form tag should work for all changes to input fields.
And indeed, it does - no surprise there. Events get called, I know what changed by inspecting event.target.name and can update state accordingly. Fully as expected.
However, React doesn't seem to like it and spams the well known "You provided a value prop to a form field without an onChange handler" console warning.
Would there be any other reason for not doing this, apart from the console warning? It seems to eliminate a lot of duplication React otherwise gets criticised about.
class App extends Component {
state = {
name: 'Default Name',
number: 12,
}
handleChange = (event) => {
this.setState({
[event.target.name]: event.target.value,
})
}
render() {
const { crashLogo } = this.props;
return (
<div className="App">
<form onChange={this.handleChange}>
<input type="text" name="name" value={this.state.name} />
<input type="number" name="number" value={this.state.number} />
</form>
</div>
);
}
}
Just for clarity: I'm not asking for alternative solutions, I know I can set the same change listener directly on every input, use redux-form, own wrapper components with context magic and so on...
Im sending props value to the input field.When im trying to edit the
field it is not editing..How to write onchange handle function.Can anyone
explain briefly about controlled and uncontrolled inputs
handleUserInput = (e) => {
//what to do here in order to edit the input field
}
render() {
return(
<div>
<div className="info">
<label className="label">Store Name</label>
<input type="text"
ref="storename"
className="form-control"
value={this.props.storeName}
placeholder="Store Name"
onChange={this.handleUserInput}
disabled={this.state.disabled}
/>
</div>
</div>
);
}
Change this:
value={this.props.storeName}
to this (otherwise the value for input is always the same - the value received in props):
value={this.state.storeName}
and copy the props to the state in constructor(you should do that in constructor only if you are using props as an initial value):
constructor(props){
super(props)
this.state = {
storeName: props.storeName
}
}
and
handleUserInput=(e)=>{
this.setState({storeName: e.target.value});
}
Now we have made the input box a controlled element (with an initial value taking from the props though). If you are interested in controlled components more you can look in the docs, it isn't hard concept to grasp.
You can see below sample code, it's a typical controlled field.
export default class NameForm extends Component {
constructor(props) {
super(props);
this.state = {value: ''};
this.handleChange = this.handleChange.bind(this);
}
handleChange(event) {
this.setState({value: event.target.value});
}
render() {
return (
<form>
<label>
Name:
<input type="text" value={this.state.value} onChange={this.handleChange} />
</label>
<input type="submit" value="Submit" />
</form>
);
}
}
I can understand that if I type any text in the field, the value will be reflected into the text field due to the setState function and the value props of the input.
But if I changed the input to below. I removed the value props.
<input type="text" onChange={this.handleChange} />
Currently, If I typed any value in the field, the value will be still there, but as per my knowledge of React, the input will be rendered after the setState, but the props value is not set, the input will be cleared in my opinion, Could you please explain it in detail for me?
I think you miss the important point here. After setState is called the component render will be called - but this will not recreate the input component from scratch. Internally react will check and apply only changes that has happened to the actual DOM.
In your case no differences to the input were made - therefore it will stay as it is.
This process is called reconciliation and you can read more about it here.
Setting value on an input element makes it a controlled input. Controlled inputs always show the value provided in their prop. For example if you have this input:
<input value='constant' onChange={({target: {value}}) => this.setState({value})}/>
User can't change its value. but if you don't provide value prop for your input it's not a controlled value and it shows the value user enters in. This same thing is true for checkboxes, radio buttons, etc.
So in your case it updates based on user input because it's not a controlled component (because you didn't provide value for it.)
If you want to set initial value for a component but keep it uncontrolled (user can change the value of component) you can set the initial value with defaultValue prop.
You can read more here:
https://facebook.github.io/react/docs/forms.html
You shouldn't be setting the value, just the defaultValue, like this
<input type="text" defaultValue={this.state.value}
The handleChange will then make sure the state is updated
In React, when I have a input and user types something, I will call setState to save it. We know that when state is changed, the component would be re-rendered.
My question is in this case, why re-render would not reset the input? In my understanding, if we want to keep the input, we should use
<input type="text" value={ this.state.input } onChange={(e) => this.handle(e) }
I've created a jsfiddle
Created another jsfiddle. Now when user input anything, the className would be changed, so definitely dom tree is changed. but still the input is not reset after each re-rendering
What you are seeing is the difference between a controlled and an uncontrolled input. The input HTML element is inherently stateful, with or without React i.e. it will maintain the value of whatever is typed into it. This is why if we render:
<input type='text' />
Then whatever is typed will be seen in the input, with no help from React. This is an uncontrolled component, meaning that the value of the input is not controlled by React.
If we set a value prop on the input:
<input type='text' value='' />
Then the inherent state of the input is overridden by the value prop. In the above example it is an unchanging empty string, so no entered characters will ever appear in the input.
So if we take the code from your first fiddle:
<input type="text" onChange={ (e) => this.handle(e) } />
There is no value prop set, so the value shown within the input comes from the HTML elements inherent statefulness, not from React. When the component re-renders, the new state and props are irrelevant to the value displayed within the input - again, because this value comes from the state of the HTML element, not from React.