How to INSERT data into multiple columns from multiple queries? - sql-server

Question

This SQL Server stored procedure takes four parameters to show a table order by dates between FromDate and ToDate as follows:
CREATE PROCEDURE GetLedger
(#FromDate date,
#ToDate date,
#Supplier int,
#MOP int)
AS
BEGIN
DECLARE #ExpTABLE TABLE
(
RowNo int,
TranDate date,
NetExpense float
)
INSERT INTO #ExpTABLE
SELECT
ROW_NUMBER() OVER (ORDER BY TranDate), TranDate, SUM(NetAmount)
FROM
Expenditure
WHERE
TranDate BETWEEN #FromDate AND #ToDate
AND SupplierID = #Supplier
AND MOP = #MOP
GROUP BY
TranDate
DECLARE #Data TABLE
(
RDate DATE,
Expense float
PRIMARY KEY (RDate)
)
WHILE (#FromDate <= #ToDate)
BEGIN
INSERT INTO #Data (RDate)
VALUES (#FromDate)
SELECT #FromDate = DATEADD(DAY, 1, #FromDate)
END
WHILE (#FromDate <= #ToDate)
BEGIN
INSERT INTO #Data (Expense)
SELECT NetExpense
FROM #ExpTABLE
WHERE TranDate = #FromDate
SELECT #FromDate = DATEADD(DAY, 1, #FromDate)
END
SELECT * FROM #Data
END
--EXEC GetLedger '2020-03-01' ,'2020-03-31',2,2
The data in #ExpTABLE is like this:
RowNo TranDate NetExpense
------------------------------
1 2020-03-15 35
Now, I am trying to INSERT this NetExpense of '2020-03-15' in #Data Table in the respective date while the rest NetExpense of Other dates remain null.
This INSERT query:
WHILE (#FromDate <= #ToDate)
BEGIN
INSERT INTO #Data (Expense)
SELECT NetExpense
FROM #ExpTABLE
WHERE TranDate = #FromDate
SELECT #FromDate = DATEADD(DAY, 1, #FromDate)
END
is inserting NULL in all dates including '2020-03-15'. What am I missing here?

Answer 1

In order to have a row for every date in your range it would be helpful to use a Calendar table. There are lots of resources available on how to do that like this one. Another option is to create your a calendar table on the fly as a common table expression (CTE) like this.
When developing a stored procedure I like to get it working just as a regular SQL statement and once I have that I can transform it into a stored procedure. So here is the regular SQL statement that should get you going.
DECLARE
#FromDate DATE
, #ToDate DATE
, #Supplier INT
, #MOP INT;
-- set these values to whatever you would pass to your stored procedure
SET #FromDate = '2020-03-01';
SET #ToDate = '2020-03-31';
SET #Supplier = 2;
SET #MOP = 3;
DECLARE #Expenditure TABLE
(
ID INT NOT NULL
, TranDate DATE NOT NULL
, SupplierID INT NOT NULL
, MOP INT NOT NULL
, NetAmount DECIMAL(10, 2) NOT NULL
);
INSERT INTO #Expenditure (ID, TranDate, SupplierID, MOP, NetAmount)
VALUES
(1, '02/28/2020', 2, 3, 200.12)
, (2, '03/15/2020', 2, 3, 125.10)
, (3, '03/15/2020', 2, 3, 74.90)
, (4, '03/17/2020', 3, 3, 150.32)
, (5, '03/18/2020', 2, 3, 250.78)
;WITH cteCalendar (MyDate) AS
(
SELECT CONVERT(DATE, #FromDate) AS MyDate
UNION ALL
SELECT DATEADD(DAY, 1, MyDate)
FROM cteCalendar
WHERE DATEADD(DAY, 1, MyDate) <= #ToDate
)
SELECT
ROW_NUMBER() OVER (ORDER BY x.TranDate) AS [RowNo]
, x.TranDate
, x.NetExpense
FROM (
SELECT
c.MyDate AS TranDate
, SUM(e.NetAmount) AS [NetExpense]
FROM cteCalendar c
LEFT JOIN #Expenditure e ON c.MyDate = e.TranDate
AND e.SupplierID = #Supplier
AND e.MOP = #MOP
GROUP BY c.MyDate
) x;
Here is a demo of the code.