Related
If you run the below code you will get a result that looks like the following:
ITEM DIFF_QTY DATE_OUTGO WAREH COMPANY
1000 -5, -3, -4, 2017-08-01, 2017-08-02, 2017-08-03, WH CMP
Which is great, this is the output that I am looking for. Sadly this only works when a specific ITEM is selected. If I remove the WHERE then everything is put on the same row of output.
So how would I separate the results by grouping (ITEM, WAREH, COMPANY)? So that the end result would look like this:
ITEM DIFF_QTY DATE_OUTGO WAREH COMPANY
1000 -5, -3, -4, 2017-08-01, 2017-08-02, 2017-08-03, WH CMP
1001 -10, -13 2017-08-01, 2017-08-03 WH CMP
Code
DECLARE #tempTable TABLE (
ITEM nvarchar(32),
DIFF_QTY nvarchar(6),
DATE_OUTGO nvarchar(10),
WAREH nvarchar(5),
COMPANY nvarchar(5)
)
INSERT INTO #tempTable (ITEM, DIFF_QTY, DATE_OUTGO, WAREH, COMPANY)
VALUES
(1000, '-5', '2017-08-01', 'WH', 'CMP'),
(1000, '-3', '2017-08-02', 'WH', 'CMP'),
(1000, '-4', '2017-08-03', 'WH', 'CMP'),
(1001, '-10', '2017-08-01', 'WH', 'CMP'),
(1001, '-13', '2017-08-03', 'WH', 'CMP')
SELECT *
FROM #tempTable
DECLARE #itemNum nvarchar(32)
DECLARE #diffQty nvarchar(max)
DECLARE #dateOutgo nvarchar(max)
DECLARE #warehouse nvarchar(5)
DECLARE #company nvarchar(5)
SET #diffQty = ''
SET #dateOutgo = ''
SELECT
#itemNum = ITEM,
#diffQty = #diffQTY + DIFF_QTY + ', ',
#dateOutgo = #dateOutgo + DATE_OUTGO + ', ',
#warehouse = WAREH,
#company = COMPANY
FROM
#tempTable
WHERE
ITEM = 1000
SELECT #itemNum ITEM_NUM, #diffQty DIFF_QTY, #dateOutgo DATE_OUTGO, #warehouse WAREHOUSE, #company COMPANY
I've looked at multiple threads about coalesce but pretty much every solution requires that you don't do multiple things at the same time (SELECT, GROUP, COALESCE, Multiple columns etc...)
You cannot use scalar variables, like #itemNum nvarchar(32), to store tabular data.
The output you want to achieve is most commonly generated in SQL Server using FOR XML PATH:
SELECT t.ITEM,
STUFF((SELECT ',' + x.DIFF_QTY
FROM #tempTable AS x
WHERE x.ITEM = t.ITEM AND
x.WAREH = t.WAREH AND
x.COMPANY = t.COMPANY
FOR XML PATH('')), 1, 1, '') AS DIFF_QTY,
STUFF((SELECT ',' + x.DATE_OUTGO
FROM #tempTable AS x
WHERE x.ITEM = t.ITEM AND
x.WAREH = t.WAREH AND
x.COMPANY = t.COMPANY
FOR XML PATH('')), 1, 1, '') AS DATE_OUTGO
FROM #tempTable AS t
GROUP BY t.ITEM, t.WAREH, t.COMPANY
Output:
ITEM DIFF_QTY DATE_OUTGO
-----------------------------------------------------
1000 -5,-3,-4 2017-08-01,2017-08-02,2017-08-03
1001 -10,-13 2017-08-01,2017-08-03
You can use FOR XML PATH('') to concatenate the values:
SELECT
t1.ITEM,
a.DIFF_QTY,
b.DATE_OUTGO,
t1.WAREH,
t1.COMPANY
FROM #tempTable t1
CROSS APPLY(
SELECT DIFF_QTY = STUFF((
SELECT ', ' + CAST(t2.DIFF_QTY AS VARCHAR(100))
FROM #tempTable t2
WHERE
t2.ITEM = t1.ITEM
AND t2.WAREH = t1.WAREH
AND t2.COMPANY = t2.COMPANY
ORDER BY t2.DATE_OUTGO
FOR XML PATH('')
), 1, 1, '')
) a
CROSS APPLY(
SELECT DATE_OUTGO = STUFF((
SELECT ', ' + CAST(t2.DATE_OUTGO AS VARCHAR(10))
FROM #tempTable t2
WHERE
t2.ITEM = t1.ITEM
AND t2.WAREH = t1.WAREH
AND t2.COMPANY = t2.COMPANY
ORDER BY t2.DATE_OUTGO
FOR XML PATH('')
), 1, 1, '')
) b
GROUP BY
t1.ITEM, t1.WAREH, t1.COMPANY, a.DIFF_QTY, b.DATE_OUTGO
DECLARE #tempTable TABLE (
ITEM nvarchar(32),
DIFF_QTY nvarchar(6),
DATE_OUTGO nvarchar(10),
WAREH nvarchar(5),
COMPANY nvarchar(5)
)
INSERT INTO #tempTable (ITEM, DIFF_QTY, DATE_OUTGO, WAREH, COMPANY)
VALUES
(1000, '-5', '2017-08-01', 'WH', 'CMP'),
(1000, '-3', '2017-08-02', 'WH', 'CMP'),
(1000, '-4', '2017-08-03', 'WH', 'CMP'),
(1001, '-10', '2017-08-01', 'WH', 'CMP'),
(1001, '-13', '2017-08-03', 'WH', 'CMP')
SELECT *
FROM #tempTable
DECLARE #itemNum nvarchar(32)
DECLARE #diffQty nvarchar(max)
DECLARE #dateOutgo nvarchar(max)
DECLARE #warehouse nvarchar(5)
DECLARE #company nvarchar(5)
SET #diffQty = ''
SET #dateOutgo = ''
SELECT distinct ITEM ,
STUFF((SELECT ', ' + CAST(DIFF_QTY AS NVARCHAR(MAX)) [text()]
FROM #tempTable temp
where t.ITEM=temp.ITEM
FOR XML PATH(''), TYPE)
.value('.','NVARCHAR(MAX)'),1,2,'') DIFF_QTY,
STUFF((SELECT ', ' + CAST(DATE_OUTGO AS NVARCHAR(MAX)) [text()]
FROM #tempTable temp
where t.ITEM=temp.ITEM
FOR XML PATH(''), TYPE)
.value('.','NVARCHAR(MAX)'),1,2,'') DATE_OUTGO,
WAREH,COMPANY
from #tempTable t
Hope it works exactly you want
Can I create a view or function using the below query? It uses temp tables. I am not able to create either a view or function.
--TEmp table--
IF OBJECT_ID('tempdb..#Enquiries') IS NOT NULL
DROP TABLE #Enquiries
GO
CREATE TABLE #Enquiries
(ID INT,PID INT,Name VARCHAR(50),Enquiries INT,EnquiryDate datetime)
INSERT INTO #Enquiries
SELECT ROW_NUMBER()
OVER (ORDER BY ProjectName) AS Row, (SELECT top 1 ITEM FROM DBO.split(e.InterestedProjects,',')) as Projects,P.ProjectName,COUNT(CAST(EnquiryDate AS DATE)) AS Enquiries,CAST(EnquiryDate AS DATE) AS EnquiryDate
FROM tbl_Enquiry e INNER JOIN
tbl_Projects AS P ON P.ProjectId = (SELECT TOP 1 ITEM FROM DBO.split(e.InterestedProjects,','))
WHERE e.IsActive=1 and e.isdeleted=0 AND p.IsActive=1 AND p.IsDeleted=0 AND P.ProjectId IN (SELECT TOP 1 ITEM FROM DBO.split(e.InterestedProjects,','))
GROUP BY e.InterestedProjects,P.ProjectName,CAST(EnquiryDate AS DATE)
--SiteVisits
IF OBJECT_ID('tempdb..#SiteVisit') IS NOT NULL
DROP TABLE #SiteVisit
GO
CREATE TABLE #SiteVisit
(ID INT,PID INT,Name VARCHAR(50),Sitevisits INT,PickUpDatetime datetime)
INSERT INTO #SiteVisit
SELECT ROW_NUMBER() OVER (ORDER BY ProjectName) AS Row,s.ProjectId,p.ProjectName As Name,count(sd.PickUpDatetime) AS Sitevisits,CAST(PickUpDatetime AS DATE) AS PickUpDatetime FROM tbl_SiteVisit s
INNER JOIN tbl_SiteVisitDetails sd ON s.SiteVisitId=sd.SiteVisitId
INNER JOIN tbl_Projects p ON p.ProjectId=s.ProjectId
WHERE s.IsActive=1 and s.isdeleted=0 AND sd.isactive=1 AND sd.isdeleted=0
GROUP BY s.ProjectId,sd.PickUpDatetime,p.ProjectName,CAST(PickUpDatetime AS DATE)
--Bookings
IF OBJECT_ID('tempdb..#Bookings') IS NOT NULL
DROP TABLE #Bookings
GO
CREATE TABLE #Bookings
(ID INT,PID INT,Name VARCHAR(50),Bookings INT,BookingDate datetime,Revenue money,Area float)
INSERT INTO #Bookings
SELECT ROW_NUMBER() OVER (ORDER BY ProjectName) AS Row, u.ProjectId AS ProjectId,p.ProjectName,count(u.ProjectId) AS Bookings,CAST(b.BookingDate AS DATE) AS BookingDate,SUM(b.TotalAmount) AS [Revenue],SUM(u.UnitArea) AS [Area] FROM tbl_Bookings b
INNER JOIN tbl_Unit u ON b.UnitId=u.UnitId
INNER JOIN tbl_Projects p on p.ProjectId=u.ProjectId
WHERE b.IsActive=1 AND b.IsDeleted=0 and u.IsActive=1 AND u.IsDeleted=0 AND u.Status = 'B'
GROUP BY u.ProjectId,p.ProjectName,CAST(b.BookingDate AS DATE),b.TotalAmount,u.UnitArea
--ORDER BY u.ProjectId
IF OBJECT_ID('tempdb..#T1') IS NOT NULL
DROP TABLE #T1
create TABLE #T1 (
PrimaryNo INT,
EnquiryDate Date,
Enquiries INT,
SiteVisits INT,
Bookings INT,
Revenue Money,
Area Float,
PID INT,
ProjectName nvarchar(max)
)
INSERT INTO #T1(PrimaryNo,EnquiryDate,Enquiries,PID,ProjectName)
SELECT ID,EnquiryDate,sum(enquiries) AS Enquiries,PID,Name FROM #Enquiries GROUP BY id,pid,Name,enquirydate
DECLARE #SVDate date
DECLARE #SV11 INT
DECLARE #BookingDate Date
DECLARE #Bookings11 INT
DECLARE #Revenue11 MONEY
DECLARE #Area11 FLOAT
DECLARE #intFlag_pw11 INT
SET #intFlag_pw11 = 1
DECLARE #TableCntw11 INT
DECLARE #Date Date
DECLARE Cur_SiteVisit CURSOR FAST_FORWARD FOR
SELECT PickUpDatetime FROM #SiteVisit
OPEN Cur_SiteVisit
FETCH NEXT FROM Cur_SiteVisit INTO #Date
DECLARE #ProjectId INT
DECLARE #Count INT = 1
WHILE ##FETCH_STATUS = 0
BEGIN
SET #ProjectId = (SELECT PID FROM #SiteVisit WHERE ID = #Count)
SET #SVDate = ISNULL((SELECT CAST(PickUpDatetime AS DATE) FROM #SiteVisit
WHERE CAST(PickUpDatetime AS DATE) = #Date AND PID = #ProjectId
GROUP BY PickUpDatetime),'-')
SET #SV11 = ISNULL((SELECT Sitevisits FROM #SiteVisit
WHERE CAST(PickUpDatetime AS DATE) = #Date AND PID = #ProjectId
GROUP BY Sitevisits),0)
EXEC ('UPDATE #T1 SET SiteVisits = ' + #SV11 + ' WHERE EnquiryDate = ' + ''''+ #SVDate +''' AND PID =' + #ProjectId)
FETCH NEXT FROM Cur_SiteVisit INTO #Date
SET #Count = #Count + 1
END
CLOSE Cur_SiteVisit
DEALLOCATE Cur_SiteVisit
--For Bookings
DECLARE #Date1 Date
DECLARE Cur_Bookings CURSOR FAST_FORWARD FOR
SELECT BookingDate FROM #Bookings
OPEN Cur_Bookings
FETCH NEXT FROM Cur_Bookings INTO #Date1
DECLARE #ProjectId1 INT
DECLARE #Count1 INT = 1
WHILE ##FETCH_STATUS = 0
BEGIN
SET #ProjectId1 = (SELECT PID FROM #Bookings WHERE ID = #Count1)
SET #Bookings11 = ISNULL((SELECT TOP 1 Bookings FROM #Bookings
WHERE CAST(BookingDate AS DATE) = #Date1 AND PID = #ProjectId1
GROUP BY Bookings),0)
SET #BookingDate = ISNULL((SELECT TOP 1 CAST(BookingDate AS DATE) FROM #Bookings
WHERE CAST(BookingDate AS DATE) = #Date1 AND PID = #ProjectId1
GROUP BY CAST(BookingDate AS DATE)),'-')
SET #Revenue11 = ISNULL((SELECT TOP 1 Revenue FROM #Bookings
WHERE CAST(BookingDate AS DATE) = #Date1 AND PID = #ProjectId1
GROUP BY Revenue),0)
SET #Area11 = ISNULL((SELECT TOP 1 Area FROM #Bookings
WHERE CAST(BookingDate AS DATE) = #Date1 AND PID = #ProjectId1
GROUP BY Area),0)
EXEC ('UPDATE #T1 SET Bookings = ' + #Bookings11 + ',Revenue=' + #Revenue11 + ',Area = ' + #Area11 + ' WHERE EnquiryDate = ' + '''' + #BookingDate + ''' AND PID =' + #ProjectId1)
FETCH NEXT FROM Cur_Bookings INTO #Date1
SET #Count1 = #Count1 + 1
END
CLOSE Cur_Bookings
DEALLOCATE Cur_Bookings
Select * from #T1
You can't create a view from that, if only because you're doing a number of inserts and other actions. A view is created from a single query.
With regard to user-defined functions: you cannot use dynamic SQL, which you are doing:
EXEC ('UPDATE #T1 SET Bookings = ' + #Bookings11 + ',Revenue=' + #Revenue11 +
',Area = ' + #Area11 + ' WHERE EnquiryDate = ' + '''' + #BookingDate +
''' AND PID =' + #ProjectId1)
You also can't use temp tables. Both of these limitations are documented here: http://msdn.microsoft.com/en-us/library/ms191320.aspx.
But, you can do all of these things in a stored procedure. It is also possible to direct the output of a stored procedure to a temp table or table variable, allowing you to use the output in another query:
INSERT INTO dbo.MyTable
(MyTableId, Column1, Column2) -- arbitrary-chosen column names
EXEC dbo.MyStoredProcedure
SELECT *
FROM dbo.MyTable
WHERE Column1 = 'Some Value'
Finally, you might be able to rework your SQL to work with table variables rather than temp tables, which are allowed. It also looked to me like your dynamic SQL didn't need to be dynamic, so you might be able to eliminate that as well.
Hope this helps.
Ok i have 2 questions 1) I've googled that error(in title) but I cant seem to get it to help me, my proc:
CREATE PROCEDURE [dbo].[p_Target]
AS
BEGIN
SET NOCOUNT ON
CREATE TABLE #tmp1
(
AUD_ID BIGINT,
RowCounter BIGINT,
DistinctCounter BIGINT,
NACounter BIGINT,
Total BIGINT,
[Status] VARCHAR(MAX)
)
INSERT INTO #tmp1 EXEC [p_GetCompleteIncompleteNaOverviewSCORE]
DECLARE #Total AS INT
SELECT #Total = COUNT(*)
FROM (
SELECT CASE WHEN CONVERT(DATETIME,CONVERT(CHAR(10),DATEADD(DAY,0,t2.AUD_TargetDate), 101)) < CONVERT(DATETIME,CONVERT(CHAR(10),DATEADD(DAY,0,GETDATE()), 101))
THEN 'Over Due: '
ELSE 'On Time: ' END AS [Target Status]
FROM #tmp1 t1 INNER JOIN dbo.Audit t2
ON t1.AUD_ID = t2.AUD_ID
WHERE t1.[Status] = 'Open') DER
SELECT ([Target Status] + '' + CAST(COUNT(*) AS NVARCHAR(255)) + ' of ' + CAST(#Total AS NVARCHAR(255))) AS TargetStatus, (SELECT COUNT(*)) * 100 / (SELECT ([Target Status] + '' + CAST(COUNT(*) AS NVARCHAR(255))) AS [Count]
FROM (
SELECT CASE WHEN CONVERT(DATETIME,CONVERT(CHAR(10),DATEADD(DAY,0,t2.AUD_TargetDate), 101)) < CONVERT(DATETIME,CONVERT(CHAR(10),DATEADD(DAY,0,GETDATE()), 101))
THEN 'Over Due: '
ELSE 'On Time: ' END AS [Target Status]
FROM #tmp1 t1 INNER JOIN dbo.Audit t2
ON t1.AUD_ID = t2.AUD_ID
WHERE t1.[Status] = 'Open') DER
GROUP BY [Target Status]
END
GO
I've tied adding ) to NVARCHAR(255))) AS [Count] but still errors,
2)I need to get AS [Count] as a percentag, if anyone can help? That is my try code maybe i am on the right track.?
You're missing a close paren on your final subselect. Also, you're missing the 'S' in SET NOCOUNT. Updates below.
CREATE PROCEDURE [dbo].[p_Target]
AS
BEGIN
SET NOCOUNT ON
CREATE TABLE #tmp1
(
AUD_ID BIGINT,
RowCounter BIGINT,
DistinctCounter BIGINT,
NACounter BIGINT,
Total BIGINT,
[Status] VARCHAR(MAX)
)
INSERT INTO #tmp1 EXEC [p_GetCompleteIncompleteNaOverviewSCORE]
DECLARE #Total AS INT
SELECT #Total = COUNT(*)
FROM (
SELECT CASE WHEN CONVERT(DATETIME,CONVERT(CHAR(10),DATEADD(DAY,0,t2.AUD_TargetDate), 101)) < CONVERT(DATETIME,CONVERT(CHAR(10),DATEADD(DAY,0,GETDATE()), 101))
THEN 'Over Due: '
ELSE 'On Time: ' END AS [Target Status]
FROM #tmp1 t1 INNER JOIN dbo.Audit t2
ON t1.AUD_ID = t2.AUD_ID
WHERE t1.[Status] = 'Open') DER
SELECT ([Target Status] + '' + CAST(COUNT(*) AS NVARCHAR(255)) + ' of ' + CAST(#Total AS NVARCHAR(255))) AS TargetStatus, (SELECT COUNT(*)) * 100 / (SELECT ([Target Status] + '' + CAST(COUNT(*) AS NVARCHAR(255))) AS [Count]
FROM (
SELECT CASE WHEN CONVERT(DATETIME,CONVERT(CHAR(10),DATEADD(DAY,0,t2.AUD_TargetDate), 101)) < CONVERT(DATETIME,CONVERT(CHAR(10),DATEADD(DAY,0,GETDATE()), 101))
THEN 'Over Due: '
ELSE 'On Time: ' END AS [Target Status]
FROM #tmp1 t1 INNER JOIN dbo.Audit t2
ON t1.AUD_ID = t2.AUD_ID
WHERE t1.[Status] = 'Open') DER
GROUP BY [Target Status]
)
END
GO
Is it the missing 'S' on SET NOCOUNT ON after the initial begin perhaps?
It looks like your SELECT statement above your last last FROM statement has an un-closed parentheses. That would make the parser throw an error when it hits the END statement, since it still thinks it's working on the SELECT.
SELECT ([Target Status] + '' + CAST(COUNT(*) AS NVARCHAR(255)) + ' of ' + CAST(#Total AS NVARCHAR(255))) AS TargetStatus, (SELECT COUNT(*)) * 100 / (SELECT ([Target Status] + '' + CAST(COUNT(*) AS NVARCHAR(255))) AS [Count]
^
Whenever you get an incorrect Syntax error it's best to carefully go through your code and check that all statements are well formed and complete. Usually google can't help you, since it's very specific to your code. A good approach to finding the fault is to locate the point of the error (END in this case) and work backwards. The cause of the error may be quite far above the actual point that the error is thrown, but it will be somewhere above the error. And reading backwards can help you catch simple mistakes.
Create Table TblAccount (UserName nvarchar(20) Primary Key,UserPwd varchar(20) not null)
Declare #i int
Set #i=1
While #i<=10
I have one question
BEGIN
Insert INTO TblAccount Values('Seng Vitou'+CAST(#i AS VARCHar(2)),REVERSE('pwd'+CAST(#i as varchar(2))
SET #i=#i+1
End
Msg 156, Level 15, State 1, Line 11
Incorrect syntax near the keyword 'SET'.
I have this SQL query which is valid but always times out.
CREATE PROCEDURE Sibm_getstudentdivisionattendancereport2 (
#course_id INT,
--#Subject_Id int,
#academic_year INT,
#division_id INT,
#semister_id INT,
#fromdate1 DATETIME,
#todate1 DATETIME)
AS
BEGIN
DECLARE #fromdate VARCHAR(100)
DECLARE #todate VARCHAR(100)
SET #fromdate=CONVERT(VARCHAR(10), #fromdate1, 105)
SET #todate=CONVERT(VARCHAR(10), #todate1, 105)
CREATE TABLE #getstudentmarks
(
id INT NOT NULL,
roll_no VARCHAR(100),
stud_id INT,
stud_name VARCHAR(200),
stud_last_name VARCHAR(200),
subject_name VARCHAR(200),
marks INT,
student_id INT,
division_id INT,
division VARCHAR(50),
attended VARCHAR(12),
exempted VARCHAR(12),
total_attendance VARCHAR(12),
attendancepercentage VARCHAR(30),
subject_id INT
)
CREATE TABLE #getstudentmarks1
(
id INT IDENTITY(1, 1) NOT NULL,
roll_no VARCHAR(100),
stud_id INT,
stud_name VARCHAR(200),
stud_last_name VARCHAR(200),
subject_name VARCHAR(200),
marks INT,
student_id INT,
division_id INT,
division VARCHAR(50),
attended VARCHAR(12),
exempted VARCHAR(12),
total_attendance VARCHAR(12),
attendancepercentage VARCHAR(30),
subject_id INT
)
CREATE TABLE #divisionlist
(
division_id INT
)
CREATE TABLE #getstudent_attended
(
id INT IDENTITY(1, 1) NOT NULL,
student_id INT,
exempted VARCHAR(12),
attended VARCHAR(12)
)
DECLARE #Total_Lectures INT
DECLARE #Student_Id INT
DECLARE #TotalConductedLecture INT
DECLARE #TotalExempted INT
INSERT INTO #getstudentmarks1
(roll_no,
student_id,
stud_name,
stud_last_name)
SELECT DISTINCT( SA.roll_no ),
SA.student_id AS id,
SR.first_name,
SR.last_name
FROM tblstudent_academic_record SA,
tblstudent_record SR
WHERE SR.student_id = SA.student_id
AND SR.student_id IN (SELECT SAR.student_id
FROM tblstudent_academic_record SAR
INNER JOIN tblcoursesemester_subject_student
CSS
ON SAR.student_id = CSS.student_id
AND SAR.current_record = 1
AND SAR.course_id = #course_id
AND
SAR.semister_id = #semister_id
AND
SAR.division_id = #division_id
AND
SAR.academic_year = #academic_year)
CREATE TABLE #temp
(
id INT,
subject_name VARCHAR(100)
)
DECLARE #Master_Id INT
SET #Master_Id = 0
IF EXISTS(SELECT *
FROM tblcoursesemester_main
WHERE academic_year = #Academic_Year
AND course_id = #Course_Id
AND semester_id = #semister_id)
BEGIN
SET #Master_Id = (SELECT TOP 1 cs_id
FROM tblcoursesemester_main
WHERE academic_year = #Academic_Year
AND course_id = #Course_Id
AND semester_id = #semister_id)
END
INSERT INTO #temp
SELECT id,
subject_name
FROM tblsubject
WHERE id IN (SELECT subject_id
FROM tblcoursesemester_subject
WHERE is_archieve IS NULL
AND cs_id = #Master_Id)
AND isarchive IS NULL
ORDER BY subject_name
DECLARE #tempid INT
DECLARE #sub VARCHAR(max)
DECLARE c1 CURSOR FOR
SELECT student_id
FROM #getstudentmarks1
OPEN c1
FETCH next FROM c1 INTO #Student_Id
WHILE ##FETCH_STATUS = 0
BEGIN
DECLARE c2 CURSOR FOR
SELECT id
FROM #temp
OPEN c2
FETCH next FROM c2 INTO #tempid
WHILE ##FETCH_STATUS = 0
BEGIN
UPDATE #getstudentmarks1
SET subject_name = (SELECT subject_name
FROM #temp
WHERE id = #tempid),
subject_id = #tempid
WHERE student_id = #Student_Id
FETCH next FROM c2 INTO #tempid
END
CLOSE c2
DEALLOCATE c2
FETCH next FROM c1 INTO #Student_Id
END
CLOSE c1
DEALLOCATE c1
--select * from #TEMP
--SET IDENTITY_INSERT #GetStudentMarks1 ON
INSERT INTO #getstudentmarks
(id,
roll_no,
stud_id,
stud_name,
stud_last_name,
subject_name,
marks,
student_id,
division_id,
division,
attended,
exempted,
total_attendance,
attendancepercentage,
subject_id)
SELECT #getstudentmarks1.id,
roll_no,
stud_id,
stud_name,
stud_last_name,
#temp.subject_name,
marks,
student_id,
division_id,
division,
attended,
exempted,
total_attendance,
attendancepercentage,
#temp.id
FROM #getstudentmarks1
CROSS JOIN #temp
-- select * from #GetStudentMarks cross join #TEMP
--SET IDENTITY_INSERT #GetStudentMarks1 OFF
--select * from #GetStudentMarks
---------calculate percentage-------------------
INSERT INTO #divisionlist
SELECT divisionid
FROM tblschedulemaster
WHERE academicyear = #academic_year
AND courseid = #Course_Id
AND semesterid = #Semister_Id
DECLARE #subject_id INT
DECLARE c1 CURSOR FOR
SELECT student_id
FROM #getstudentmarks
OPEN c1
FETCH next FROM c1 INTO #Student_Id
WHILE ##FETCH_STATUS = 0
BEGIN
DECLARE c3 CURSOR FOR
SELECT subject_id
FROM #getstudentmarks
OPEN c3
FETCH next FROM c3 INTO #subject_id
WHILE ##FETCH_STATUS = 0
BEGIN
-- GET TOTAL LECTURES OF EACH STUDENT
SELECT #Total_Lectures = Count([id])
FROM tblfacultyschedule
WHERE subjectid = #subject_id
AND sch_mas_id IN (SELECT [id]
FROM tblschedulemaster
WHERE academicyear = #academic_year
AND courseid = #Course_Id
AND semesterid = #Semister_Id
AND divisionid IN (
-- Changed Divisions list Query Starts
SELECT
divisionid
FROM
tblschedulemaster
WHERE
id IN (SELECT DISTINCT
sch_mas_id
FROM
tblfacultyschedule
WHERE
[date] >= #fromdate
AND [date] <= #todate
AND
id IN (SELECT DISTINCT
schedule_id
FROM
tblstudentattendence
WHERE
student_id = #Student_Id
AND schedule_id IN (SELECT
id
FROM
tblfacultyschedule
WHERE
subjectid =
#subject_id
AND
sch_mas_id IN(SELECT
id
FROM
tblschedulemaster
WHERE
academicyear =
#academic_year
AND
courseid =
#Course_Id
AND
semesterid
=
#Semister_Id))
))
-- Changed Divisions list Query Ends
))
AND COALESCE(other_activity, '') NOT LIKE '%LUNCH%'
--print 'subject id'
--print #subject_id
--print 'totol att'
--print #Total_Lectures
-- Total Conducted Lectures
SET #TotalConductedLecture =
(SELECT
COALESCE(Count(is_attended), 0) AS Attended
FROM tblstudentattendence
WHERE student_id = #Student_id
AND is_attended = 'YES'
AND
schedule_id IN (SELECT [id]
FROM
tblfacultyschedule
WHERE
[date] >= #fromdate
AND [date] <= #todate
AND subjectid = #subject_id
AND
sch_mas_id IN (SELECT [id]
FROM
tblschedulemaster
WHERE
academicyear = #academic_year
AND courseid = #course_id
AND semesterid = #semister_id
AND divisionid IN (SELECT
division_id
FROM
#divisionlist))
AND
COALESCE(other_activity, '')
NOT
LIKE
'%LUNCH%'
AND
subjectid IN (SELECT DISTINCT
subject_id
FROM
tblcoursesemester_subject
WHERE
cs_subject_id IN (SELECT
cs_subject_id
FROM
tblcoursesemester_subject_student
WHERE
cs_subject_id IN (SELECT
cs_subject_id
FROM
tblcoursesemester_subject
WHERE
cs_id IN (SELECT cs_id
FROM
tblcoursesemester_main
WHERE
academic_year = #academic_year
AND course_id = #course_id
AND semester_id = #semister_id
)
AND is_archieve IS NULL)
AND student_id = #Student_id
AND is_archieve IS NULL)
AND is_archieve IS NULL)))
--print 'attended'
-- print #TotalConductedLecture
-- NOW COUNT Exempted LECTURES
SET #TotalExempted=
(SELECT COALESCE(Count(is_attended), 0) AS
Attended
FROM tblstudentattendence
WHERE student_id = #Student_id
AND is_attended = 'EXEMPTED'
AND schedule_id IN (SELECT [id]
FROM
tblfacultyschedule
WHERE
[date] >= #fromdate
AND [date] <= #todate
AND subjectid =
#subject_id
AND sch_mas_id IN (SELECT
[id]
FROM
tblschedulemaster
WHERE
academicyear =
#academic_year
AND
courseid =
#course_id
AND
semesterid =
#semister_id
AND
divisionid IN (
SELECT
division_id
FROM
#divisionlist))
AND
COALESCE(other_activity, '') NOT
LIKE
'%LUNCH%'
AND
subjectid IN (SELECT DISTINCT
subject_id
FROM
tblcoursesemester_subject
WHERE
cs_subject_id IN (SELECT
cs_subject_id
FROM
tblcoursesemester_subject_student
WHERE
cs_subject_id IN (SELECT
cs_subject_id
FROM
tblcoursesemester_subject
WHERE
cs_id IN (SELECT cs_id
FROM
tblcoursesemester_main
WHERE
academic_year = #academic_year
AND course_id = #course_id
AND semester_id = #semister_id
)
AND is_archieve IS NULL)
AND student_id = #Student_id
AND is_archieve IS NULL)
AND is_archieve IS NULL)))
-- print 'not attended'
-- print #TotalExempted
UPDATE #getstudentmarks
SET #getstudentmarks.total_attendance = #Total_Lectures,
#getstudentmarks.attended = #TotalConductedLecture,
#getstudentmarks.exempted = #TotalExempted
WHERE student_id = #Student_Id
AND subject_id = #subject_id
FETCH next FROM c3 INTO #subject_id
END
CLOSE c3
DEALLOCATE c3
FETCH next FROM c1 INTO #Student_Id
END
CLOSE c1
DEALLOCATE c1
-- CURSOR ENDS
--select * from #GetStudentMarks
UPDATE #getstudentmarks
SET #getstudentmarks.division = tbldivision.division
FROM #getstudentmarks,
tbldivision
WHERE #getstudentmarks.division_id = tbldivision.division_id
UPDATE #getstudentmarks
SET #getstudentmarks.attended = #getstudent_attended.attended
FROM #getstudentmarks,
#getstudent_attended
WHERE #getstudentmarks.student_id = #getstudent_attended.student_id
UPDATE #getstudentmarks
SET #getstudentmarks.exempted = #getstudent_attended.exempted
FROM #getstudentmarks,
#getstudent_attended
WHERE #getstudentmarks.student_id = #getstudent_attended.student_id
UPDATE #getstudentmarks
SET attended = Isnull(attended, '0')
UPDATE #getstudentmarks
SET exempted = Isnull(exempted, '0')
UPDATE #getstudentmarks
SET total_attendance = Isnull(total_attendance, '0')
--UPDATE #GetStudentMarks SET #GetStudentMarks.AttendancePercentage=CAST(CAST((CAST(#GetStudentMarks.Attended AS NUMERIC(32,2)) * 100)/CAST(#GetStudentMarks.Total_Attendance AS NUMERIC(32,2)) AS NUMERIC(32,2)) AS VARCHAR(30))
--WHERE #GetStudentMarks.Total_Attendance <> '0'
UPDATE #getstudentmarks
SET
#getstudentmarks.attendancepercentage = Cast(
Cast(
Cast(( Cast(#getstudentmarks.attended AS NUMERIC(32, 2)) * 100 ) +
(
Cast(
#getstudentmarks.exempted AS
NUMERIC(32, 2)) *
100 ) AS NUMERIC(32, 2)) /
Cast
(
#getstudentmarks.total_attendance AS
NUMERIC(
32, 2)) AS NUMERIC(32, 2)) AS
VARCHAR
(30))
WHERE #getstudentmarks.total_attendance <> '0'
--+ '' + '%'
UPDATE #getstudentmarks
SET attendancepercentage = Isnull(attendancepercentage, '0.00')
--UPDATE #GetStudentMarks SET #GetStudentMarks.AttendancePercentage = '0 %' WHERE #GetStudentMarks.AttendancePercentage IS NULL
-------------end calculation---------------------
DECLARE #Roll_No VARCHAR(20),
#Stud_Id VARCHAR(20),
#Stud_Name VARCHAR(200),
#Subject_Name VARCHAR(200),
#Stud_Last_Name VARCHAR(200),
#AttendancePercentage VARCHAR(200)
-- select * from #GetStudentMarks
DECLARE #cntColm INT
SELECT #cntColm = Count(roll_no)
FROM #getstudentmarks
GROUP BY roll_no
CREATE TABLE #subject
(
sub_name VARCHAR(200)
)
INSERT INTO #subject
(sub_name)
SELECT DISTINCT( subject_name )
FROM #getstudentmarks
--print #cntColm
CREATE TABLE #getmarkssheet
(
student_id VARCHAR(100),
roll_no VARCHAR(100),
student_name VARCHAR(200)
)
--select * from #Subject
--------------- Cursor To add Columns As a Subject Name-------------------
-- print'text'
DECLARE #Stubject VARCHAR(max)
DECLARE curaddcol CURSOR FOR
SELECT sub_name
FROM #subject
OPEN curaddcol
FETCH next FROM curaddcol INTO #Stubject
WHILE ##FETCH_STATUS = 0
BEGIN
--print #Stubject
DECLARE #column VARCHAR(max)
SELECT #column = Replace(#Stubject, '&', '')
SELECT #column = Replace(#column, 'and', '')
SELECT #column = Replace(#column, '.', '')
SELECT #column = Replace(#column, ',', '')
SELECT #column = Replace(#column, ' ', '')
SELECT #column = Replace(#column, '-', '')
SELECT #column = Replace(#column, '(', '')
SELECT #column = Replace(#column, ')', '')
SELECT #column = Replace(#column, '/', '')
SELECT #column = Replace(#column, '//', '')
SELECT #column = Replace(#column, '\', '')
SELECT #column = Replace(#column, ':', '')
--print 'columnname' + #column
IF( #column <> '' )
BEGIN
EXEC('ALTER TABLE #GetMarksSheet ADD ' + #column +
' VARCHAR(max)')
--print #column
END
SET #cntColm=#cntColm - 1
FETCH next FROM curaddcol INTO #Stubject
END
---------------------------- Cursor Ends------------------------------------------
DECLARE cursubject CURSOR FOR
SELECT roll_no,
student_id,
stud_name,
stud_last_name,
subject_name,
attendancepercentage
FROM #getstudentmarks
OPEN cursubject
FETCH next FROM cursubject INTO #Roll_No, #Stud_Id, #Stud_Name,
#Stud_Last_Name, #Subject_Name, #AttendancePercentage
-- while #cntColm >0
WHILE ##FETCH_STATUS = 0
BEGIN
DECLARE #ColName VARCHAR(max)
SELECT #ColName = Replace(#Subject_Name, '&', '')
SELECT #ColName = Replace(#ColName, 'and', '')
SELECT #ColName = Replace(#ColName, ',', '')
SELECT #ColName = Replace(#ColName, '.', '')
SELECT #ColName = Replace(#ColName, ' ', '')
SELECT #ColName = Replace(#ColName, '-', '')
SELECT #ColName = Replace(#ColName, '(', '')
SELECT #ColName = Replace(#ColName, ')', '')
SELECT #ColName = Replace(#ColName, '/', '')
SELECT #ColName = Replace(#ColName, '//', '')
SELECT #ColName = Replace(#ColName, '\', '')
SELECT #ColName = Replace(#ColName, ':', '')
DECLARE #MarkInPer VARCHAR(max)
SET #MarkInPer=Cast(#AttendancePercentage AS VARCHAR(max))
IF NOT EXISTS (SELECT student_id
FROM #getmarkssheet
WHERE student_id = #Stud_Id)
BEGIN
DECLARE #FullName VARCHAR(400)
--print #AttendancePercentage
--print #ColName+'----' +Cast(#MarkInPer as varchar(max)) +'----'
-- select #MarkInPer=COALESCE(#MarkInPer,0)
-- print #Roll_No + 'roll num'
EXEC('insert into #GetMarksSheet(Student_Id,'+ #ColName +
') values ('+
#Stud_Id +','+#MarkInPer + ')')
-- print #Stud_Name
UPDATE #getmarkssheet
SET student_name = #Stud_Name
WHERE student_id = #Stud_Id
--exec('UPDATE #GetMarksSheet SET Student_Name='+#Stud_Name +' where Roll_No='+#Roll_No)
END
ELSE
EXEC('UPDATE #GetMarksSheet SET '+ #ColName +' = '+#MarkInPer +
' where Student_Id='+#Stud_Id)
SET #cntColm=#cntColm - 1
FETCH next FROM cursubject INTO #Roll_No, #Stud_Id, #Stud_Name,
#Stud_Last_Name, #Subject_Name, #AttendancePercentage
END
SELECT *
FROM #getmarkssheet
END
Ouch. Do it without temp tables and try it in one statement. It looks doable.
Your approach kills the query optimizer's ability to optimize because you give it detailed steps including a (OUCH) cursoer which means single processor loop behavior as you DEMAND it.
This is NOT sql, this is a perversion - sql deals with sets.
I am sure you CAN describ the result in one statement, without the use of temporary tables, and the result may surprise you performance wise ;)
I am having one query which returns me following output.
(No of results not same all time, means sometimes it gives 3 category,sometimes 8 category etc..)
CategoryName
Test1
Test2
Test3
Now i want that store procedure should return me these date in comma separated format.
e.g. output string should be like: Test1,Test2,Test3
Can you please tell me how can i achieve this?
this will work for all characters in your data:
set nocount on;
declare #YourTable table (BirthDay datetime, PersonName varchar(20))
insert into #YourTable VALUES ('1-10-2010', 'Joe' )
insert into #YourTable VALUES ('2-10-2010', 'Bob <&>' )
insert into #YourTable VALUES ('2-10-2010', 'Alice')
set nocount off
--Concatenation with FOR XML and eleminating control/encoded character expansion "& < >"
SELECT
p1.BirthDay
,STUFF(
(SELECT
', ' + p2.PersonName
FROM #YourTable p2
WHERE p2.BirthDay=p1.BirthDay
ORDER BY p2.PersonName
FOR XML PATH(''), TYPE
).value('.','varchar(max)')
,1,2, ''
) AS PersonNames
FROM #YourTable p1
GROUP BY p1.BirthDay
OUTPUT:
BirthDay PersonNames
----------------------- ------------------------
2010-01-10 00:00:00.000 Joe
2010-02-10 00:00:00.000 Alice, Bob <&>
(2 row(s) affected)
Try COALESCE or ISNULL:
DECLARE #returnValue varchar(MAX)
SELECT
#returnValue = COALESCE(#returnValue + ', ', '') + CategoryName
FROM
TableName
Have a look at something like (Full working example)
DECLARE #Table TABLE(
ID INT,
Val VARCHAR(50)
)
INSERT INTO #Table (ID,Val) SELECT 1, 'A'
INSERT INTO #Table (ID,Val) SELECT 1, 'B'
INSERT INTO #Table (ID,Val) SELECT 1, 'C'
INSERT INTO #Table (ID,Val) SELECT 2, 'B'
INSERT INTO #Table (ID,Val) SELECT 2, 'C'
--Concat
SELECT t.ID,
STUFF((
SELECT ',' + t1.Val
FROM #Table AS t1
WHERE t1.ID = t.ID
FOR XML PATH('')
), 1, 1, '')
FROM #Table t
GROUP BY t.ID
Also, you might find that Googling will provide a lot of answers.
One means:
SELECT STUFF((
SELECT ',' + CategoryName AS [text()]
FROM YourTable
FOR XML PATH('')
), 1, 1, '')
...but watch out for XML entities that will be escaped up - e.g. & => &
Just modify the KM answer in a store procedure
ALTER Procedure [dbo].[Payroll_rptAbsentReport]
#FromDate DateTime,
#ToDate DateTime,
#GFacatoryID UniqueIdentifier
As
Begin
-- Temporary table for Row data seperation
CREATE TABLE TestTable(GEmployeeGenInfoID uniqueidentifier, dtAttendDateTime varchar(max))
INSERT INTO
TestTable(GEmployeeGenInfoID, dtAttendDateTime)
SELECT
Payroll_tblAttendance.GEmployeeGenInfoID
,CONVERT(VARCHAR(max), dtAttendDateTime, 105)dtAttendDateTime
FROM Payroll_tblAttendance
INNER JOIN PIS.dbo.PIS_tblEmployeeGenInfo as EmployeeGenInfo ON Payroll_tblAttendance.GEmployeeGenInfoID= EmployeeGenInfo.GEmployeeGenInfoID
WHERE Payroll_tblAttendance.DayStatusID = 0 AND EmployeeGenInfo.GFactoryID=#GFacatoryID AND Payroll_tblAttendance.dtAttendDateTime Between #FromDate and #ToDate ORDER BY dtAttendDateTime
-- Final expected output
SELECT DISTINCT
EmployeeGenInfo.StrEmpName
,EmployeeGenInfo.StrEmpID
,Attendence.CardNo
,EmployeeDesignation.StrDesignationName
,EmployeeDept.StrDepartmentName
-- Count data will be in one column
,(Select COUNT(*) From TestTable Where GEmployeeGenInfoID=Attendence.GEmployeeGenInfoID) TotalAbsent
-- Row data set into one column seperate by coma
,substring( ( SELECT ', ' + dtAttendDateTime as [text()]
FROM TestTable
WHERE GEmployeeGenInfoID = Attendence.GEmployeeGenInfoID
FOR XML path(''), elements
), 3, 1000
) List
FROM
Payroll_tblAttendance as Attendence
INNER JOIN TestTable on TestTable.GEmployeeGenInfoID=Attendence.GEmployeeGenInfoID
INNER JOIN PIS.dbo.PIS_tblEmployeeGenInfo as EmployeeGenInfo ON Attendence.GEmployeeGenInfoID= EmployeeGenInfo.GEmployeeGenInfoID
INNER JOIN PIS.dbo.PIS_tblDesignationInfo as EmployeeDesignation ON EmployeeGenInfo.GDesignationInfoID= EmployeeDesignation.GDesignationInfoID
INNER JOIN PIS.dbo.PIS_tblDepartment as EmployeeDept ON EmployeeGenInfo.GDepartmentID= EmployeeDept.GDepartmentID
WHERE EmployeeGenInfo.GFactoryID=#GFacatoryID AND Attendence.DayStatusID = 0 AND Attendence.dtAttendDateTime Between #FromDate and #ToDate
DROP TABLE TestTable
END