The cursor inside stored procedure not working as expected - sql-server

Question

I have an sql stored procedure, but when I execute it it is not returning the desired out put. Can someone please tell me what I'm doign wrong here...
I put some print statements in there to debug.. the problem seems to be that the cursor is not fetching any results. the result of ##fetch_status is -1
Here is my stored procedure in question:
ALTER PROCEDURE [dbo].[spComplaintsEmailAlert_autoFillForm] (#counterVal int,
#RESULT varchar(50) OUTPUT,
#RESULTDESC varchar(max) OUTPUT)
AS
DECLARE #dateEmailSend varchar(50),
#counter int,
#region varchar(50),
#ola_company varchar(50),
#obj_identified_as varchar(50),
#product_involved varchar(50),
#ola_customer varchar(50),
#product_ut varchar(50);
DECLARE otherCounterVals CURSOR FOR
SELECT
A.CounterVal
FROM [cmpEmailAlerted] A,
[cmpTblProductComplaints] B
WHERE A.CounterVal = B.Counter
AND CONVERT(varchar(10), A.dateEmailSend, 120) = #dateEmailSend
AND B.[Company] = #ola_company
AND B.[Object Identified As] = #obj_identified_as
AND B.[Product Involved] = #product_involved
AND B.Region = #region
AND B.[Customer] = #ola_customer
AND A.CounterVal != #counter;
DECLARE #aCounter int;
BEGIN
SELECT
#dateEmailSend = CONVERT(varchar(10), A.dateEmailSend, 120),
#counter = B.Counter,
#region = B.Region,
#ola_company = B.[Company],
#obj_identified_as = B.[Object Identified As],
#product_involved = B.[Product Involved],
#ola_customer = B.[Customer],
#product_ut = CONVERT(varchar(10), B.[produt u/t], 120)
FROM [cmpEmailAlerted] A,
[cmpTblProductComplaints] B
WHERE A.CounterVal = #counterVal
AND a.CounterVal = B.Counter;
OPEN otherCounterVals;
FETCH NEXT FROM otherCounterVals INTO #aCounter;
PRINT ##fetch_status;
PRINT 'start of the loop';
WHILE ##FETCH_STATUS = 0
BEGIN
PRINT 'in the loop';
SELECT
#RESULTDESC = concat(#resultdesc, #aCounter, ',');
FETCH NEXT FROM otherCounterVals INTO #aCounter;
END;
PRINT 'out the loop';
CLOSE otherCounterVals;
DEALLOCATE otherCounterVals;
--remove the last comma from the resultdesc
IF (SUBSTRING(#RESULTDESC, LEN(#RESULTDESC), 1) = ',')
BEGIN
SELECT
#RESULTDESC = SUBSTRING(#RESULTDESC, 0, (LEN(#RESULTDESC)));
END
SELECT
#RESULT = 'SUCCESS';
END;
Here is the output i am getting:
-1 start of the loop out the loop
(1 row affected)
(1 row affected)

Answer 1

If you want to just build up a comma delimited string of results, there are much, much easier ways of doing it. A straight-forward, naïve way that doesn't rely on any magic STUFF functionality is simply this pattern:
DECLARE #result varchar(max);
SET #result = '';
SELECT #result = #result + ',' + ColumnValueToUse FROM MyTable WHERE <somecondition>
PRINT #result;
You can then peel off the first comma. The result will be every value of "ColumValueToUse" in the "MyTable" table that meets whatever the condition is.... all concatenated together and comma separated. There are fancier ways to do this with STUFF() and FOR XML that handle the comma thing better, and let you do even more fancy stuff.
It's ridiculous to use an expensive cursor (that isn't even declared FAST_FORWARD) for this. Please don't.
As for why your cursor solution isn't working, first ensure your SELECT statement returns the rows you want. Given you don't actually set any of the variables used by the SELECT in the cursor definition, it probably doesn't. But mostly just remove the cursor, please.
Trying to extrapolate from your own example, something like this:
DECLARE #result varchar(max);
SET #result = '';
SELECT #result = #result + ',' + A.CounterVal
FROM [cmpEmailAlerted] A,
[cmpTblProductComplaints] B
WHERE A.CounterVal = B.Counter
AND CONVERT(varchar(10), A.dateEmailSend, 120) = #dateEmailSend
AND B.[Company] = #ola_company
AND B.[Object Identified As] = #obj_identified_as
AND B.[Product Involved] = #product_involved
AND B.Region = #region
AND B.[Customer] = #ola_customer
AND A.CounterVal != #counter;
SELECT #result;

Answer 2

The # values are not yet defined for the first cursor listed.

Answer 3

You need an inner cursor per row of the SELECT statement as well as an outer cursor for the outer SELECT statement.