Using stored procedure to retrieve data from database - sql-server

Question

I'm using a stored procedure to pull a list of items from a database however I keep getting this error:
Procedure or function 'requisition_sp_getItemNum' expects parameter '#reqNumber', which was not supplied.
I have use the hiddenfor in order to supply the reqNumber but that throws the same error message
Stored procedure:
ALTER PROCEDURE [dbo].[requisition_sp_getItemNum]
#reqNumber VARCHAR(50)
AS
BEGIN
SELECT
a.ITEMNMBR, a.ITEMDESC, ab.employee_id,
ab.department, ab.employee_name, quantity_requested,
b.expense_acc, c.ACTDESCR + '/' + c.ACTNUMBR_1 + '-' + c.ACTNUMBR_2 [Expense_Acc],
b.unit_of_measure
FROM
[TWCL].[dbo].IV00101 a
INNER JOIN
RequisitionItem b ON a.ITEMNMBR = b.item_no
INNER JOIN
Requisition ab ON ab.Req_No = b.Req_No
INNER JOIN
[TWCL].dbo.GL00100 c ON b.expense_acc = c.ACTINDX
WHERE
b.Req_No = #reqNumber AND ab.status = -1
END
View
#using (Html.BeginForm())
{
#Html.AntiForgeryToken()
<hr/>
<table id="data">
<thead>
<tr>
<th></th>
<th >#Html.CheckBox("TheOneCheckBoxToRuleThemAll")Select All</th>
<th class="col-lg-1 ">Date</th>
<th class="col-lg-1 ">Requisition Number</th>
<th class="col-lg-1 ">Expense Account</th>
<th class="col-lg-1">Requestor</th>
<th class="col-lg-1">Department</th>
<th class="col-lg-1">LoggedinAs</th>
<th class="col-lg-1 ">Item Number</th>
<th class="col-lg-1 ">Description</th>
<th class="col-sm-1">Quantity</th>
<th class="col-sm-1 ">UOM</th>
</tr>
<tbody>
#for (int i = 0; i < Model.Count; i++)
{
foreach (var item in Model[i].items)
{
#Html.HiddenFor(m => m[i].reqNumber)
<tr>
<td>#Html.HiddenFor(m => m[i].reqNumber)</td>
<td>#Html.CheckBoxFor(m => m[i].postTrnx, new { #class = "checkGroup1" })</td>
<td class="col-lg-1 tabledata" >#Html.DisplayFor(m => m[i].reqDate)</td>
<td class="col-lg-1 tabledata" >#Html.DisplayFor(m => m[i].reqNumber)</td>
<td class="col-lg-1 tabledata">#item.expense_account.account_desc</td>
<td class="col-lg-1 tabledata">#item.employeeDetails.employeeNum</td>
<td class="col-lg-1 tabledata">#item.employeeDetails.department</td>
<td class="col-lg-1 tabledata">#item.employeeDetails.LoggedInUserName</td>
<td class="col-lg-1 tabledata">#item.itemNumber</td>
<td class="col-lg-1 tabledata">#item.description</td>
<td class="col-sm-1 tabledata">#item.quantity</td>
<td class="col-sm-1 tabledata">#item.selecteduomtext </td>
#*<td>#Html.ActionLink("Edit", "Edit", new { id = #item.lineNum, name = Model[i].reqNumber })</td>*#
</tr>
}
}
</tbody>
</table>
Model
public List<Item> getRequestItemByRquisition(string reqNumber)
{
List<Item> items = new List<Item>();
SqlConnection TWCLOPConnect = new SqlConnection(connectionString.ToString());
SqlCommand itemscommand = new SqlCommand();
SqlDataReader itemRdr;
itemscommand.CommandText = "requisition_sp_getItemNum ";
itemscommand.CommandType = CommandType.StoredProcedure;
itemscommand.Connection = TWCLOPConnect;
itemscommand.Parameters.Add("#reqNumber", SqlDbType.VarChar).Value = reqNumber;
try
{
TWCLOPConnect.Open();
itemRdr = itemscommand.ExecuteReader();
while (itemRdr.Read())
{
Item item = new Item();
item.itemNumber = itemRdr.GetString(0);
item.description = itemRdr.GetString(1);
item.employeeDetails.employeeNum = Convert.ToInt32(itemRdr.GetString(2));
item.employeeDetails.department = itemRdr.GetString(3);
item.employeeDetails.LoggedInUserName = itemRdr.GetString(4);
item.quantity = Convert.ToDouble(itemRdr[5]);
item.expense_account.index = itemRdr.GetInt32(6);
item.expense_account.account_desc = itemRdr.GetString(7);
item.selecteduomtext = itemRdr.GetString(8);
items.Add(item);
}
itemRdr.Close();
}
catch (Exception ex)
{
throw ex;
}
finally
{
TWCLOPConnect.Close();
}
return items;
}

Answer 1

You variable from stored procedure #reqNumber:
#reqNumber varchar (50)
and the variable #Req_No you added here
itemscommand.Parameters.Add("#Req_No", SqlDbType.VarChar).Value = Req_No;
must match.
Change this:
itemscommand.Parameters.Add("#reqNumber", SqlDbType.VarChar).Value = reqNumber;
to this:
itemscommand.Parameters.Add("#reqNumber", reqNumber);
New way: can you change your code to this
SqlConnection TWCLOPConnect = new SqlConnection(connectionString.ToString());
SqlCommand itemscommand = new SqlCommand("requisition_sp_getItemNum", TWCLOPConnect);
itemscommand.CommandType = CommandType.StoredProcedure;
itemscommand.Parameters.Add("#reqNumber", reqNumber);
SqlDataReader itemRdr;
try
{
}