TRY CATCH inside of TRANSACTION - sql-server

Question

I have written a procedure which selects columns from a table and inserts into another table.
I put a try/catch block inside the transaction. If I got any error inbetween then my code will insert error details into error log table and roll back the transaction.
IF OBJECT_ID('usp_Stage_raw_ADDM_ALL') IS NOT NULL
BEGIN
DROP PROCEDURE [dbo].[usp_Stage_raw_ADDM_ALL]
PRINT 'Procedure usp_Stage_raw_ADDM_ALL Dropped'
END
GO
CREATE PROC [dbo].[usp_Stage_raw_ADDM_ALL] AS
SET ANSI_NULLS ON
GO
SET NOCOUNT ON
GO
SET XACT_ABORT ON
GO
SET QUOTED_IDENTIFIER ON
GO
BEGIN TRANSACTION;
BEGIN TRY
DELETE FROM tbl_Staging_Devices WHERE [Source] LIKE 'ADDM%'
INSERT INTO tbl_Staging_Devices
(
Device_Name,
Serial_Number,
Company,
)
SELECT [Computer Name] AS Device_Name,
Serial_Number =
CASE
WHEN [Serial Number]='None' THEN NULL
ELSE [Serial Number]
END,
Company = 'Car'
FROM (
Select * From raw_ADDM_PCL
UNION ALL
Select * From raw_ADDM_CCL) a
END TRY
BEGIN CATCH
IF ##TRANCOUNT > 0
EXEC USP_InsertErrorDetails
ROLLBACK TRANSACTION;
END CATCH
IF ##TRANCOUNT > 0
COMMIT TRANSACTION;
IF OBJECT_ID('usp_Stage_raw_ADDM_ALL') IS NOT NULL
BEGIN
PRINT 'Procedure usp_Stage_raw_ADDM_ALL Created'
END
GO

Answer 1

All that the sp you created does is
SET ANSI_NULLS ON
Your code is divided in batches using GO, and your SP's code is only that one:
CREATE PROC [dbo].[usp_Stage_raw_ADDM_ALL] AS
SET ANSI_NULLS ON
GO
You cannot insert "go" inside your procedure, "go" means the batch is finished, the code is submitted to server, and now you submit the CREATE PROC code with only 1 statement

Answer 2

Here is the solution.
CREATE PROC [dbo].[usp_Stage_raw_ADDM_ALL]
AS
BEGIN
SET ANSI_NULLS ON
SET NOCOUNT ON
SET QUOTED_IDENTIFIER ON
BEGIN TRY
BEGIN TRANSACTION
DELETE FROM tbl_Staging_Devices WHERE [Device_Name] LIKE 'ADDM%'
INSERT INTO tbl_Staging_Devices
(
Device_Name,
Serial_Number,
Company
)
SELECT [Computer Name] AS Device_Name,
Serial_Number =
CASE
WHEN [Serial Number]='None' THEN NULL
ELSE [Serial Number]
END,
Company = 'Car'
FROM (
Select * From raw_ADDM_PCL
UNION ALL
Select * From raw_ADDM_CCL) a
COMMIT TRANSACTION;
END TRY
BEGIN CATCH
IF ##TRANCOUNT > 0
EXEC USP_InsertErrorDetails
ROLLBACK TRANSACTION;
END CATCH
END