SQL Query - Grouping/Aggregating Across multiple Tables - sql-server

Question

select D.[Date], E.emp_name, E.emp_jde, count(C.[agent_no]) calls, count(S.[EMPJDENUM]) sales
from
(select cast([start_date] as date) dte, [agent_no]
from call_table
where [skill_name] like '%5700 sales l%'
and [Agent_Time] != '0'
) C
full outer join
(select [AC#DTE_dt], [EMPJDENUM]
from sales_table
where [ICGCD2] in ('LAWN', 'HORT')
and [CHANNEL]= 'INQ'
and [ITMQTY]>3
) S on c.dte=s.[AC#DTE_dt]
right join
(select [Date]
from Date_table
) D on c.dte=d.[Date] or s.[AC#DTE_dt]=d.[Date]
right join
(select [emp_name], [emp_jde], [agent_no]
from Employee_table
) E on C.[agent_no]=E.agent_no and S.[EMPJDENUM]=E.emp_jde
group by D.[Date], E.emp_name, E.emp_jde
Date Tables -
Note: Not all dates will have both calls and sales.
Additional Tables -
What needs to be accomplished -
1) Join and Aggregate calls and sales by Employee by joining the calls table (on agent_no) and sales (on JDE) table
2) Since not all dates will include both calls and sales - use the date dimension table to ensure all dates are represented
The desired result would look like this -
The query I wrote executes - it takes so long I just end up canceling the query.
Any help would be appreciated.

Answer 1

Without seeing the query plan, it is a little tricky, but here are a couple of suggestions that might improve the performance:
remove the leading wildcard in where [skill_name] like '5700 sales l%'
put the group by into the subqueries
I have an example here that implements both of those. (Note that I did some reformatting just to try to understand what your query was doing.)
select D.[Date], E.emp_name, E.emp_jde, C.Calls, S.Sales
from Date_table As D
Left Join (
select cast([start_date] as date) As CallDate, [agent_no], Count(*) As Calls
from call_table
where [skill_name] like '5700 sales l%'
and [Agent_Time] != '0'
Group By Cast([start_date] As date), [agent_no]) As C On D.[Date] = C.CallDate
Left Join (
select [AC#DTE_dt] As SaleDate, [EMPJDENUM], Count(*) As Sales
from sales_table
where [ICGCD2] in ('LAWN', 'HORT')
and [CHANNEL]= 'INQ'
and [ITMQTY]>3
Group By [AC#DTE_dt], [EMPJDENUM]) As S on D.[Date] = s.SaleDate
right join Employee_table As E
on C.[agent_no]=E.agent_no
and S.[EMPJDENUM]=E.emp_jde;
Edit
In order to get a row for each possible combination of date and employee, you will need a cross join of the date table and the employee table.
select D.[Date], E.emp_name, E.emp_jde, C.Calls, S.Sales
from Date_table As D,
Employee_table as E
Left Join (
select cast([start_date] as date) As CallDate, [agent_no], Count(*) As Calls
from call_table
where [skill_name] like '5700 sales l%'
and [Agent_Time] != '0'
Group By Cast([start_date] As date), [agent_no]) As C
On D.[Date] = C.CallDate
And E.agent_no = C.agent_no
Left Join (
select [AC#DTE_dt] As SaleDate, [EMPJDENUM], Count(*) As Sales
from sales_table
where [ICGCD2] in ('LAWN', 'HORT')
and [CHANNEL]= 'INQ'
and [ITMQTY]>3
Group By [AC#DTE_dt], [EMPJDENUM]) As S
on D.[Date] = s.SaleDate
and E.emp_jde = S.[EMPJDENUM];