strcmp does not stop when typing 'yes' command [closed] - c

Question

Closed. This question needs details or clarity. It is not currently accepting answers.
Want to improve this question? Add details and clarify the problem by editing this post.
Closed 6 years ago.
Improve this question
I've made this joke program with string compare, but when I type "yes" it also types what I have for the else statement. It doesn't do this when I type "no", and responds predictably if I type something other than "yes" or "no".
#include<stdio.h>
#include<string.h>
int main ()
{
char ansr[50];
printf("Are you a cop?");
scanf("%s", &ansr);
if (strcmp(ansr, "yes") == 0)
{
printf("Then get outta here buddy!");
}
if (strcmp(ansr, "no") == 0)
{
printf("Then you can learn the secret handshake!");
}
else
printf("\nDude! Yes or no question! Are you a cop?!\n");
}

Answer 1

There are a few things to notice. First, you never use scanf to read anything into ansr before using it, which leads to undefined behavior. Second, as others have said, your if/else statements are not congruent. Third, you need a while loop to ask the question again if the answer is invalid. You could rearrange it like so:
int main ()
{
char ansr[50];
printf("Are you a cop?\n");
scanf("%49s", ansr);
while (strcmp(ansr, "yes") && strcmp(ansr, "no"))
{
printf("\nDude! Yes or no question! Are you a cop?!\n");
scanf("%49s", ansr);
}
if (strcmp(ansr, "yes") == 0)
{
printf("Then get outta here buddy!\n");
}
else
{
printf("Then you can learn the secret handshake!\n");
}
return 0;
}

Answer 2

ansrstays uninitialised, before touching it via strcmp(), the latter invokes the infamous Undefined Behavior, anything can happen.

Answer 3

Your code has a if block and an if else block. So it compares ansr twice, change it to if else if block, it will only check once.
#include<stdio.h>
#include<string.h>
int main ()
{
char ansr[50];
printf("Are you a cop?");
//should take input here
if (strcmp(ansr, "yes") == 0)
{
printf("Then get outta here buddy!");
}
else if (strcmp(ansr, "no") == 0)
{
printf("Then you can learn the secret handshake!");
}
else printf("\nDude! Yes or no question! Are you a cop?!\n");
return 0;
}
Edit : Removed some words as suggested. Sorry, included them from op code.