Strtok-ing a file into an array in C - c

Question

Somehow I can't get this to display correctly, no matter how i rearrange things. I should be able to accomplish this without using malloc, by the way.
void ArrayFormatter(FILE* cipherKey)
{
char line[1000];
char* fileWords[5000];
static int wordCount = 0;
//This loop stores each word into its corresponding position in an array
while(fgets(line, 1000, cipherKey) != NULL)
{
fileWords[wordCount] = strtok(line, " ");
fprintf(stdout, "_%s_", fileWords[wordCount]); //test
wordCount++;
for(i = 0; i < sizeof(line) - 1; i++)
{
fileWords[wordCount] = strtok(NULL, " ");
if(fileWords[wordCount] == NULL)
break;
fprintf(stdout, "_%s_", fileWords[wordCount]); //test
wordCount++;
}
}
fprintf(stdout, "\n\n\n");
//Issue here is that it's not displaying the same values that it is above
//This loop displays current strings, in order, in array
for(i = 0; i < wordCount; i++)
{
fprintf(stdout, "_%s_", fileWords[i]);
}

Answer 1

I should be able to accomplish this without using malloc, by the way.
You can do it without malloc, but you will need a large stack, and to change the following line:
char* fileWords[5000];
To:
char fileWords[5000][anticipated largest string length+1];
And, create a char *buf={0}; (or similar) to use with strtok
As mentioned in the comments, there are other problems in your code.
If you should decide to use malloc...
Three Four suggestions to make initial debugging easier:
0) Allocate memory for each char* fileWords[5000]; before using, free after.
1) make sure the delimiter contains the right values.
2) check the return coming out of strtok.
3) move the print loop out of the read/parse loop.
char *buf={0};
int wordCount = 0;
while(fgets(line, 1000, cipherKey) != NULL)
{
buf = strtok(line, " ");//are you certain this is the right delimiter list?
while(buf)//check the return of strtok before using
{
fileWords[wordCount] = malloc(strlen(buf)+1);
strcpy(fileWords[wordCount], buf);//store intermediate results
wordCount++;
buf = strtok(line, NULL);//get new token from string
}
}
for(i = 0; i < wordCount; i++)
{
fprintf(stdout, "_%s_", fileWords[i]); //test
free(fileWords[i]);
}

Answer 2

Here's the corrected code. It has a few more safety checks for array overflow and blank lines. On the odd chance that no malloc was a requirement, I've added a "non malloc" version of strdup(3) [please pardon the gratuitous style cleanup]:
#define LINESIZE 1000
#define WORDMAX 5000
#define BUFMAX ((WORDMAX + 1) * LINESIZE)
char strarea[BUFMAX];
char *strptr;
// xstrdup -- "no malloc" version of strdup(3)
char *
xstrdup(const char *src)
{
int len = strlen(src) + 1;
char *dst;
if (strptr == NULL)
strptr = strarea;
dst = strptr;
strptr += len;
memcpy(dst,src,len);
return dst;
}
void
ArrayFormatter(FILE *cipherKey)
{
char line[LINESIZE];
char *bp;
char *cp;
char *fileWords[WORDMAX];
int wordCount = 0;
// This loop stores each word into its corresponding position in an array
while (fgets(line, sizeof(line), cipherKey) != NULL) {
bp = line;
for (; wordCount < WORDMAX; ++wordCount) {
cp = strtok(bp, " ");
bp = NULL;
if (cp == NULL)
break;
// standard way or if no malloc is hard requirement, use xstrdup
#if 1
fileWords[wordCount] = strdup(cp);
#else
fileWords[wordCount] = xstrdup(cp);
#endif
fprintf(stdout, "_%s_", fileWords[wordCount]); // test
}
if (wordCount >= WORDMAX)
break;
}
fprintf(stdout, "\n\n\n");
// Issue here is that it's not displaying the same values that it is above
// This loop displays current strings, in order, in array
for (i = 0; i < wordCount; i++) {
fprintf(stdout, "_%s_", fileWords[i]);
}
#if 0
for (i = 0; i < wordCount; i++) {
free(fileWords[i]);
}
#endif
}

Answer 3

the following code
cleanly compiles
performs the desired functions
does not use malloc() nor calloc() nor realloc()
is limited to words with a max length of 49 characters
is limited to 5000 words
and now the code
#include <stdio.h>
#include <string.h>
#define MAX_LINE_LEN (1000)
#define MAX_WORDS (5000)
#define MAX_WORD_LEN (50)
void ArrayFormatter(FILE* cipherKey)
{
char line[MAX_LINE_LEN];
size_t wordCount = 0;
static char fileWords[ MAX_WORDS ][ MAX_WORD_LEN ];
//This loop stores each word into its corresponding position in an array
while(wordCount < MAX_WORDS && fgets(line, MAX_LINE_LEN, cipherKey) )
{
char * token = strtok(line, " ");
while( token )
{
strncpy( fileWords[wordCount], token, MAX_WORD_LEN);
fprintf(stdout, "_%s_", fileWords[wordCount]); // test
wordCount++;
token = strtok(NULL, " ");
}
}
fprintf(stdout, "\n\n\n");
//This loop displays current strings, in order, in array
for(size_t i = 0; i < wordCount; i++)
{
fprintf(stdout, "_%s_", fileWords[i]);
}
} // end function: ArrayFormatter