Link between controller and factory - angularjs

Question

.controller('LoginConnect', ['$scope', 'connecting',
function($scope, connecting){
$scope.user = {};
$scope.connect = function(){
connecting();
};
}
])
.factory("connecting", ["$scope", "$q", "$http", function ($scope,$q, $http){ var deferred = $q.defer();
$http({
method: 'POST',
url: "http://api.tiime-ae.fr/0.1/request/login.php",
headers: {'Content-Type': 'application/x-www-form-urlencoded'},
transformRequest: function(obj) {
var str = [];
for(var p in obj)
str.push(encodeURIComponent(p) + "=" + encodeURIComponent(obj[p]));
return str.join("&");
},
data: {login: $scope.user.login, password: $scope.user.password}
})
.success(function(result){
deferred.resolve(result);
var promise = deferred.promise;
promise.then(function(result){
jsonTab = angular.fromJson(result);
$scope.result = result["data"];
$scope.user.token = result["data"];
});
})
}])
;
and here the HTML:
<!-- User Connection -->
<form name="userConnect" ng-submit="connect()" novalidate ng-controller="LoginConnect">
<label>
Enter your name:
<input type="text"
name="myEmail"
ng-model="user.login"
/>
</label>
<label>
Enter your Password:
<input type="password"
name="password"
ng-model="user.password"
/>
</label>
<input type="submit" value="Connection">
<p>resultat : {{result}}</p>
<p ng-model="user.token">
token : {{mytoken}}
</p>
<p ng-model="user.datab">
datas : {{datab}}
</p>
<br><br><br>
</form>
Hi, I am new in Angular JS, could you help me pls to fixe this. I have the following error :$scopeProvider <- $scope <- connecting
I think this error is due to the link betwwen controller and factory

Answer 1

Your service needs to return something.
instead try:
.factory("connecting", ["$scope", "$q", "$http", function connect($scope,$q, $http){
return function() {
//your method
};
}])

Answer 2

Here is the code Example of linking controller and factory similar to yours. You simply return the something from the factory.
.controller('LoginConnect', ['$scope', 'connecting',
function($scope, connecting) {
$scope.user = {};
$scope.connect = function() {
connecting.login($scope.signupData.username, $scope.signupData.password).success(function(data) {
//
$sessionStorage.userid = data.UserId;
$sessionStorage.token = data.access_token;
if (data.UserId != "") {
$state.go('app.editProfile');
}
})
.error(function(data, status, headers, config) {
console.log("http error", data);
});
};
}
])
.factory('connecting', ["$scope", "$q", "$http", function ($scope,$q, $http){
var urlBase = 'http://apple.com:7071';
//Login
return {
login: function(loginusername, loginpassword) {
return $http({
method: 'POST',
url: urlBase + '/Login',
data: {
username: loginusername,
password: loginpassword,
grant_type: 'password'
},
transformRequest: function(obj) {
var str = [];
for (var p in obj)
str.push(encodeURIComponent(p) + "=" + encodeURIComponent(obj[p]));
return str.join("&");
}
})
}
}
}])

Answer 3

Fatcory needs to return an Object.
.factory("connecting", ["$scope", "$q", "$http", function ($scope,$q, $http){
var ConnectingFactory = {};
ConnectingFactory.login = function(){
var deferred = $q.defer();
$http({
method: 'POST',
url: "http://api.tiime-ae.fr/0.1/request/login.php",
headers: {'Content-Type': 'application/x-www-form-urlencoded'},
transformRequest: function(obj) {
var str = [];
for(var p in obj)
str.push(encodeURIComponent(p) + "=" + encodeURIComponent(obj[p]));
return str.join("&");
},
data: {login: $scope.user.login, password: $scope.user.password}
})
.success(function(result){
deferred.resolve(result);
var promise = deferred.promise;
promise.then(function(result){
jsonTab = angular.fromJson(result);
$scope.result = result["data"];
$scope.user.token = result["data"];
});
})
};
return ConnectingFactory;
}]);