How to debug parts of my C mathematical program? [closed] - c

Question

Closed. This question needs debugging details. It is not currently accepting answers.
Edit the question to include desired behavior, a specific problem or error, and the shortest code necessary to reproduce the problem. This will help others answer the question.
Closed 7 years ago.
Improve this question
I'm stuck on this code and have searched the web for an answer and I didn't find anything.
The code get compiled but in options 1 and 2 the code doesn't get the real answer, I don't know if the problem is about the all thing like double and float or because of a stupid mistake.
#include <stdlib.h>
#include <stdio.h>
#include <math.h>
#define PI 3.141
void twoPoints ();
void hypotenuseInTriangular ();
void areaAndScopeInCircle (float radius);
void areaOfSquare ();
void areaOfRectangle ();
int main()
{
int num=0 ;
float radius=0;
double ans1= 0,x1=0,x2=0,y1=0,y2=0;
printf("hello friend, please enter one of the options: \n");
printf("press 1 to calculate length between two points\n");
printf("press 2 to calculate hypotenuse in right tringle \n");
printf("press 3 to calculate area and scope in circle \n");
printf("press 4 to calculate area of square \n");
printf("press 5 to calculate area of rectangle \n");
printf("press 6 to exit from the code \n");
scanf("%d",&num);
switch (num)
{
case 1:
twoPoints(x1,x2,y1,y2);
break;
case 2:
hypotenuseInTriangular();
break;
case 3:
areaAndScopeInCircle (radius);
break;
case 4:
areaOfSquare();
break;
case 5:
areaOfRectangle();
break;
case 6:
printf("bye!\n");
break;
default:
printf("not good number \n");
break;
}
system("PAUSE");
return (0);
}
/**
this funcion calculate the length between two points.
input: two points (x1,y1) (x2,y2).
output: the length between them.
*/
void twoPoints (double x1,double x2,double y1,double y2)
{
double ans1=0,calculate1=0,calculate2=0;
printf("enter two integer points like this: x1 y1 x2 y2\n");
scanf("%1f %1f %1f %1f",&x1,&y1,&x2,&y2);
calculate1 = (x1 - x2) * (x1 - x2);
calculate2 = (y1 - y2) * (y1 - y2);
calculate1 += calculate2;
calculate2 = sqrt(calculate1);
printf("the length between your two points is: %f\n",calculate2);
}
/**
this funcion calculate the hypotenuse in right tringle using two ribs.
input: two integer numbers of the tringle.
output: the hypotenuse length.
*/
void hypotenuseInTriangular (double sideA,double sideB)
{
double sideC=0.0,sum=0.0;
printf("enter two ribs from the triangle: \n");
scanf("%1f %1f",&sideA,&sideB);
sum = (sideA * sideA + sideB * sideB);
sideC = sqrt(sum);
printf("your hyptenuse is %f \n",sideC);
}
/**
this funcion calculate area and scope using radius.
input: a radius number.
output: the area and the scope of this circle.
*/
void areaAndScopeInCircle (float radius)
{
float area = 0,scope =0;
printf("enter radius: \n");
scanf("%f",&radius);
area = PI * radius * radius;
scope = PI * radius * 2;
printf("the area of your circle is: %.1f\n",area);
printf("the scope of your circle is: %.1f\n",scope);
}
/**
this funcion calculate area of square using two ribs.
input: two integer numbers.
output: the area of the square.
*/
void areaOfSquare (int rib)
{
printf("enter one of the square rib: \n");
scanf("%d",&rib);
printf("the area of your square is: %d\n",(rib*rib));
}
/**
this funcion calculate area of rectangle using two ribs.
input: two integer numbers.
output: the area of the rectangle.
*/
void areaOfRectangle (int length,int width)
{
printf("enter length and than width\n");
scanf("%d %d",&length,&width);
printf("the area of your rectangle is: %d\n",(length*width));
}

Answer 1

In your function twoPoints() you have used incorrect format specifiers with
scanf("%1f %1f %1f %1f",&x1,&y1,&x2,&y2);
these could be typos or copying errors because a 1 (numeral one) looks a lot like an l (letter ell). The line should be
scanf("%lf %lf %lf %lf",&x1,&y1,&x2,&y2);
and after making this correction the function works.
Note that the lower-case L in the format specifier stands for long. In scanf() and friends, for a float variable input you use %f and for a double variable you use %lf. However in printf() and friends, you use %f for double and for float because any float argument is automatically promoted to double.

Answer 2

In your function twoPoints -
scanf("%1f %1f %1f %1f",&x1,&y1,&x2,&y2);
instead of above try this -
scanf("%lf %lf %lf %lf",&x1,&y1,&x2,&y2); // %lf not %1f
And similar in other funcitons .
Note - Also , your function when defined expect arguments , but when you call them in main , you don't pass them any arguments. Such as this -
hypotenuseInTriangular(); // expects 2 double arguments
Call them with correct arguments , and also declare prototypes correctly .