How to compute min, max, average from an array? [closed] - c

Question

Closed. This question needs debugging details. It is not currently accepting answers.
Edit the question to include desired behavior, a specific problem or error, and the shortest code necessary to reproduce the problem. This will help others answer the question.
Closed 7 years ago.
Improve this question
This is the original question asked:
1.The user will input up to 20 numbers, and these numbers will be stored in an array. Write functions will take as input and return the minimum, the maximum, and the average. Use the functions to compute the min, max, and average of the array.
Here is what I have but I dont know why it is not working, any suggestions?
#include <stdio.h>
void arrmin(int a[],int num_elements);
void arrmax(int a[], int num_elements);
void arraver(int a[],int num_elements);
int main(void)
{
int a[20],c,min,max;
float avg;
printf("Enter 20 numbers of elements in array\n");
for (c = 0; c < 20; c++)
scanf("%d", &a[c]);
min=max=a[0];
arrmax(a,a[20]);
printf("Maximum value is %d\n", max);
arrmin(a,a[20]);
printf("Minimum value is %d\n", a[20]);
arraver(a,a[20]);
printf("Average value is %f\n", a[20]);
getch();
}
void arrmax(int a[], int num_elements)
{
int i, max;
for (i=0; i<num_elements; i++)
{
if (a[i]>max)
{
max=a[i];
}
}
return(max);
}
void arrmin(int a[], int num_elements)
{
int i, min;
for (i=0; i<num_elements; i++)
{
if (a[i]<min)
{
min=a[i];
}
}
return(min);
}
void arraver(int a[], int num_elements)
{ int sum,i;
float avg;
sum=0;
avg=0;
for (i=0; i<num_elements;i++)
{
sum=sum+a[i];
avg=(float)sum/(i+1);
}
return(avg);
}

Answer 1

Your logic looks pretty good, but there are a few small issues. The fixed code is given at the bottom of the answer.
Issues:
Pass 20 to the second argument of arrmax, arrmin, and arraver
arrmax(a,a[20]); becomes arrmax(a, 20).
You probably want the arr... functions to return int or float rather than void
void arrmax(...) becomes int arrmax(...)
void arraver(...) becomes float arraver(...)
Be sure to actually use the values returned by your functions
arrmax(a,20); becomes max = arrmax(a, 20);, etc.
Be sure to initialize max and min variables in their respective functions.
max = a[0];
min = a[0];
now we can iterate from 1 to 19 instead of 0 to 19
The min and aver printers should print min and aver rather than a[20].
printf("Min is %d\n", a[20]); becomes printf("Min is %d\n", min);
printf("Average is %f\n", a[20]); becomes printf("Average is %f\n", aver);
Fixed code:
#include <stdio.h>
int arrmin(int a[],int num_elements);
int arrmax(int a[], int num_elements);
float arraver(int a[],int num_elements);
int main(void)
{
int a[20],c,min,max;
float avg;
printf("Enter 20 numbers of elements in array\n");
for (c = 0; c < 20; c++)
scanf("%d", &a[c]);
max = arrmax(a,20);
printf("Maximum value is %d\n", max);
min = arrmin(a,20);
printf("Minimum value is %d\n", min);
avg = arraver(a,20);
printf("Average value is %f\n", avg);
getch();
}
int arrmax(int a[], int num_elements)
{
int i, max;
max = a[0];
for (i=1; i<num_elements; i++)
{
if (a[i]>max)
{
max=a[i];
}
}
return(max);
}
int arrmin(int a[], int num_elements)
{
int i, min;
min = a[0];
for (i=1; i<num_elements; i++)
{
if (a[i]<min)
{
min=a[i];
}
}
return(min);
}
float arraver(int a[], int num_elements)
{
int sum,i;
float avg;
sum=0;
avg=0;
for (i=0; i<num_elements;i++)
{
sum=sum+a[i];
avg=(float)sum/(i+1);
}
return(avg);
}