C program using while- weird counter error if counter>8 - c

Question

This program finds out the max and min of 10 numbers using the while loop.
If i set the number of inputs from the users to 8 or less it works, if i set it to >8 (say 10) it produces an error (program stops responding) when the user tries to enter the 9th number.
Any ideas ? Thanks.
#include <stdio.h>
#include <stdlib.h>
main()
{
int x, max, min;
int i = 0;
printf("Introduceti un intreg\n"); // Enter a number
scanf("%d", &x);
max = 0;
min = x; // Set min to number
do
{
i++;
if (i > 10) break;
printf("Introduceti un intreg\n"); // Enter a number
scanf("%d", &x);
if (x > max)
max = x;
if (x < min)
min = x;
}
while (max > min);
printf("max este %d\n", max);
printf("min este %d\n", min);
}

Answer 1

I do not see why using a do-while loop when you know how many iterations you want to perform. You should use a for loop instead (do-while works too, but for loop is intended to be used in situations like these).
Moreover, you had an else when checking for min, which was not needed, since you want to check if every number given from the user is min or max.
Notice that the for loop starts from 1, since we read one number outside the loop.
#include <stdio.h>
#include <stdlib.h>
int main() {
int i, x, max, min;
printf("Introduceti un intreg\n"); // Enter a number
scanf("%d", &x);
max = x;
min = x; // Set min to number
for(i = 1; i < 9; ++i) {
printf("Introduceti un intreg\n"); // Enter a number
scanf("%d", &x);
if(x > max) {
max = x;
}
if(x < min) { // here you had an else, but it was wrong
min = x;
}
}
printf("max este %d\n", max);
printf("min este %d\n", min);
return 0;
}
About the return value of scanf() mentioned in one comment, you can always check the ref.
If you need to that with a while loop, then you should do this:
#include <stdio.h>
#include <stdlib.h>
int main() {
int i = 0, x, max, min;
printf("Introduceti un intreg\n"); // Enter a number
scanf("%d", &x);
max = x;
min = x; // Set min to number
while(i < 9) {
printf("Introduceti un intreg\n"); // Enter a number
scanf("%d", &x);
if(x > max) {
max = x;
}
if(x < min) { // here you had an else, but it was wrong
min = x;
}
i++;
}
printf("max este %d\n", max);
printf("min este %d\n", min);
return 0;
}
Here the counter i is increased at the end of every loop and the condition to stop is i < 9, since we have already read a number outside the loop.

Answer 2

Do not write else if for min, because you need to check both max and min at the same time.Also for 10 numbers it should be i>=10.And you can make while to 1, because it will break at i=10 anyhow.Here is your working code.Also initially max should be set to x.
#include <stdio.h>
#include <stdlib.h>
main()
{
int x, max, min;
int i = 0;
printf("Introduceti un intreg\n"); // Enter a number
scanf("%d", &x);
max = x;
min = x; // Set min to number
do
{
i++;
if (i >= 10) break;
printf("Introduceti un intreg\n"); // Enter a number
scanf("%d", &x);
if (x > max)
max = x;
if (x < min)
min = x;
} while (1);
printf("max este %d\n", max);
printf("min este %d\n", min);
}