Updating ObservableCollection not Updating View on Command - wpf

Question

I have a ListView which binds to an ObservableCollection. When my button's command updates the item in the collection, the View is not updated. I am also using Fody to implement INotifyPropertyChanged throughout.
View
<ListView ItemsSource="{Binding Path=DatabaseInfos}" VerticalAlignment="Stretch" Margin="10">
<ListView.View>
<GridView>
<GridViewColumn Header="Current Version">
<GridViewColumn.CellTemplate>
<DataTemplate>
<TextBox Text="{Binding CurrentVerion}" />
</DataTemplate>
</GridViewColumn.CellTemplate>
</GridViewColumn>
<GridViewColumn Header="">
<GridViewColumn.CellTemplate>
<DataTemplate>
<Button Content="Test"
Command="{Binding DataContext.CmdButtonClicked, RelativeSource={RelativeSource AncestorType={x:Type ListView}}}"
CommandParameter="{Binding}" />
</DataTemplate>
</GridViewColumn.CellTemplate>
</GridViewColumn>
</GridView>
</ListView.View>
</ListView>
ViewModel
public interface IDatabaseViewModel
{
ObservableCollection<DatabaseInfo> DatabaseInfos { get; set; }
}
[Injectable(InstanceScope.Singleton)]
[ImplementPropertyChanged]
public class DatabaseViewModel : IDatabaseViewModel
{
private RelayCommand _buttonClicked;
private ILogger _logger;
public DatabaseViewModel()
{
_logger = ServiceLocator.Default.GetInstance<ILoggerFactory>().GetLogger(this);
DatabaseInfos = new ObservableCollection<DatabaseInfo>();
var path = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location) + #"\CampusInstallerSettings.xml";
if (File.Exists(path))
{
try
{
var settings = SettingsReader.LoadSettings(path);
foreach (var db in settings.DatabaseSettings.DatabaseSettings)
{
var dbInfo = new DatabaseInfo();
if (db.ActionCode.Value == "Upgrade")
dbInfo.Action = Action.Upgrade;
else if (db.ActionCode.Value == "None")
dbInfo.Action = Action.None;
else if (db.ActionCode.Value == "Remove")
dbInfo.Action = Action.Uninstall;
else
dbInfo.Action = Action.None;
dbInfo.SqlServer = db.SQLServer.Value;
dbInfo.Database = db.Database.Value;
if (db.DBType.Value == "CampusVue")
dbInfo.DatabaseType = DatabaseType.CampusVue;
if (db.Connection.Value == "Integrated")
dbInfo.IntegratedSecurity = true;
DatabaseInfos.Add(dbInfo);
}
}
catch (Exception ex)
{
_logger.Error(ex);
throw new Exception("Could not load settings file. " + Environment.NewLine + ex.Message);
}
}
else
{
throw new Exception("Could not find settings file # " + path);
}
}
public ICommand CmdButtonClicked
{
get { return _buttonClicked ?? (_buttonClicked = new RelayCommand(ButtonClicked)); }
}
public ObservableCollection<DatabaseInfo> DatabaseInfos { get; set; }
private void ButtonClicked(object o)
{
_logger.Info(#"Test button clicked.");
var dbInfo = o as IDatabaseInfo;
if (dbInfo != null && !dbInfo.TestConnection())
{
MessageBox.Show("Couldn't connect", "Error", MessageBoxButton.OK, MessageBoxImage.Error);
}
}
}
Model
public interface IDatabaseInfo
{
Action Action { get; set; }
string SqlServer { get; set; }
string Database { get; set; }
DatabaseType DatabaseType { get; set; }
bool IntegratedSecurity { get; set; }
string Username { get; set; }
string Password { get; set; }
string CurrentVersion { get; set; }
bool TestConnection();
}
[ImplementPropertyChanged]
public class DatabaseInfo : IDatabaseInfo
{
public Action Action { get; set; }
public string SqlServer { get; set; }
public string Database { get; set; }
public DatabaseType DatabaseType { get; set; }
public bool IntegratedSecurity { get; set; }
public string Username { get; set; }
public string Password { get; set; }
public string CurrentVersion { get; set; }
public bool TestConnection()
{
if (DbHelper.TestConnection(SqlServer, 1433, Database, Username, Password))
{
CurrentVersion = DbHelper.GetDbVersion(SqlServer, 1433, Database, Username, Password);
return true;
}
return false;
}
}

Answer 1

You're not updating the property.
public string CurrentVersion { get; set; }
is what you want to update. Because you're not calling OnPropertyChanged in the setter, the TextBox isn't going to update to a new version.
private string _currentVersion = string.Empty;
public string CurrentVersion
{
get { return _currentVersion };
set
{
_currentVersion = value;
OnPropertyChanged("CurrentVersion");
}
}
I would guess that your DatabaseInfo is your Model ;). This is where you might choose to make a small ViewModel wrapper class that returns/sets the updated values so you keep INPC out of your Model layer. Otherwise you can go with the code snippet above :)
EDIT
In that case, just spell correctly ;)
TextBox Text="{Binding CurrentVerion}"