I have a table with column with cyrillic text. I want to iterate the table and proccess the rows one by one.
DECLARE #safeSize VARCHAR(50)
DECLARE #safeId INT
DECLARE db_cursor CURSOR FOR
select coalesce(s.id,0), coalesce(s.size,'-')
from old_nom_trezor s
order by s.id
OPEN db_cursor
FETCH NEXT FROM db_cursor INTO #safeId, #safeSize
WHILE ##FETCH_STATUS = 0
BEGIN
print #safeSize -- prints ???
print #safeId -- prints ???
--Insert statement with the vars. Also inserts ?
FETCH NEXT FROM db_cursor INTO #safeId, #safeSize
END
CLOSE db_cursor
DEALLOCATE db_cursor
The problem is that the cyrillic symbols are printed as ? and also if I insert them in other table the result is ?. Simple select in the Management studio displays the right symbols. How can I fetch the cyrillic symbols in cyrillic?
Cyrillic text consists of unicode characters, which can't be stored in a VARCHAR datatype.
Change this DECLARE #safeSize VARCHAR(50)
to this DECLARE #safeSize NVARCHAR(50)
Related
How do I select multiple columns in a cursor?
I tested the below code but it's returning/printing nothing.
DECLARE #DateAdded VARCHAR(50)
DECLARE #IdEmployee NVARCHAR(20)
DECLARE #EmailAddress VARCHAR(100)
DECLARE #Subject VARCHAR(50)
DECLARE #Message VARCHAR(100)
DECLARE #DateSent VARCHAR(50)
-- 2 - Declare Cursor
DECLARE db_cursor CURSOR FOR
-- Populate the cursor with your logic
-- * UPDATE WITH YOUR SPECIFIC CODE HERE *
SELECT
#DateAdded, #IdEmployee, #EmailAddress,
#Subject, #Message, #DateSent
FROM #tblLeaveNotifToApprover
OPEN db_cursor
FETCH NEXT FROM db_cursor INTO #DateAdded, #IdEmployee, #EmailAddress, #Subject, #Message, #DateSent
WHILE ##FETCH_STATUS = 0
BEGIN
-- 4 - Begin the custom business logic
-- * UPDATE WITH YOUR SPECIFIC CODE HERE *
PRINT CONVERT(VARCHAR,#DateAdded)
FETCH NEXT FROM db_cursor INTO #DateAdded, # IdEmployee, #EmailAddress, #Subject, #Message, #DateSent
END
CLOSE db_cursor
DEALLOCATE db_cursor
Initially wanted to print all that columns in each row, but after running the snippet/code it nothing displays, I also tried converting the variables to varchar same result is thrown.
I expect that all the columns of my 7 rows will be print out.
This is wrong
DECLARE db_cursor CURSOR FOR
-- Populate the cursor with your logic
-- * UPDATE WITH YOUR SPECIFIC CODE HERE *
SELECT
#DateAdded, #IdEmployee, #EmailAddress,
#Subject, #Message, #DateSent
FROM #tblLeaveNotifToApprover
You need to replace the variables in this SELECT statement with the actual column names from the table. You don't refer to your local variables until the FETCH statement.
Think of your CURSOR as a selected set of data from the source tables that you will then iterate through.
Your snippet contains the hints to identify what is in the CURSOR, in your case refer to
-- Populate the cursor with your logic
-- * UPDATE WITH YOUR SPECIFIC CODE HERE *
In your case, your are trying to populate your CURSOR using the values from the variables you have declared using the statement:
SELECT #DateAdded,
#IdEmployee,
#EmailAddress,
#Subject,
#Message,
#DateSent
FROM #tblLeaveNotifToApprover
Now, since you have not populated those variables yet they are all NULL
What you then do is SELECT the variables that you have just declared back into the variables !!!!!
FETCH NEXT FROM db_cursor INTO #DateAdded,#IdEmployee,#EmailAddress,#Subject,#Message,#DateSent
WHILE ##FETCH_STATUS = 0
So it is little surprise that when you try to print these you get nothing returned.
Go back to your DECLARE CURSOR and ensure that you are actually selecting a data set to iterate through. a CURSOR should generally always be kind of like a temporary table. If we assume that your temp table #tblLeaveNotifToApprover has column names that match your variable names then you need:
DECLARE db_cursor CURSOR FOR
SELECT DateAdded,
IdEmployee,
EmailAddress,
Subject,
Message,
DateSent
FROM #tblLeaveNotifToApprover
I'm trying to iterate over some tables and clear all records.
My code is the following :
DECLARE #table varchar(100)
DECLARE db_cursor CURSOR FOR select name from sys.tables where name like '%cfe_%'
OPEN db_cursor
FETCH NEXT FROM db_cursor INTO #table
WHILE ##FETCH_STATUS = 0
BEGIN
print #table
delete from #table
FETCH NEXT FROM db_cursor INTO #table
END
CLOSE db_cursor
DEALLOCATE db_cursor
But I receive "Must declare the table variable "#table" at the line "delete..."
I can't see the error.
Thank you
You shoud use dynamic query,
DECLARE #table varchar(100)
,#v_str nvarchar(200)
DECLARE db_cursor CURSOR FOR select name from sys.tables where name like '%cfe_%'
OPEN db_cursor
FETCH NEXT FROM db_cursor INTO #table
WHILE ##FETCH_STATUS = 0
BEGIN
print #table
set #v_str = 'delete from '+#table
exec(#v_str)
FETCH NEXT FROM db_cursor INTO #table
END
CLOSE db_cursor
DEALLOCATE db_cursor
You need dynamic delete statement... Try this :
DECLARE #cmd VARCHAR(4000)
DECLARE #table varchar(100)
DECLARE db_cursor CURSOR FOR select name from sys.tables where name like '%cfe_%'
OPEN db_cursor
FETCH NEXT FROM db_cursor INTO #table
WHILE ##FETCH_STATUS = 0
BEGIN
SET #cmd = 'DELETE FROM '+#table
EXEC (#cmd)
FETCH NEXT FROM db_cursor INTO #table
END
CLOSE db_cursor
DEALLOCATE db_cursor
Even better would be to not use a cursor here. Looping in sql is a last resort. Also, your query is not going to do exactly what you think it will because you are using like and wanting to find an underscore. The underscore in a LIKE predicate requires it to be escaped with square brackets. As posted your query will return any table with cfe in the name not cfe_.
Once you are comfortable that the dynamic sql string is what you want you can uncomment it to execute it.
declare #SQL nvarchar(max) = ''
select #SQL = #SQL + 'delete from ' + name + ';'
from sys.tables
where name like '%cfe[_]%'
select #SQL
--exec sp_executesql #SQL
We can also use while loop for this process
DECLARE #Min Int,#max Int
IF Object_id('Tempdb..#DeleteList')IS NOT NULL
DROP TABLE #DeleteList
CREATE TABLE #DeleteList (Id Int Identity,Name varchar(100))
INSERT INTO #DeleteList(Name)
SELECT name FROM sys.tables WHERE CHARINDEX('cfe_',name)>0
SELECT #Min=Min(Id) FROm #DeleteList
SELECT #max=MAX(Id) FROm #DeleteList
While(#Min<=#max)
Begin
Declare #TableName Varchar(50),
#Sql Nvarchar(max)
SELECT #TableName=Name From #DeleteList Where id=#Min
SET #Sql='DELETE From '+#TableName
Exec (#Sql)
SET #Min=#Min+1
END
But if the deleting tables have foreign key refrences it will throw error so that first you need delete records from child and then go to Parent table
You will need to do something like;
EXEC sp_executesql #statement = N'DELETE FROM ' + #table
because currently you are trying to delete from a String variable, not the table named the same as the variable
I have the table contents as shown in this picture:
The formula column contains the the column names as variables in the formula expression.
I am trying to get a computed column Score corresponding for each emp_id,Tsk_id and processed date which would be calculated dynamically based on the formulae given in the formula column and push it to a temp table
I have tried to achieve it by dynamic SQL within a cursor using the below code which has been successful. Can Anyone suggest a better way to do it, maybe using a CTE or something ?
DECLARE #EMP_ID nVARCHAR(255)
DECLARE #TSK_ID nVARCHAR(255)
DECLARE #PROCESSEDDATE nVARCHAR(255)
DECLARE #SQLCMD nVARCHAR(max)
DECLARE #SQLTEXT nvarchar(max)
DECLARE db_cursor CURSOR FOR
SELECT EMP_ID,TSK_ID,PROCESSEDDATE from dbo.[Formula_Cal] group by EMP_ID,TSK_ID,PROCESSEDDATE
OPEN db_cursor
FETCH NEXT FROM db_cursor INTO #EMP_ID,#TSK_ID,#PROCESSEDDATE
WHILE ##FETCH_STATUS = 0
BEGIN
Set #SQLTEXT = (Select formula from dbo.[Formula_Cal] where EMP_ID=#EMP_ID and TSK_ID =#TSK_ID and PROCESSEDDATE=#PROCESSEDDATE )
Set #SQLCMD ='select emp_id,TSK_ID,convert(decimal(18,2),( ' +#SQLTEXT+ ')) As Score FROM [Formula_Cal] where TSK_ID = '+#TSK_ID+' and EMP_ID = '+#EMP_ID
--Select #SQLTEXT
--Select #SQLCMD
insert into dbo.TMP_ACHSCR(emp_id,TSK_id,Score)
Exec sp_executesql #SQLCMD
FETCH NEXT FROM db_cursor INTO #EMP_ID,#TSK_ID,#PROCESSEDDATE
END
CLOSE db_cursor
DEALLOCATE db_cursor
No this is easiest way (with minimal rewriting). You can access this with rewriting our formulas into function.
I have a view in a SQL Server 2008 database that has a datetime2 field. I need to be able to query from that view via a linked SQL server 2005. When I run open my cursor and fetch the records I get a "Conversion failed when converting datetime from character string." error. How do I make the cursor convert the datetime2 appropriately?
Here is my query that is failing
DECLARE #time DateTime
DECLARE db_cursor CURSOR FOR
SELECT [DateTime] FROM [LINKEDSERVER].[DATABASENAME].[dbo].[ViewName]
WHERE Name = 'blah'
OPEN db_cursor
FETCH NEXT FROM db_cursor INTO #time
WHILE ##FETCH_STATUS = 0
BEGIN
Print #time
FETCH NEXT FROM db_cursor INTO #time
END
CLOSE db_cursor
DEALLOCATE db_cursor
Any ideas?
try to declare cursor in following way:
DECLARE db_cursor CURSOR FOR
SELECT cast([DateTime] as DateTime) FROM [LINKEDSERVER].[DATABASENAME].[dbo].[ViewName]
WHERE Name = 'blah'
BUT
if remote values from DATETIME2 field is outside the allowed to DateTime type, then try the following
DECLARE #time NVARCHAR(100)
DECLARE db_cursor CURSOR FOR
SELECT CAST([DateTime] as NVArCHAR(100)) FROM [LINKEDSERVER].[DATABASENAME].[dbo].[ViewName]
WHERE Name = 'blah'
OPEN db_cursor
FETCH NEXT FROM db_cursor INTO #time
WHILE ##FETCH_STATUS = 0
BEGIN
Print #time
FETCH NEXT FROM db_cursor INTO #time
END
CLOSE db_cursor
DEALLOCATE db_cursor
We have triggers on a table called OSPP to save specific data to a table for later use.
I get the following error in SAP when adding more than one line at a time to the table.
Invalid Cursor State
We have SQL Server 2005 SP3 (but I tried it on a clean 2005 install, on SP1 and SP2)
The one trigger :
CREATE TRIGGER [dbo].[tr_OSPP_Insert]
ON [dbo].[OSPP]
FOR INSERT
AS
BEGIN
Declare #ItemCode varchar(255)
Declare #CardCode varchar(255)
Declare #Price decimal(18,2)
Declare #ListNum bigint
Declare #ID bigint
Declare #Remote char(1)
DECLARE db_cursor CURSOR FOR
SELECT ItemCode, CardCode, Price, ListNum
FROM INSERTED
OPEN db_cursor
FETCH NEXT
FROM db_cursor INTO #ItemCode, #CardCode, #Price, #ListNum
WHILE ##FETCH_STATUS = 0
BEGIN
SELECT #Remote = isnull(U_Remote, 'N') FROM OITM WHERE ItemCode = #ItemCode
IF ltrim(rtrim(upper(#Remote))) = 'Y'
BEGIN
SELECT #ID = U_ID FROM [dbo].[#BDS_MAINTENANCE]
UPDATE [dbo].[#BDS_MAINTENANCE] set U_ID = U_ID + 1
INSERT INTO [dbo].[#BDS_REMOTESPECIALPRICELIST]
(
Code,
[Name],
U_ID,
U_ItemCode,
U_CardCode,
U_Price,
U_ListNum,
U_TransactionType,
U_Uploaded
) VALUES (
#ID,
'_' + cast(#ID as VARCHAR(50)),
#ID,
#ItemCode,
#CardCode,
#Price,
#ListNum,
1,
0
)
FETCH NEXT
FROM db_cursor INTO #ItemCode, #CardCode, #Price, #ListNum
END
CLOSE db_cursor
DEALLOCATE db_cursor
END
END
We also tried :
CREATE TRIGGER [dbo].[tr_OSPP_Insert]
ON [dbo].[OSPP]
FOR INSERT
AS
BEGIN
SELECT * INTO [#TEMPTABLE222] FROM INSERTED
END
But still get the same error.
Do you guys have any idea what is wrong?
Thanks in advance!
I count three Begins, and three Ends. But it's the second pair that represent the cursor loop - so I'd move your Close/Deallocate to be after the second End, rather than before. E.g:
FETCH NEXT
FROM db_cursor INTO #ItemCode, #CardCode, #Price, #ListNum
END
CLOSE db_cursor
DEALLOCATE db_cursor
END
Probably needs to be:
END
FETCH NEXT
FROM db_cursor INTO #ItemCode, #CardCode, #Price, #ListNum
END
CLOSE db_cursor
DEALLOCATE db_cursor
(I've also moved the fetch next one level out, since otherwise you only move the cursor forwards inside your IF condition)
And one style comment (can't resist). It's generally considered good practice to SET NOCOUNT ON within the body of a trigger, to avoid sending lots of extra n rows affected messages.