Insert data into different tables in stored procedure - sql-server

Question

Following is the original SP which always inserts into table1 (INSERT INTO table1). Now I need to insert either into table1 or table2 which both have the same structure.
I tried to pass the tableName as parameter into SP.
ALTER PROCEDURE [dbo].[sp_importStats] (
#accountID BIGINT,
#csvFileName VARCHAR (1024),
#csvFormatFileName VARCHAR (1024)
#tableName VARCHAR(256))
Then I tried to INSERT using EXECUTE as following:
--Incorrect syntax near EXECUTE.
EXECUTE(
'INSERT INTO '+ #tableName + '(accountId, date, cost)
(SELECT cte.id, ms.date, ms.cost
FROM #stats ms
INNER JOIN CTE cte ON ms.accountNumber = cte.key4)');
Then I tried this:
--Must declare the table variable #tableName.
INSERT INTO #tableName (accountId, date, cost)
(SELECT cte.id, ms.date, ms.cost
FROM #stats ms
INNER JOIN CTE cte ON ms.accountNumber = cte.key4);
Then I tried not to pass the tableName and instead pass a boolean into SP and based on that decide which table I need to insert to:
ALTER PROCEDURE [dbo].[sp_importStats] (
#accountID BIGINT,
#csvFileName VARCHAR (1024),
#csvFormatFileName VARCHAR (1024),
#condition BIT = 0)
IF (#condition= 0)
SET #table = 'table1'
ELSE
SET #table = 'table2'
--Must declare the table variable "#table".
INSERT INTO #table (accountId, date, cost)
(SELECT cte.id, ms.date, ms.cost
FROM #sats ms
INNER JOIN CTE cte ON ms.accountNumber = cte.key4);
I got error either way. Would you please let me know what's the best way to handle this? Why am I receiving these errors? Any help is greatly appreciated.
Original SP:
ALTER PROCEDURE [dbo].[sp_importStats] (
#accountID BIGINT,
#csvFileName VARCHAR (1024),
#csvFormatFileName VARCHAR (1024))
AS
BEGIN
CREATE TABLE #stats(
[accountID] [bigint] NOT NULL,
[accountNumber] [varchar](30) NULL,
[date] [datetime] NOT NULL,
[cost] [money] NULL,
);
EXECUTE('INSERT INTO #stats SELECT * FROM '+
'OPENROWSET (BULK N''' + #csvFileName + '''' +
',FORMATFILE='''+#csvFormatFileName+''''+
',FIRSTROW=2'+
',MAXERRORS=0'+
') AS t;');
WITH CTE(id, key4) AS (
SELECT A.id, A.[key4]
FROM VA A (NOLOCK)
WHERE A.id = #accountID
UNION ALL
SELECT A.id, A.[key4]
FROM VA A (NOLOCK)
INNER JOIN CTE ON (CTE.id = A.MAID)
WHERE A.key4 IS NOT NULL
)
INSERT INTO table1 (accountId, date, cost)
(SELECT cte.id, ms.date, ms.cost
FROM #stats ms
INNER JOIN CTE cte ON ms.accountNumber = cte.key4);
DROP TABLE #stats;
END
This is what I have now:
ALTER PROCEDURE [dbo].[sp_importStats] (
#accountID BIGINT,
#csvFileName VARCHAR (1024),
#csvFormatFileName VARCHAR (1024)
#tableName VARCHAR(256))
AS
BEGIN
DECLARE #sql NVARCHAR(MAX);
CREATE TABLE #stats(
[accountID] [bigint] NOT NULL,
[accountNumber] [varchar](30) NULL,
[date] [datetime] NOT NULL,
[cost] [money] NULL,
);
EXECUTE('INSERT INTO #stats SELECT * FROM '+
'OPENROWSET (BULK N''' + #csvFileName + '''' +
',FORMATFILE='''+#csvFormatFileName+''''+
',FIRSTROW=2'+
',MAXERRORS=0'+
') AS t;');
WITH CTE(id, key4) AS (
SELECT A.id, A.[key4]
FROM VA A (NOLOCK)
WHERE A.id = #accountID
UNION ALL
SELECT A.id, A.[key4]
FROM VA A (NOLOCK)
INNER JOIN CTE ON (CTE.id = A.MAID)
WHERE A.key4 IS NOT NULL
)
--Incorect synstax near SET.
SET #sql = 'INSERT INTO '+ QUOTENAME(#tableName) + '(accountId, date, cost)
(SELECT cte.id, ms.date, ms.cost
FROM #stats ms
INNER JOIN CTE cte ON ms.accountNumber = cte.key4)';
EXECUTE sp_executesql #sql;
DROP TABLE #stats;
END

Answer 1

Passing Table Name as Parameter
Use QUOTENAME() Function to put square brackets around your table names to tell sql server explicitly that it is a Sql Server Object name something like this ..
DECLARE #Sql NVARCHAR(MAX);
SET #Sql = N';WITH CTE(id, key4) AS (
SELECT A.id, A.[key4]
FROM VA A (NOLOCK)
WHERE A.id = #accountID
UNION ALL
SELECT A.id, A.[key4]
FROM VA A (NOLOCK)
INNER JOIN CTE ON (CTE.id = A.MAID)
WHERE A.key4 IS NOT NULL
)
INSERT INTO ' + QUOTENAME(#tableName) +' (accountId, date, cost)
SELECT cte.id, ms.date, ms.cost
FROM #stats ms
INNER JOIN CTE cte ON ms.accountNumber = cte.key4;'
EXECUTE sp_executesql #Sql
Using QUOTENAME() Function can protect you against a possible sql injection attack. Also you do not need parenthesis around your select statement.
Also you should avoid using sp_ prefix for you stored Procedure names. Read Here why.
Using IF..ELSE Blocks
IF (Some_Condition IS TRUE)
BEGIN
/* Insert Statement For Table One*/ --<-- No need to use table Names as variable
END -- just hardcode the table names in your
ELSE -- Insert Statements
BEGIN
/* Insert Statement For Table Two*/
END

Answer 2

Did you notice that you missed a comma in declaration.
ALTER PROCEDURE [dbo].[sp_importStats] (
#accountID BIGINT,
#csvFileName VARCHAR (1024),
#csvFormatFileName VARCHAR (1024),---comma missing here
#tableName VARCHAR(256))