C function to copy directory in UNIX: files fail to copy - c

Question

I'm trying to write a function in C to copy the contents of a directory to another directory. Here is what I have so far:
void *copydirectory(void *arg1, void *arg2)
{
int error;
struct dirent *direntp;
DIR *dirp_source, *dirp_destination;
char *source, *destination;
copy_t copy;
char filename[MAXNAME];
// Set directory arguments
source = arg1;
destination = arg2;
fprintf(stderr, "Source directory is %s and destination directory is %s\n", source, destination);
// Open directories
if ((dirp_source = opendir(source)) == NULL)
{
fprintf(stderr, "Failed to open %s\n", source);
return 1;
}
if ((dirp_destination = opendir(destination)) == NULL)
{
perror("Failed to open destination directory");
return 1;
}
// Read files in directory
while ((direntp = readdir(dirp_source)) != NULL)
{
copy.tid = pthread_self();
fprintf(stderr, "now at line 64\n");
// Copy source filename
if (snprintf(filename, MAXNAME, direntp->d_name) == MAXNAME)
{
fprintf(stderr, "Input filename %s is too long", direntp->d_name);
continue;
}
fprintf(stderr, "now at line 73\n");
fprintf(stderr, "%s\n", filename);
// Open file for reading
if ((copy.args[0] = open(filename, R_FLAGS)) == -1)
{
fprintf(stderr, "Failed to open source file %s: %s\n", filename, strerror(errno));
continue;
}
// Create destination filename for writing
if (snprintf(filename, MAXNAME, "%s", direntp->d_name) == MAXNAME)
{
fprintf(stderr, "Output filename %s is too long\n", direntp->d_name);
continue;
}
fprintf(stderr, "%s\n", filename);
// Open file for writing
if ((copy.args[1] = open(filename, W_FLAGS, W_PERMS)) == -1)
{
fprintf(stderr, "Failed to open destination file %s: %s\n", filename, strerror(errno));
continue;
}
if (error = pthread_create((&copy.tid), NULL, copyfilepass, copy.args))
{
fprintf(stderr, "Failed to create thread: %s\n", strerror(error));
copy.tid = pthread_self();
}
}
// Close directory
while ((closedir(dirp_source) == -1) && (errno = EINTR));
fprintf(stderr, "Successfully copied all files in directory \n");
}
Now, for testing I simply have 2 directories in the folder named dir1 and dir2. dir1 contains 3 files: file1, file2, file3.
But, when I compile and run the code, I get these messages:
./
./
Failed to open destination file .: is a directory
Failed to open source file file2: No such file or directory
Failed to open source file file3: No such file or directory
../
../
Failed to open destination file .: is a directory
Failed to open source file file1: No such file or directory
Anyone have any suggestions on what's wrong?

Answer 1

Failed to open destination file .: is a directory
You see this because your source directory contains links called "." and ".." to itself and its parent directory respectively. You should specifically check for and avoid these entries.
Failed to open source file file2: No such fle or directory
You see this because you're trying to open a file called "file2" in the process's current working directory, but that doesn't exist - the file you're after is in the source directory. You need to build the filename taking this into account:
// Copy source filename
if (snprintf(filename, MAXNAME, "%s/%s", source, direntp->d_name) == MAXNAME)