The intruder detector - OpenCv - C - c

Question

I'm doing "photo" processing application using C with OpenCV.
My computer will constantly survey its surroundings using its
webcam. When it detects movement, it will write the current
webcam image to a file (notify).
This is how I have written the code , but it is very slow, I'm not good in doing the notify....could you give me please some good advice concerning the code?
#include <stdio.h>
#include "cv.h"
#include "highgui.h"
#include <dos.h>
#include <conio.h>
CvCapture *capture;
int key;
IplImage *oldFrame;
IplImage *currentFrame;
IplImage *res;
int f=0,x,y,idx,idy;
int currentFrame_width, currentFrame_height;
int oldFrame_width, oldFrame_height;
int res_width, res_height;
int main( int argc, char** argv )
{
while( key != 'q' )
{
capture = cvCaptureFromCAM( 0 );
if( !capture ) return 1;
key = cvWaitKey( 1 );
cvNamedWindow( "FrameController", CV_WINDOW_AUTOSIZE );
if(f==0){
oldFrame = cvQueryFrame( capture );
cvShowImage( "FrameController", oldFrame );
f=1;
}
else{
CvMemStorage* storage = cvCreateMemStorage(0);
currentFrame = cvQueryFrame( capture );
for ( x=0;x<currentFrame->width;x++)
{
for ( y=0;y<currentFrame->height;y++)
{
idx = y*currentFrame->widthStep + currentFrame->nChannels*x;
idy = y*oldFrame->widthStep + oldFrame->nChannels*x;
}
}
uchar R= (uchar) currentFrame->imageData [idx+0];
uchar G = (uchar) currentFrame->imageData [idx+1];
uchar B = (uchar) currentFrame->imageData [idx+2];
uchar R1= (uchar) oldFrame->imageData [idy+0];
uchar G1 = (uchar) oldFrame->imageData [idy+1];
uchar B1 = (uchar) oldFrame->imageData [idy+2];
if(!((R==R1) || (G==G1) || (B==B1))){
f=0;
CvHaarClassifierCascade* cascade = (CvHaarClassifierCascade*)cvLoad( "C:\\OpenCV2.1\\data\\haarcascades\\haarcascade_frontalface_alt2.xml" );
double scale = 1.3;
static CvScalar colors[] = {CV_RGB(rand()&255, rand()&255, rand()&255 )};
cvClearMemStorage( storage );
CvSeq* objects = cvHaarDetectObjects( currentFrame, cascade, storage, 1.1, 4, 0, cvSize( 40, 50 ));
CvRect* r;
for( int i = 0; i < (objects ? objects->total : 0 ); i++ ){
r = ( CvRect* )cvGetSeqElem( objects, i );
cvRectangle( currentFrame, cvPoint( r->x, r->y ), cvPoint( r->x + r->width, r->y + r->height ),
colors[i%8]);
cvShowImage( "FrameController", currentFrame );
}
}
}
}
cvDestroyWindow( "FrameController" );
cvReleaseCapture( &capture );
cvReleaseImage( &currentFrame);
cvReleaseImage( &oldFrame);
return 0;
}

Answer 1

Seems like you're doing unnecessary initializations inside your while loop. For example
capture = cvCaptureFromCAM( 0 ); << is that necessary to be in the loop?
cvNamedWindow( "FrameController", CV_WINDOW_AUTOSIZE ); << this?
for ( x=0;x<currentFrame->width;x++)
{
for ( y=0;y<currentFrame->height;y++)
{
idx = y*currentFrame->widthStep + currentFrame->nChannels*x;
idy = y*oldFrame->widthStep + oldFrame->nChannels*x;
}
} << that's a loop over the WHOLE IMAGE that does NOTHING.
What is the storage used for?
Hope that helped you clean up your code a bit.