I am trying to implement the beforeedit listener in my table. I would like to do some checking before a user is allowed to do something to the cell.
Ext.define('myGrid', {
extend: 'Ext.grid.Panel',
listeners: {
beforeedit: function (e) {
alert('hi')
},
}
When I try and edit a cell, this alert(..) is not called. Why is this not going into the listener? If I look on the internet there are plenty of examples of Ext.grid.Panel with beforeedit.
Anyway I tried to extend with Ext.grid.EditorGridPanel instead.
Ext.define('myGrid', {
extend: 'Ext.grid.EditorGridPanel',
listeners: {
beforeedit: function (e) {
alert('hi')
}
}
Now I get an obscure error in typical extjs fashion :
http://jsfiddle.net/S8Tgm/13/
What am I doing wrong? And why should you use EditorGridPanel over normal grid? Is it for the Excel like properties?
EDIT : yes. sorry i forgot to put beforeedit in 'listeners'. Question still stands as is though.
listeners: {
beforeedit: function (e) {
alert('hi')
}
},
plugins: [
Ext.create('Ext.grid.plugin.RowEditing', { //or even better - use ptype here
clicksToEdit: 1
})],
http://jsfiddle.net/S8Tgm/12/ - working fiddle
You miss a few things:
Grid has NO 'beforeedit' event. You need to add an editor to your grid Example is here
Events should be put in the "listeners" object
(having big troubles with stackoverflow markup)
I am confused between the proper usage of Listeners vs Controllers
E.g. for the same button, I can make the handler for the button-tap event in the button description itself as :
Ext.Viewport.add({
xtype: 'button',
centered: true,
text: 'My Button',
listeners: {
tap: function() {
alert("You tapped me");
}
}
});
and also as in a separate controller as below.
Ext.define("NotesApp.controller.Notes", {
extend: "Ext.app.Controller",
config: {
refs: {
newNoteBtn: Get reference to button here
},
control: {
newNoteBtn: {
tap: "onNewNote"
}
}
},
onNewNote: function () {
console.log("onNewNote");
}
});
What is the best practice, and are there trade-offs?
Thanks
To controller or not to controller, that is the question.
Well, technically, nothing would prevent you from doing one or the other. I have established a way how to decide for myself:
I install listeners on view if the job they are doing does not cross boundaries of the view. If we take form as an example, disabling and enabling, showing and hiding of fields, if it depends only on the state of the form stay within the form - no controller.
I delegate the logic to a controller if the action in one view (a button click, for example) influences another view or the whole application.
Again, these are my preferences, you can have another.
Simple new-to-sencha question that has me stumped for a while. I am trying to have an event fire on keypress. I want the event to be bound on the TextField. I have created a fiddle
http://jsfiddle.net/CjyFt/1/
initComponent: function() {
this.on('click', function() {
console.log('Clicked'); // doesn't fire either
});
}
I have tried them each separately if that is a concern...
...
enableKeyEvents: true,
listeners : {
scope: this,
'keypress' : function(textfield, e) {
console.log('lovely'); // doesn't fire
}
}
...
I have tried placing the listener in every parent class and I have tried to bind different events without any of them working, can someone take a look and see if it's something obvious?
The keypress event (as well the related configuration option enableKeyEvents) is defined in Ext.form.field.Text, however you're extending your class Ext.form.CustomField from Ext.form.field.Base, which is the parent class of Ext.form.field.Text and therefore does not have this event (see class hierarchy).
I've updated your fiddle and it works fine: http://jsfiddle.net/CjyFt/2/
I just changed this:
Ext.define('Ext.form.CustomField', {
extend: 'Ext.form.field.Text', // instead of Ext.form.field.Base
...
The click event on the button already worked for me, so I don't think there is a problem with that.
I have in Architect the following structure.
A controller that includes a view (example MyPanelView)
In the MyPanelView, you can have a button, and give it an itemId. Then you can
bind it to a click event. You can use the click event (inline) without the controller,
or you can move the event to the controller. That works fine.
But what about these events? afterrender, beforerender, etc..? If you move this up to
the controller, the event does not get fired there.
Since this is not working, how could I acces the controller methods within
the afterrender function of the panel?
onAfterrenderMyPanelView : function(component, eOpts) {
this.getRefToOtherPanel() //not working
}
Thanks in advance! I'm lost..
Chris.
You can set up listeners and event handlers in your controller like this (example from the Sencha docs):
Ext.define('MyApp.controller.Users', {
extend: 'Ext.app.Controller',
init: function() {
this.control({
'viewport > panel': { //<-- ComponentQuery
render: this.onPanelRendered //<-- event handler
}
});
},
onPanelRendered: function() {
console.log('The panel was rendered');
}
});
Is there a way to use the Ext.app.Controller control() method, but pass in a DOM query? I have a page that contains standard links and would like to add a click handler to them even though they were not created as Ext Buttons.
I've tried
Ext.define('app.controller.TabController', {
extend: 'Ext.app.Controller',
init: function() {
console.log("init");
this.control({
'a': {
click: this.changeTab
}
});
},
changeTab: function() {
alert("new tab!");
}
});
But clicking on links does not fire the alert.
Is there a way to specify a CSS selector with this.control? Or does it only work with components?
I asked this question at SenchaCon this year, the Sencha developers stated that their intent is that DOM listeners should be attached within your view, and the view should abstract them into more meaningful component events and refire them.
For example, suppose you're creating a view called UserGallery that shows a grid of people's faces. Within your UserGallery view class, you would listen for the DOM click event on the <img> tag to receive event and target, and then the view might fire a component event called "userselected" and pass the model instance for the clicked user instead of the DOM target.
The end goal is that only your views should be concerned with things like interface events and DOM elements while the application-level controller only deals with meaningful user intents. Your application and controller code shouldn't be coupled to your markup structure or interface implementation at all.
Sample View
Ext.define('MyApp.view.UserGallery', {
extend: 'Ext.Component'
,xtype: 'usergallery'
,tpl: '<tpl for="users"><img src="{avatar_src}" data-ID="{id}"></tpl>'
,initComponent: function() {
this.addEvents('userselected');
this.callParent(arguments);
}
,afterRender: function() {
this.mon(this.el, 'click', this.onUserClick, this, {delegate: 'img'});
this.callParent(arguments);
}
,onUserClick: function(ev, t) {
ev.stopEvent();
var userId = Ext.fly(t).getAttribute('data-ID');
this.fireEvent('userselected', this, userId, ev);
}
});
Notes on views
Extend "Ext.Component" when all you want is a managed <div>, Ext.Panel is a lot heavier to support things like titlebars, toolbars, collapsing, etc.
Use "managed" listeners when attaching listeners to DOM elements from a component (see Component.mon). Listeners managed by a components will be automatically released when that component gets destroyed
When listening for the same event from multiple DOM elements, use the "delegate" event option and attach the listener to their common parent rather than to individual elements. This performs better and lets you create / destroy child elements arbitrarily without worrying about continuously attaching/removing event listeners to each child. Avoid using something like .select('img').on('click', handler)
When firing an event from a view, Sencha's convention is that the first parameter to the event be scope -- a reference to the view that fired the event. This is convenient when the event is being handled from a controller where you'll need the actual scope of the event handler to be the controller.
Sample Controller
Ext.define('app.controller.myController', {
extend: 'Ext.app.Controller'
,init: function() {
this.control({
'usergallery': {
userselected: function(galleryView, userId, ev) {
this.openUserProfile(userID);
}
}
});
}
,openUserProfile: function(userId) {
alert('load another view here');
}
});
I have found a work around for this problem. It isn't as direct as one may hope, but it leaves all of your "action" code in the controller.
requirment: Wrap the html section of your page in an actual Ext.Component. This will likely be the case either way. So for instance, you may have a simple view that contains your HTML as follows:
Ext.define('app.view.myView', {
extend: 'Ext.panel.Panel',
alias: 'widget.myView',
title: 'My Cool Panel',
html: '<div>This link will open a window</div><br /> <label for="myInput">Type here: </label><input name="myInput" type="text" value="" />',
initComponent: function(){
var me = this;
me.callParent(arguments);
}
});
Then in the controller you use the afterrender event to apply listeners to your DOM elements. In the example below I illustrate both links (a element) and input elements:
Ext.define('app.controller.myController', {
extend: 'Ext.app.Controller',
init: function() {
this.control({
'myView': {
afterrender: function(cmp){
var me = this; //the controller
var inputs = cmp.getEl().select('input'); // will grab all DOM inputs
inputs.on('keyup', function(evt, el, o){
me.testFunction(el); //you can call a function here
});
var links = cmp.getEl().select('a'); //will grab all DOM a elements (links)
links.on('click', function(evt, el, o){
//or you can write your code inline here
Ext.Msg.show({
title: 'OMG!',
msg: 'The controller handled the "a" element! OMG!'
});
});
}
}
});
},
testFunction: function(el) {
var str = 'You typed ' + el.value;
Ext.Msg.show({
title: 'WOW!',
msg: str
});
}
});
And there you have it, DOM elements handled within the controller and adhering to the MVC architecture!
No, this seems not to be possible. The Ext.EventBus listens to events fired by ExtJS components. Your standard DOM elements do not fire those events. Additionally the query is checked with the ExtJS componets is( String selector ) method, wich can't be called by DOM elements. Someone might correct me if i'm wrong, but so i'm quite sure it's not possible, unfortunately.
I also have a solution that works around this problem. I use this technique regardless though as it has other benefits: I created an application wide messaging bus. Its an object in my application that extends Observable, and defines a few events. I can then trigger those events from anywere in my app, including html a links. Any component that wants to listen to those events can relay them and they'll fire as if fired from that component.
Ext.define('Lib.MessageBus', {
extend: 'Ext.util.Observable',
constructor: function() {
this.addEvents(
"event1",
"event2"
);
this.callParent(arguments);
}
});
Then, each other compnent can add this after initialisation:
this.relayEvents('Lib.MessageBus', ['event1','event2']);
and then listen to those events.
You can trigger the events from anything by doing:
Lib.MessageBus.fireEvent('event1', 'param a', 'param b')
and you can do that from anything including html links.
Very handy to fire off events from one part of the app to another.
I had the same problem recently (mixing mvc with some non components).
Just thought I'd throw this in as an answer as it seems pretty simple and works for me :)
Ext.define('app.controller.TabController', {
extend: 'Ext.app.Controller',
init: function() {
console.log("init");
this.control({
/* 'a': {
click: this.changeTab
} */
});
var link = Ext.dom.Query.selectNode('a');
Ext.get(link).on('click', this.changeTab);
},
changeTab: function() {
alert("new tab!");
}
});