comparing data via a function - sql-server

Question

I have two sets of data (locations) in separate tables and I need to compare if they match or not. I have a UDF which performs a calculation based upon 5 values from each table.
How do I perform a select with a join using this udf?
my udf is basically defined by....
ALTER FUNCTION [dbo].[MatchRanking]
(
#Latitude FLOAT
, #Longitude FLOAT
, #Postcode VARCHAR(16)
, #CompanyName VARCHAR(256)
, #TelephoneNumber VARCHAR(32)
, #Latitude2 FLOAT
, #Longitude2 FLOAT
, #Postcode2 VARCHAR(16)
, #CompanyName2 VARCHAR(256)
, #TelephoneNumber2 VARCHAR(32)
)
RETURNS INT
WITH EXECUTE AS CALLER
AS
BEGIN
DECLARE #RetVal INT
DECLARE #PostcodeVal INT
SET #RetVal = 0
SET #PostcodeVal = 0
SET #RetVal = #RetVal + dbo.FuzzyLogicStringMatch(#CompanyName, #CompanyName2)
IF #RetVal = 1 AND dbo.TelephoneNoStringMatch(#TelephoneNumber, #TelephoneNumber2) = 1
RETURN 5
ELSE
IF #RetVal = 1 AND dbo.FuzzyLogicStringMatch(#Postcode, #Postcode2) = 1
RETURN 5
ELSE
IF #RetVal = 1 AND ROUND(#Latitude,4) = ROUND(#Latitude2,4) AND ROUND(#Longitude,4) = ROUND(#Longitude2,4)
RETURN 5
ELSE
IF (#RetVal = 1 AND ROUND(#Latitude,4) = ROUND(#Latitude2,4)) OR (#RetVal = 1 AND ROUND(#Longitude,4) = ROUND(#Longitude2,4))
SET #RetVal = 2
ELSE
BEGIN
IF ROUND(#Latitude,4) = ROUND(#Latitude2,4)
SET #RetVal = #RetVal + 1
IF ROUND(#Longitude,4) = ROUND(#Longitude2,4)
SET #RetVal = #RetVal + 1
SET #RetVal = #RetVal + dbo.TelephoneNoStringMatch(#TelephoneNumber, #TelephoneNumber2)
SET #RetVal = #RetVal + dbo.FuzzyLogicStringMatch(#Postcode, #Postcode2)
END
RETURN #RetVal
END
This is the previous code that I am trying to fix:
SELECT li.LImportId, l.LocationId, dbo.MatchRanking(li.Latitude, li.Longitude, li.[Name], li.Postcode, li.TelephoneNumber,
l.Latitude, l.Longitude, l.CompanyName, l.Postcode, l.TelephoneNumber
) AS [MatchRanking]
FROM #LocImport li
LEFT JOIN [Location] l
ON lI.[Latitude] = l.[Latitude]
OR lI.[Longitude] = l.[Longitude]
OR lI.[Postcode] = l.[Postcode]
OR lI.[Name] = l.[CompanyName]
OR lI.[TelephoneNumber] = l.[TelephoneNumber]

Answer 1

What was wrong with your original JOIN? that should perform much faster than this function.
This should do it, but I think it will be really slow:
SELECT
...
FROM Table1 t1
CROSS JOIN Table2 t2
WHERE dbo.MatchRanking(t1.Latitude ,..,..,t2.Latitude ,..)=1 --"1" or whatever return value is a match

Answer 2

One thing we did was set up a spearate table to store the results of the cross join so they only have to be calcluated once. Then have a job that runs nightly to pick up any new records and populated them against all the old records. After all the lat/longs are not going to change (except for the occasional type which the nightly job can find and fix) and it doesn't make sense to do this calculation everytime you run a query to find the distances when the calulation will alwys be the same for most of the numbers. Once this data is in a table, you can easily query very quickly. Populating the table the first time might take awhile.

Answer 3

Personally, I would do this kind of fuzzy data matching in several passes.
-create an xref table which contain the keys for the records that match
-get all that match exactly and insert the keys in the xref table
-"fuzzify" your criteria and search again but only in those records that do not already have a match in the xref.
-rinse and repeat by expanding and/or fuzzifying your criteria until the matches you get are garbage.

Answer 4

You will have to cross join the two tables (m and n yields m x n compares) first and compare to find matches - there is really no other simple way.
However, with meta-understanding of the data and its interpretation and your goals, if you can somehow filter your set to eliminate items from the cross join fairly easily, that would help - especially if there's anything that has to be an exact match, or any way to partition the data so that items in different partitions would never be compared (i.e. comparing a US and Europe location would always have match rank 0)
I would say that you could use the Lat and Long to eliminate completely if they differ by a certain amount, but it looks like they are used to improve the match ranking, not to negatively eliminate items from being match ranked.
And scalar functions (your FuzzyMatches) called repeatedly (like in a multi-million row cross join) are tremendously expensive.
It looks to me like you could extrac the first match and the inner else to take place in your cross join (and inline if possible, not as a UDF) so that they can be somewhat optimized by the query optimizer in conjunction with the cross join instead of in a black box called m x n times.
Another possibility is to pre-extract only the distinct Phone number pairs, post code pairs etc.
SELECT Postcode1, Postcode2, dbo.FuzzyLogicStringMatch(Postcode1, Postcode2) AS MatchRank
FROM (
SELECT DISTINCT Postcode AS Postcode1
FROM Table1
) AS Postcodes1
CROSS JOIN
(
SELECT DISTINCT Postcode AS Postcode2
FROM Table2
) AS Postcodes2
If your function is symmetric, you can further reduce this space over which to call the UDF with some extra work (it's easier if the table is a self-join, you just use an upper right triangle).
Now you have the minimal set of compares for your scalar UDF to be called over. Put this result into a table indexed on the two columns.
You can do similar for all your UDF parameter sets. If the function definition isn't changing, you only need to add new combinations to your table over time, turning an expensive scalar function call into a table-lookup on relatively slower growing data. You can even use a CASE statement to fall back on the UDF call inline if the lookup table doesn't have an entry - so you can decide whether to keep the lookup tables comprehensive or not.