Waiting for character in string - c
I am currently working on a project that will be used to test whether an instrument is within tolerance or not. My test equipment will put the DUT (Device Under Test) into a "Test Mode" where it will repeatedly send a string of data every 200ms. I want to receive that data, check is is within tolerance and give it a pass or fail.
My code so far (I've edited a few things out like .h files and some work related bits!):
void GetData();
void CheckData();
char Data[100];
int deviceId;
float a;
float b;
float c;
void ParseString(const char* stringValue)
{
char* token = NULL;
int tokenPlace = 0;
token = strtok((char *) stringValue, ",");
while (token != NULL) {
switch (tokenPlace) {
case 0:
deviceId = atoi(token);
break;
case 1:
a= ((float)atoi(token)) / 10.0f;
break;
case 2:
b= ((float)atoi(token)) / 100.0f;
break;
case 3:
c= ((float)atoi(token)) / 10.0f;
break;
}
tokenPlace++;
token = strtok(NULL, ",");
}
}
void GetData()
{
int x = UART.scanf("%s,",Data);
ParseString(Data);
if (x !=0) {
UART.printf("Device ID = %i\n\r", deviceId);
UART.printf("a= %.1f\n\r", a);
UART.printf("s= %.2f\n\r", b);
UART.printf("c= %.1f\n\n\r", c);
}
if (deviceId <= 2) {
CheckData();
} else {
pc.printf("Device ID not recognised\n\n\r");
}
}
void CheckData()
{
if (a >= 49.9f && a< = 50.1f) {
pc.printf("a Pass\n\r");
} else {
pc.printf("a Fail\n\r");
}
if (b >= 2.08f && b <= 2.12f) {
pc.printf("b Pass\n\r");
} else {
pc.printf("b Fail\n\r");
}
if (c >= 20.0f && c <= 25.0f) {
pc.printf("c Pass\n\n\r");
} else {
pc.printf("c Fail\n\n\r");
}
if (deviceId == 0) {
(routine1);
} else if (deviceId == 1) {
(routine2);
} else if (deviceId == 2) {
(Routine3);
}
}
int main()
{
while(1) {
if(START == 0) {
wait(0.1);
GetData();
}
}
}
And this works absolutely fine. I am only printing the results to a serial terminal so I can check the data is correct to make sure it is passing and failing correctly.
My issue is every now and then the START button happens to be pressed during the time the string is sent and the data can be corrupt, so the deviceId fails and it will say not recognised. This means I then have to press the start button again and have another go. A the moment, it's a rare occurrence but I'd like to get rid of it if possible. I have tried adding a special character at the beginning of the string but this again gets missed sometimes.
Ideally, when the start button is pressed, I would like it to wait for this special character so it knows it is at the beginning of the string, then the data would be read correctly, but I am unsure how to go about it.
I have been unsuccessful in my attempts so far but I have a feeling I am overthinking it and there is a nice easy way to do it. Probably been staring at it too long now!
My microcontroller is STM32F103RB and I am using the STM Nucleo with the mBed IDE as it's easy and convenient to test the code while I work on it.
You can use ParseString to return a status indicating whether a complete string is read or not.
int ParseString(const char* stringValue)
{
/* ... your original code ... */
/* String is complete if 4 tokens are read */
return (tokenPlace == 4);
}
Then in GetData use the ParseString return value to determine whether to skip the string or not.
void GetData()
{
int x = UART.scanf("%s,",Data);
int result = ParseString(Data);
if (!result) {
/* Did not get complete string - just skip processing */
return;
}
/* ... the rest of your original code ... */
}
Related
How to continually print output inside a switch statement?
I have been trying to continually print the PWM output of pin 3 inside the switch statement condition but it only prints once. Can I continually print it in serial monitor until it meets the second conditon? or use a while loop? or a if else ? Here is my code I also have a code with a similar function but it uses if else but still it only prints once void loop() { // if there's any serial available, read it: while (Serial.available() > 0) { int InitVal = Serial.parseInt(); int red = Serial.parseInt(); switch(InitVal) { case 1: if (Serial.read() == '\n') { analogWrite(redPin, red); Serial.println(red); Serial.write(red); } break; case 0: analogWrite(redPin, 0); Serial.println(0); Serial.write(0); break; } } } I'am planning to inter-phase this with a GUI . A GUI sends ascii to the arduino reads it then sends the output value to the GUI. Example 1.GUI sends [1,123] : 1 = the trigger point for the switch statement ; 123 = PWM value. Arduino receives instructions and it prints out the pwm value GUI receives pwm value and displays it Revised code: Stuck at the last while loop maybe i could use a threading function in arduino so that the last while loop would be satisfied/dissatisfied? void loop() { int InitVal = 0; // if there's any serial available, read it: while (Serial.available() > 0) { int InitVal = Serial.parseInt(); int red = Serial.parseInt(); switch(InitVal) { case 1: if (Serial.read() == '\n') { InitVal = 1; //analogWrite(redPin, red); //Serial.println(red); // Serial.write(red); } break; case 0: InitVal = 0; //analogWrite(redPin, 0); //Serial.println(0); //Serial.write(0); break; } if (InitVal) /* when enabled, blink leds */ { delay(20); while (InitVal == 1) /* loop forever */{ Serial.println(red); Serial.write(red); delay(20); } } } }
I discarded Serial.parseInt() function, removed the switch statments and followed #Arno Bozo advise on serial listening while following this tutorial on http://forum.arduino.cc/index.php?topic=396450.0 I came up with what I want and here is the code const int redPin = 3; const byte numChars = 32; char receivedChars[numChars]; char tempChars[numChars]; // temporary array for use when parsing // variables to hold the parsed data boolean newData = false; int InitVal = 0; // change to init value or red int red = 0; void setup() { // initialize serial: Serial.begin(9600); // make the pins outputs: pinMode(redPin, OUTPUT); } void loop() { recvWithStartEndMarkers(); if (newData == true) { strcpy(tempChars, receivedChars); // this temporary copy is necessary to protect the original data // because strtok() used in parseData() replaces the commas with \0 parseData(); One(); newData = false; } else { Zero(); } } ///////////////////// ///////////////////// ///////////////////// void recvWithStartEndMarkers() { static boolean recvInProgress = false; static byte ndx = 0; char startMarker = '<'; char endMarker = '>'; char rc; while (Serial.available() > 0 && newData == false) { rc = Serial.read(); if (recvInProgress == true) { if (rc != endMarker) { receivedChars[ndx] = rc; ndx++; if (ndx >= numChars) { ndx = numChars - 1; } } else { receivedChars[ndx] = '\0'; // terminate the string recvInProgress = false; ndx = 0; newData = true; } } else if (rc == startMarker) { recvInProgress = true; } } } ///////////////////// ///////////////////// ///////////////////// void parseData() { // split the data into its parts char * strtokIndx; // this is used by strtok() as an index strtokIndx = strtok(tempChars,","); // get the first part - the string InitVal = atoi(strtokIndx); // copy it to messageFromPC strtokIndx = strtok(NULL, ","); // this continues where the previous call left off red = atoi(strtokIndx); // convert this part to an integer } ///////////////////// ///////////////////// ///////////////////// void One() { if (InitVal == 0){ delay(20); Serial.println(0); delay(20); } } ///////////////////// ///////////////////// ///////////////////// void Zero() { if (InitVal == 1){ delay(20); Serial.println(red); delay(20); } } In Summary the code works like this 1.In serial monitor send this <1,123> : 1 = the trigger point for the switch statement ; 123 = PWM value. Arduino receives instructions and it prints out the pwm value If you send <0,123> it prints a zero once
I post a refined code here. The architecture may be reused for serial treatment. I have written it as an example for people I meet and who are learning with arduino. I have made comments and explanation of ways to avoid delay. Here it is used to print current value of pwm every 1s, without stopping with a delay(1000). #include <Arduino.h> // with schedule(f,i) , the function f() will be called every i ms // schedule(f,i) lines are put in loop() function // f is of type void f(void) #define schedule(f,i) {static unsigned long l=0;unsigned long c=millis();if((unsigned long)(c-l)>=i){l=c;f();}} const int ledPin = 13; void setup() { Serial.begin(9600); pinMode(ledPin, OUTPUT); } boolean newCommandHasArrived=false, newParsedCommand=false; String personalSerialBuffer=""; // char[] would be better; but String are so convenient enum ECommand {ecmdNoPwm=0, ecmdPwm=1, ecmdBad=10 }; ECommand cmd=ecmdNoPwm; int cmdArg=0; boolean readSerialBuffer(String &personalSerialBuffer); boolean parseCommand(String &apersonalSerialBuffer, ECommand &acmd, int &acmdArg); void executeCommand(ECommand acmd, int &acmdArg); void printCurrentValue() {Serial.println(String("cval:") + cmdArg);} void loop() { // transfer serial buffer in personal buffer newCommandHasArrived = readSerialBuffer(personalSerialBuffer); if (newCommandHasArrived) { newCommandHasArrived = false; newParsedCommand = parseCommand(personalSerialBuffer, cmd, cmdArg); } if (newParsedCommand) { newParsedCommand = false; executeCommand(cmd, cmdArg); } // I print current value every 1000ms //delay(1000); // you can often use delay without pb, but it is a bad usage // Here I provide you with a quick way to execute a task every 1000ms { const unsigned long delayBetweenExecution=1000; static unsigned long lastTime=0; unsigned long current = millis(); // note that C++ says that overflow on unsigned is well defined // it calculates modulo arithmetic if ((unsigned long)(millis() - lastTime) >= delayBetweenExecution) { lastTime = current; Serial.println(String("cval:") + cmdArg); } } // We can make it shorter thanks to a macro: // but you have to define a void function(void) that uses only global variable // because it has no argument : // void printCurrentValue() {Serial.print(String("cval:") + cmdArg);} //schedule(printCurrentValue, 1000); } boolean readSerialBuffer(String &personalSerialBuffer) { if (Serial.available() > 0) { personalSerialBuffer.concat(Serial.readString()); } // the frame is considered finished, if it ends with \n if (personalSerialBuffer.endsWith("\n")) return true; else return false; } boolean parseCommand(String &apersonalSerialBuffer, ECommand &acmd, int &acmdArg) { // format [ 1, 123]\n // I omit [ then I read first int : 1 // Note: I cannot detect if no int is found because it will return 0 that is a valid cmd int readCmd = apersonalSerialBuffer.substring(1).toInt(); // conversion readCmd to acmd switch (readCmd) { case 0: acmd = ecmdNoPwm; break; case 1: acmd = ecmdPwm; break; default: Serial.println(String("new command unknown: ") + apersonalSerialBuffer); apersonalSerialBuffer = ""; return false; } // find beginning of 2nd part, separated by ',' int sepPos = apersonalSerialBuffer.indexOf(','); // no ',' : indexOf returns -1 if (sepPos == -1) { Serial.println(String("new command could not be parsed: ") + apersonalSerialBuffer); apersonalSerialBuffer = ""; return false; } // Note: I cannot detect if no int is found because it will return 0 that is a valid cmd acmdArg = apersonalSerialBuffer.substring(sepPos+1).toInt(); // All is fine // I have to reset buffer before leaving apersonalSerialBuffer = ""; return true; } void executeCommand(ECommand acmd, int &acmdArg) { switch(acmd) { case ecmdNoPwm: // I erase acmdArg acmdArg = 0; analogWrite(ledPin, acmdArg); Serial.println("cmd no pwm"); break; case ecmdPwm: analogWrite(ledPin, acmdArg); Serial.print("cmd pwm:"); Serial.println(acmdArg); break; default: analogWrite(ledPin, 0); Serial.println("Bad cmd"); } }
Data by reference instead of value
I am trying to make a program that has a menu and it has an option to set the "current" date. I can define the date and it will stay until the program shuts down. I've got another method to get the date, by asking the user the date when linking a person to it, the problem is that it wont go on the main data on the main menu. It will only be the data for the .date on the person structure, I guess I explained it well. I've tried many ways and I really can't figure it out, if someone can help me out... typeData readData() { int val; typeData data; do { printf("Day: "); data.day = readInteger(MIN_DAYS, MAX_DAYS); printf("Month: "); data.month = readInteger(MIN_MONTH, MAX_MONTH); printf("Year: "); data.year = readInteger(MIN_YEAR, MAX_YEAR); val = validateData(data); if(val == 0) { printf("The data is not valid.\n"); } } while (val == 0); return data; } I think I need to get it by reference but I'm trying for some time already and can't do it. Thanks everyone.
While it's legal C, passing structs by value and returning them is usually not the best way. Consider: void readData(typeData *data) { int val; do { printf("Day: "); data->day = readInteger(MIN_DAYS, MAX_DAYS); printf("Month: "); data->month = readInteger(MIN_MONTH, MAX_MONTH); printf("Year: "); data->year = readInteger(MIN_YEAR, MAX_YEAR); val = validateData(data); if (val == 0) { printf("The data is not valid.\n"); } } while (val == 0); } UPDATE: Here is a sample main program plus sample changes to validateData: int validateData(typeData *data) { int data_valid = 1; // check for error // this is whatever checks you already do ... if (data->... != ...) data_valid = 0; return data_valid; } int main(int argc,char **argv) { typeData main_data; readData(&main_data); // do something useful with the data [or transform it, etc] processData(&main_data); // print some results printData(&main_data); return 0; } UPDATE #2: Here's a modified [partial] program, based on your latest example. I had to guess at the overall organization, but, at least it has the necessary changes to menuPrincipal: int validateData(typeData *data) { int data_valid = 1; // check for error // this is whatever checks you already do ... if (data->... != ...) data_valid = 0; return data_valid; } char menuPrincipal(typeDate *date) { char option; if (date->day == 0 && date->month == 0 && data->year == 0) { printf("Date not set yet.\n"); } else { printf("Date: %d/%d/%d", date->day, date->month, date->year); } // more stuff return option; } int main(int argc,char **argv) { typeData main_data; char option; while (1) { readData(&main_data); option = menuPrincipal(&main_data); switch (option) { case 'a': // do something break; case 'b': // do something else break; default: printf("unknown option: '%c'\n",option); break; } } return 0; } UPDATE #3: Based on your latest comment, I think I see what you're having trouble with. I've taken your latest code snippet and updated: // your original code -- this no longer works because readData is now void if (data->ano == 0 && data->mes == 0 && data->dia == 0) { Blah[*Bleh].date = readData(*data); } // one possibility -- but it does _not_ update "data" if (data->ano == 0 && data->mes == 0 && data->dia == 0) { readData(&Blah[*Bleh].date); } // this is more likely what you want -- it updates _both_: if (data->ano == 0 && data->mes == 0 && data->dia == 0) { readData(data); Blah[*Bleh].date = *data; }
It works now, I was using val = validateDate(&date) on the original function for readData, now I changed it to val = validateDate(date) and it works! I just don't know why I need to use date instead of &date, I thought that if I was passing the parameters by reference I needed a '&' symbol.
Printing an array of structs in C
I'm trying to print an array of structs that contain two strings. However my print function does not print more than two indices of the array. I am not sure why because it seems to me that the logic is correct. This is the main function const int MAX_LENGTH = 1024; typedef struct song { char songName[MAX_LENGTH]; char artist[MAX_LENGTH]; } Song; void getStringFromUserInput(char s[], int maxStrLength); void printMusicLibrary(Song library[], int librarySize); void printMusicLibraryTitle(void); void printMusicLibrary (Song library[], int librarySize); void printMusicLibraryEmpty(void); int main(void) { // Announce the start of the program printf("%s", "Personal Music Library.\n\n"); printf("%s", "Commands are I (insert), S (sort by artist),\n" "P (print), Q (quit).\n"); char response; char input[MAX_LENGTH + 1]; int index = 0; do { printf("\nCommand?: "); getStringFromUserInput(input, MAX_LENGTH); // Response is the first character entered by user. // Convert to uppercase to simplify later comparisons. response = toupper(input[0]); const int MAX_LIBRARY_SIZE = 100; Song Library[MAX_LIBRARY_SIZE]; if (response == 'I') { printf("Song name: "); getStringFromUserInput(Library[index].songName, MAX_LENGTH); printf("Artist: "); getStringFromUserInput(Library[index].artist, MAX_LENGTH); index++; } else if (response == 'P') { // Print the music library. int firstIndex = 0; if (Library[firstIndex].songName[firstIndex] == '\0') { printMusicLibraryEmpty(); } else { printMusicLibraryTitle(); printMusicLibrary(Library, MAX_LIBRARY_SIZE); } This is my printing the library function // This function will print the music library void printMusicLibrary (Song library[], int librarySize) { printf("\n"); bool empty = true; for (int i = 0; (i < librarySize) && (!empty); i ++) { empty = false; if (library[i].songName[i] != '\0') { printf("%s\n", library[i].songName); printf("%s\n", library[i].artist); printf("\n"); } else { empty = true; } } }
I think the problem is caused due to setting : empty = true outside the for loop and then checking (!empty) which will evaluate to false. What I am surprised by is how is it printing even two indices. You should set empty = false as you are already checking for the first index before the function call.
The logic has two ways to terminate the listing: 1) if the number of entries is reached, or 2) if any entry is empty. I expect the second condition is stopping the listing before you expect. Probably the array wasn't built as expected (I didn't look at that part), or something is overwriting an early or middle entry.
you gave the definition as: typedef struct song { char songName[MAX_LENGTH]; char artist[MAX_LENGTH]; }Song; the later, you write if (library[i].songName[i] != '\0') which really seems strange: why would you index the songname string with the same index that the lib? so I would naturally expect your print function to be: // This function will print the music library void printMusicLibrary (Song library[], int librarySize) { for (int i = 0; i < librarySize; i ++) { printf("%s\n%s\n\n", library[i].songName, library[i].artist); } } note that you may skip empty song names by testing library[i].songName[0] != '\0' (pay attention to the 0), but I think it would be better not to add them in the list (does an empty song name make sens?) (If you decide to fix that, note that you have an other fishy place: if (Library[firstIndex].songName[firstIndex] == '\0') with the same pattern)
Parsing code for GPS NMEA string
i am trying to parse the incoming GPGGA NMEA GPS string using Arduino uno and below code. What i am trying to do is that i am using only GPGGA NMEA string to get the values of Latitude, longitude and altitude.In my below code, i had put certain checks to check if incoming string is GPGGA or not, and then store the further string in a array which can be further parsed suing strtok function and all the 3 GPS coordinates can be easily find out. But i am unable to figure out how to store only GPGGA string and not the further string.I am using a for loop but it isn't working. I am not trying to use any library.I had came across certain existing codes like this. Here is the GPGGA string information link i am trying to have following functionlity i) Check if incoming string is GPGGA ii) If yes, then store the following string upto EOL or upto * (followed by checksum for the array) in a array, array length is variable(i am unable to find out solution for this) iii) Then parse the stored array(this is done, i tried this with a different array) #include <SoftwareSerial.h> SoftwareSerial mySerial(10,11); // 10 RX / 11 TX void setup() { Serial.begin(9600); mySerial.begin(9600); } void loop() { uint8_t x; char gpsdata[65]; if((mySerial.available())) { char c = mySerial.read(); if(c == '$') {char c1 = mySerial.read(); if(c1 == 'G') {char c2 = mySerial.read(); if(c2 == 'P') {char c3 = mySerial.read(); if(c3 == 'G') {char c4 = mySerial.read(); if(c4 == 'G') {char c5 = mySerial.read(); if(c5 == 'A') {for(x=0;x<65;x++) { gpsdata[x]=mySerial.read(); while (gpsdata[x] == '\r' || gpsdata[x] == '\n') { break; } } } else{ Serial.println("Not a GPGGA string"); } } } } } } } Serial.println(gpsdata); } Edit 1: Considering Joachim Pileborg, editing the for loop in the code. I am adding a pic to show the undefined output of the code. Input for the code: $GPGGA,092750.000,5321.6802,N,00630.3372,W,1,8,1.03,61.7,M,55.2,M,,*76 $GPGSA,A,3,10,07,05,02,29,04,08,13,,,,,1.72,1.03,1.38*0A $GPGSV,3,1,11,10,63,137,17,07,61,098,15,05,59,290,20,08,54,157,30*70 $GPGSV,3,2,11,02,39,223,19,13,28,070,17,26,23,252,,04,14,186,14*79 $GPGSV,3,3,11,29,09,301,24,16,09,020,,36,,,*76 $GPRMC,092750.000,A,5321.6802,N,00630.3372,W,0.02,31.66,280511,,,A*43 $GPGGA,092751.000,5321.6802,N,00630.3371,W,1,8,1.03,61.7,M,55.3,M,,*75 $GPGSA,A,3,10,07,05,02,29,04,08,13,,,,,1.72,1.03,1.38*0A $GPGSV,3,1,11,10,63,137,17,07,61,098,15,05,59,290,20,08,54,157,30*70 $GPGSV,3,2,11,02,39,223,16,13,28,070,17,26,23,252,,04,14,186,15*77 $GPGSV,3,3,11,29,09,301,24,16,09,020,,36,,,*76 $GPRMC,092751.000,A,5321.6802,N,00630.3371,W,0.06,31.66,280511,,,A*45
After a quick check of the linked article on the NMEA 0183 protocol, this jumped out at me: <CR><LF> ends the message. This means, that instead of just read indiscriminately from the serial port, you should be looking for that sequence. If found, you should terminate the string, and break out of the loop. Also, you might want to zero-initialize the data string to begin with, to easily see if there actually is any data in it to print (using e.g. strlen).
You could use some functions from the C library libnmea. Theres functions to split a sentence into values by comma and then parse them.
Offering this as a suggestion in support of what you are doing... Would it not be useful to replace all of the nested if()s in your loop with something like: EDIT added global string to copy myString into once captured char globalString[100];//declare a global sufficiently large to hold you results void loop() { int chars = mySerial.available(); int i; char *myString; if (chars>0) { myString = calloc(chars+1, sizeof(char)); for(i=0;i<chars;i++) { myString[i] = mySerial.read(); //test for EOF if((myString[i] == '\n') ||(myString[i] == '\r')) { //pick this... myString[i]=0;//strip carriage - return line feed(or skip) //OR pick this... (one or the other. i.e.,I do not know the requirements for your string) if(i<chars) { myString[i+1] = mySerial.read() //get remaining '\r' or '\n' myString[i+2]=0;//add null term if necessary } break; } } if(strstr(myString, "GPGGA") == NULL) { Serial.println("Not a GPGGA string"); //EDIT strcpy(globalString, "");//if failed, do not want globalString populated } else { //EDIT strcpy(globalString, myString); } } //free(myString) //somewhere when you are done with it } Now, the return value from mySerial.available() tells you exactly how many bytes to read, you can read the entire buffer, and test for validity all in one.
I have a project that will need to pull the same information out of the same sentence. I got this out of a log file import serial import time ser = serial.Serial(1) ser.read(1) read_val = ("nothing") gpsfile="gpscord.dat" l=0 megabuffer='' def buffThis(s): global megabuffer megabuffer +=s def buffLines(): global megabuffer megalist=megabuffer.splitlines() megabuffer=megalist.pop() return megalist def readcom(): ser.write("ati") time.sleep(3) read_val = ser.read(size=500) lines=read_val.split('\n') for l in lines: if l.startswith("$GPGGA"): if l[:len(l)-3].endswith("*"): outfile=open('gps.dat','w') outfile.write(l.rstrip()) outfile.close() readcom() while 1==1: readcom() answer=raw_input('not looping , CTRL+C to abort') The result is this: gps.dat $GPGGA,225714.656,5021.0474,N,00412.4420,W,0,00,50.0,0.0,M,18.0,M,0.0,0000*5B
Using "malloc" every single time you read a string is an enormous amount of computational overhead. (And didn't see the corresponding free() function call. Without that, you never get that memory back until program termination or system runs out of memory.) Just pick the size of the longest string you will ever need, add 10 to it, and declare that your string array size. Set once and done. There are several C functions for getting substrings out of a string, strtok() using the coma is probably the least overhead. You are on an embedded microcontroller. Keep it small, keep overhead down. :)
#include <stdio.h> #include <string.h> #define GNSS_HEADER_LENGTH 5 #define GNSS_PACKET_START '$' #define GNSS_TOKEN_SEPARATOR ',' #define bool int #define FALSE 0 #define TRUE 1 //To trim a string contains \r\n void str_trim(char *str){ while(*str){ if(*str == '\r' || *str == '\n'){ *str = '\0'; } str++; } } /** * To parse GNSS data by header and the index separated by comma * * $GPGSV,1,1,03,23,39,328,30,18,39,008,27,15,33,035,33,1*5A * $GNRMC,170412.000,V,,,,,,,240322,,,N,V*2D * $GNGGA,170412.000,,,,,0,0,,,M,,M,,*57 * * #data_ptr the pointer points to gps data * #header the header for parsing GPGSV * #repeat_index the header may repeat for many lines * so the header index is for identifying repeated header * #token_index is the index of the parsing data separated by "," * the start is 1 * #result to store the result of the parser input * * #result bool - parsed successfully **/ bool parse_gnss_token(char *data_ptr, char *header, int repeat_index, int token_index, char *result) { bool gnss_parsed_result = FALSE; // To check GNSS data parsing is success bool on_header = FALSE; // For header int header_repeat_counter = 0; int header_char_index = 0; // each char in header index // For counting comma int counted_token_index = 0; // To hold the result character index bool data_found = FALSE; char *result_start = result; char header_found[10]; while (*data_ptr) { // 1. Packet start if (*data_ptr == GNSS_PACKET_START) { on_header = TRUE; header_char_index = 0; // to index each character in header data_found = FALSE; // is data part found data_ptr++; } // 2. For header parsing if (on_header) { if (*data_ptr == GNSS_TOKEN_SEPARATOR || header_char_index >= GNSS_HEADER_LENGTH) { on_header = FALSE; } else { header_found[header_char_index] = *data_ptr; if (header_char_index == GNSS_HEADER_LENGTH - 1) { // Now Header found header_found[header_char_index + 1] = '\0'; on_header = FALSE; if (!strcmp(header, header_found)) { // Some headers may repeat - to identify it set the repeat index if (header_repeat_counter == repeat_index) { //printf("Header: %s\r\n", header_found ); data_found = TRUE; } header_repeat_counter++; } } header_char_index++; } } // 3. data found if (data_found) { // To get the index data separated by comma if (counted_token_index == token_index && *data_ptr != GNSS_TOKEN_SEPARATOR) { // the data to parse *result++ = *data_ptr; gnss_parsed_result = TRUE; } if (*data_ptr == GNSS_TOKEN_SEPARATOR) { // if , counted_token_index++; // The comma counter for index } // Break if the counted_token_index(token_counter) greater than token_index(search_token) if (counted_token_index > token_index) { break; } } // Appending \0 to the end *result = '\0'; // To trim the data if ends with \r or \n str_trim(result_start); // Input data data_ptr++; } return gnss_parsed_result; } int main() { char res[100]; char *nem = "\ $GNRMC,080817.000,A,0852.089246,N,07636.289920,E,0.00,139.61,270322,,,A,V*04\r\n\\r\n\ $GNGGA,080817.000,0852.089246,N,07636.289920,E,1,5,1.41,11.246,M,-93.835,M,,*5E\r\n\ $GNVTG,139.61,T,,M,0.00,N,0.00,K,A*2F\r\n\ $GNGSA,A,3,30,19,17,14,13,,,,,,,,1.72,1.41,0.98,1*0A\r\n\ $GNGSA,A,3,,,,,,,,,,,,,1.72,1.41,0.98,3*02\r\n\ $GNGSA,A,3,,,,,,,,,,,,,1.72,1.41,0.98,6*07\r\n\ $GPGSV,3,1,12,06,64,177,,30,60,138,15,19,51,322,18,17,42,356,27,1*68\r\n\ $GPGSV,3,2,12,14,36,033,17,07,34,142,17,13,32,267,17,02,21,208,,1*6C\r\n\ $GPGSV,3,3,12,15,05,286,,01,05,037,,03,03,083,,20,02,208,,1*6B\r\n\ $GAGSV,1,1,00,7*73\r\n\ $GIGSV,1,1,00,1*7D\r\n\ $GNGLL,0852.089246,N,07636.289920,E,080817.000,A,A*43\r\n\ $PQTMANTENNASTATUS,1,0,1*4F\r\n"; printf("Parsing GNRMC\r\n"); printf("===============\r\n"); for(int i=1;i<=16;i++){ parse_gnss_token(nem, "GNRMC", 0, i, res); printf("Index: %d, Result: %s\r\n", i, res); } printf("Parsing GNVTG (First Parameter)\r\n"); printf("================================"); // GNVTG - Header, 0 - Repeat Index(if header is repeating), 1 - Value Index, parse_gnss_token(nem, "GNVTG", 0, 1, res); printf("\r\nGNVTG: %s\r\n", res); return 0; }
Refactoring simple card counting function into multiple functions?
I'm just starting to learn C from Head First C, but I'm having difficulty understanding how refactor my code into multiple functions, more specifically, I don't know how to get functions to work and am confused how to take user input. How would I incorporate a function like the one below into the main function? What are some other function examples I could use to refactor? Thank you so much! void get_card_name(char *prompt, char *card_name) Main function int main() { char card_name[3]; int count = 0; while ( card_name[0] != 'X' ) { puts("Enter the card_name: "); scanf("%2s", card_name); int val = 0; switch(card_name[0]) { case 'K': case 'Q': case 'J': val = 10; break; case 'A': val = 11; break; case 'X': continue; default: val = atoi(card_name); if ((val < 1) || (val > 10)) { puts("I dont understand that value!"); continue; } } if ((val > 2) && (val < 7)) { count++; } else if (val == 10) { count--; } printf("Current count: %i\n", count); } return 0; }
The generic answer when it comes to refactoring is "If it looks complicated or hard to read, try to break it down into smaller pieces that are easier to read (and understand).". In your case you have this: int main() { /* Initial state needed later on */ /* Do some complicated stuff */ } To refactor this, you need to find out what parts of the initial state you need to keep close to whatever you are going to move away into its own function. In your example, card_name and count are both used inside the complicated bit, and nowhere else. So you can, and should, keep those close the complicated bits: void do_card_stuff() { char card_name[3]; int count = 0; /* Do some complicated stuff */ } int main() { do_card_stuff(); } And, lo and behold, you've refactored your code. If you still think that the card stuff looks complicated, try to break it up into more pieces: int get_card_value(char card) { /* Do some complicated stuff */ return value; } int do_card_stuff() { char card_name[3]; int count = 0; int value; /* Loop */ /* Get card value from user */ value = get_card_value(card_name[0]); } int main() { do_card_stuff(); } Just keep at it until it's just silly to break it into smaller bits and you're done. Also, try to keep in mind that the code you break out should be as generic as possible since this will let you re-use this code later on (potentially in other projects).