How to send request on click React Hooks way? - reactjs
How to send http request on button click with react hooks? Or, for that matter, how to do any side effect on button click?
What i see so far is to have something "indirect" like:
export default = () => {
const [sendRequest, setSendRequest] = useState(false);
useEffect(() => {
if(sendRequest){
//send the request
setSendRequest(false);
}
},
[sendRequest]);
return (
<input type="button" disabled={sendRequest} onClick={() => setSendRequest(true)}
);
}
Is that the proper way or is there some other pattern?
export default () => {
const [isSending, setIsSending] = useState(false)
const sendRequest = useCallback(async () => {
// don't send again while we are sending
if (isSending) return
// update state
setIsSending(true)
// send the actual request
await API.sendRequest()
// once the request is sent, update state again
setIsSending(false)
}, [isSending]) // update the callback if the state changes
return (
<input type="button" disabled={isSending} onClick={sendRequest} />
)
}
this is what it would boil down to when you want to send a request on click and disabling the button while it is sending
update:
#tkd_aj pointed out that this might give a warning: "Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function."
Effectively, what happens is that the request is still processing, while in the meantime your component unmounts. It then tries to setIsSending (a setState) on an unmounted component.
export default () => {
const [isSending, setIsSending] = useState(false)
const isMounted = useRef(true)
// set isMounted to false when we unmount the component
useEffect(() => {
return () => {
isMounted.current = false
}
}, [])
const sendRequest = useCallback(async () => {
// don't send again while we are sending
if (isSending) return
// update state
setIsSending(true)
// send the actual request
await API.sendRequest()
// once the request is sent, update state again
if (isMounted.current) // only update if we are still mounted
setIsSending(false)
}, [isSending]) // update the callback if the state changes
return (
<input type="button" disabled={isSending} onClick={sendRequest} />
)
}
You don't need an effect to send a request on button click, instead what you need is just a handler method which you can optimise using useCallback method
const App = (props) => {
//define you app state here
const fetchRequest = useCallback(() => {
// Api request here
}, [add dependent variables here]);
return (
<input type="button" disabled={sendRequest} onClick={fetchRequest}
);
}
Tracking request using variable with useEffect is not a correct pattern because you may set state to call api using useEffect, but an additional render due to some other change will cause the request to go in a loop
In functional programming, any async function should be considered as a side effect.
When dealing with side effects you need to separate the logic of starting the side effect and the logic of the result of that side effect (similar to redux saga).
Basically, the button responsibility is only triggering the side effect, and the side effect responsibility is to update the dom.
Also since react is dealing with components you need to make sure your component still mounted before any setState or after every await this depends on your own preferences.
to solve this issue we can create a custom hook useIsMounted this hook will make it easy for us to check if the component is still mounted
/**
* check if the component still mounted
*/
export const useIsMounted = () => {
const mountedRef = useRef(false);
const isMounted = useCallback(() => mountedRef.current, []);
useEffect(() => {
mountedRef.current = true;
return () => {
mountedRef.current = false;
};
});
return isMounted;
};
Then your code should look like this
export const MyComponent = ()=> {
const isMounted = useIsMounted();
const [isDoMyAsyncThing, setIsDoMyAsyncThing] = useState(false);
// do my async thing
const doMyAsyncThing = useCallback(async () => {
// do my stuff
},[])
/**
* do my async thing effect
*/
useEffect(() => {
if (isDoMyAsyncThing) {
const effect = async () => {
await doMyAsyncThing();
if (!isMounted()) return;
setIsDoMyAsyncThing(false);
};
effect();
}
}, [isDoMyAsyncThing, isMounted, doMyAsyncThing]);
return (
<div>
<button disabled={isDoMyAsyncThing} onClick={()=> setIsDoMyAsyncThing(true)}>
Do My Thing {isDoMyAsyncThing && "Loading..."}
</button>;
</div>
)
}
Note: It's always better to separate the logic of your side effect from the logic that triggers the effect (the useEffect)
UPDATE:
Instead of all the above complexity just use useAsync and useAsyncFn from the react-use library, It's much cleaner and straightforward.
Example:
import {useAsyncFn} from 'react-use';
const Demo = ({url}) => {
const [state, doFetch] = useAsyncFn(async () => {
const response = await fetch(url);
const result = await response.text();
return result
}, [url]);
return (
<div>
{state.loading
? <div>Loading...</div>
: state.error
? <div>Error: {state.error.message}</div>
: <div>Value: {state.value}</div>
}
<button onClick={() => doFetch()}>Start loading</button>
</div>
);
};
You can fetch data as an effect of some state changing like you have done in your question, but you can also get the data directly in the click handler like you are used to in a class component.
Example
const { useState } = React;
function getData() {
return new Promise(resolve => setTimeout(() => resolve(Math.random()), 1000))
}
function App() {
const [data, setData] = useState(0)
function onClick() {
getData().then(setData)
}
return (
<div>
<button onClick={onClick}>Get data</button>
<div>{data}</div>
</div>
);
}
ReactDOM.render(<App />, document.getElementById("root"));
<script src="https://unpkg.com/react#16/umd/react.development.js" crossorigin></script>
<script src="https://unpkg.com/react-dom#16/umd/react-dom.development.js" crossorigin></script>
<div id="root"></div>
You can define the boolean in the state as you did and once you trigger the request set it to true and when you receive the response set it back to false:
const [requestSent, setRequestSent] = useState(false);
const sendRequest = () => {
setRequestSent(true);
fetch().then(() => setRequestSent(false));
};
Working example
You can create a custom hook useApi and return a function execute which when called will invoke the api (typically through some onClick).
useApi hook:
export type ApiMethod = "GET" | "POST";
export type ApiState = "idle" | "loading" | "done";
const fetcher = async (
url: string,
method: ApiMethod,
payload?: string
): Promise<any> => {
const requestHeaders = new Headers();
requestHeaders.set("Content-Type", "application/json");
console.log("fetching data...");
const res = await fetch(url, {
body: payload ? JSON.stringify(payload) : undefined,
headers: requestHeaders,
method,
});
const resobj = await res.json();
return resobj;
};
export function useApi(
url: string,
method: ApiMethod,
payload?: any
): {
apiState: ApiState;
data: unknown;
execute: () => void;
} {
const [apiState, setApiState] = useState<ApiState>("idle");
const [data, setData] = useState<unknown>(null);
const [toCallApi, setApiExecution] = useState(false);
const execute = () => {
console.log("executing now");
setApiExecution(true);
};
const fetchApi = useCallback(() => {
console.log("fetchApi called");
fetcher(url, method, payload)
.then((res) => {
const data = res.data;
setData({ ...data });
return;
})
.catch((e: Error) => {
setData(null);
console.log(e.message);
})
.finally(() => {
setApiState("done");
});
}, [method, payload, url]);
// call api
useEffect(() => {
if (toCallApi && apiState === "idle") {
console.log("calling api");
setApiState("loading");
fetchApi();
}
}, [apiState, fetchApi, toCallApi]);
return {
apiState,
data,
execute,
};
}
using useApi in some component:
const SomeComponent = () =>{
const { apiState, data, execute } = useApi(
"api/url",
"POST",
{
foo: "bar",
}
);
}
if (apiState == "done") {
console.log("execution complete",data);
}
return (
<button
onClick={() => {
execute();
}}>
Click me
</button>
);
For this you can use callback hook in ReactJS and it is the best option for this purpose as useEffect is not a correct pattern because may be you set state to make an api call using useEffect, but an additional render due to some other change will cause the request to go in a loop.
<const Component= (props) => {
//define you app state here
const getRequest = useCallback(() => {
// Api request here
}, [dependency]);
return (
<input type="button" disabled={sendRequest} onClick={getRequest}
);
}
My answer is simple, while using the useState hook the javascript doesn't enable you to pass the value if you set the state as false. It accepts the value when it is set to true. So you have to define a function with if condition if you use false in the usestate
Related
React prevent re render
How should I prevent a re render when I click on onClose to close the modal. It looks like the dispatch function: dispatch(setActiveStep(0) cause some troubles. export default function ImportOrderModal(props: ImportOrderModalProps) { const { open, onClose } = props const { orderImport: { activeStep } } = useAppSelector((state: RootState) => state) const steps = useImportOrderConfig() const dispatch = useDispatch() React.useEffect(() => { getOrdersList() }, []) const onCloseModal = () => { onClose() // Force a re render because of activeStep value dispatch(setActiveStep(0)) } const getOrdersList = async () => { const orders = //API call dispatch(setOrdersList(orders)) } return ( <Modal open={open} onClose={onCloseModal}> <Stepper steps={steps} currentStepNumber={activeStep} /> <FormSteps /> </Modal> ) }
This block is outside of your useEffect() const getOrdersList = async () => { const orders = //API call dispatch(setOrdersList(orders)) } This will cause rendering troubles. if you're using an older version of React (<17) that doesn't enforce <React.StrictMode> you can get away with rewriting that as: useEffect(() => { getOrderList .then((orders) => dispatch(setOrdersList(orders)) .catch((error) => console.error(error)); }, [dispatch]); if you're using a newer version of React (>18) you will have to cleanup your asynchronous call in the cleanup function of your useEffect(). useEffect(() => { // This has to be passed down to your fetch/axios call const controller = new AbortController(); getOrderList(controller) .then((orders) => dispatch(setOrdersList(orders)) .catch((error) => console.error(error)); return () => { // This will abort any ongoing async call controller.abort(); } }, [dispatch]); For this to make sense I will probably have to write an example of the api call for you as well, if you don't mind I'll use axios for the example but it essentially works the same-ish with .fetch. const getOrderList = async (controller) => { try { const { data } = await axios.get("url", { signal: controller.signal }); return data.orders; } catch (e) { throw e; } }
How to make function with a few setStates in it synchronous?
I need to make a button click handler which have a few other function calls in it. One of them is a onAccept function which has a few setStates in it and want to wait until them all is done. Is there a way to make onAccept synchronous? button click handler const onUpdateBoundaries = async (recommendation) => { await getSnippetIndex( //some props ).then(response => { onAccept({...recommendation, index: response}); }); fetchRecommendations() //<- this function shouldn't be called until onAccept's setStates are done }; onAccept const onAccept = (recommendation) => { setAccepted((accepted) => [ ...new Set([...accepted, ...recommendation.cluster_indices.map(recommendation => recommendation.index)]), ]); setRejected((rejected) => [ ...new Set(removeFromArray(rejected, recommendation.cluster_indices.map(recommendation => recommendation.index))) ]); }; fetchRecommendations const fetchRecommendations = async () => { try { const {//some props propagated_accepted, propagated_rejected, } = await getRecommendations( //some props ); setAccepted((accepted) => [...accepted, ...propagated_accepted]); setRejected((rejected) => [...rejected, ...propagated_rejected]); } catch (err) { //handling } setIsWaitingForRecommendations(false); };
You can try with useEffect and useRef to achieve it //track all previous values before state updates const previousValues = useRef({ rejected, accepted }); useEffect(() => { //only call `fetchRecommendations` once both `rejected` and `accepted` get updated if(previousValues.current.rejected !== rejected && previousValues.current.accepted !== accepted) { fetchRecommendations() } }, [rejected, accepted]) Another easier way that you can try setState, which is the old-school function with callback (the problem with this solution is you need to use class component - NOT function component) const onAccept = (recommendation) => { setState((prevState) => ({ accepted: [ ...new Set([...prevState.accepted, ...recommendation.cluster_indices.map(recommendation => recommendation.index)]), ], rejected: [ ...new Set(removeFromArray(prevState.rejected, recommendation.cluster_indices.map(recommendation => recommendation.index))) ] }), () => { //callback here fetchRecommendations() }) }
React is declarative, which means it will control the setState function calls incl. batching them if necessary to optimise performance. What you can do is make use of a useEffect to listen for changes in state and run code you need to run after state change there. For eg: ( I'm assuming your two states are accepted and rejected) useEffect(() => { fetchRecommendations() //<- gets called everytime accepted or rejected changes }, [accepted, rejected]) // onAccept remains the same //button click handler const onUpdateBoundaries = async (recommendation) => { const response = await getSnippetIndex( //some props ) onAccept({...recommendation, index: response}); }; If you want to run it only if current values of accepted or rejected has changed, you can make use of use Ref to store the previous values of accepted and rejected. You can create a custom hook like function usePrevious(value) { const ref = useRef(); useEffect(() => { ref.current = value; }); return ref.current; } Then // import usePrevious hook const prevAccepted = usePrevious(accepted) const prevRejected = usePrevious(rejected) useEffect(() => { if(prevAccepted!=accepted && prevRejected!=rejected) fetchRecommendations() //<- gets called everytime accepted or rejected changes }, [accepted, rejected]) const onUpdateBoundaries = async (recommendation) => { const response = await getSnippetIndex( //some props ) onAccept({...recommendation, index: response}); }; Think something like this would do the trick. Let me know if this works :)
you can make a async method like this const SampleOfPromise = () => { onClick=async()=>{ await myPromise(); } const myPromise = new Promise((resolve, reject) => { setTimeout(() => { resolve('sample'); }, 300); }); return( <Button onClick={onClick}> </Button> ) }
React async event handler. The safe way
Imagine a simple react component const Upload: React.FC = () => { const [done, setDone] = useState(false) const upload = async () => { await doSomeAsyncStuffHere() setDone(true) } if(done) { return <div>success</div> } return ( <button onClick={upload}>upload</button> ) } It looks fine at first glance. But what if upload function takes a long time to finish? What if user navigates to another view and the component gets unmounted? When the async task finishes will cause a state update on an unmounted component. This is a no-op and a possible memory leak. What should I do to prevent it?
One way of going about it is to create a ref that you set to false when the component is unmounted, and check against this before setting the result of your asynchronous code in the component state. Example const Upload: React.FC = () => { const isMounted = useRef(true); const [done, setDone] = useState(false) const upload = async () => { await doSomeAsyncStuffHere() if (isMounted.current) { setDone(true) } } useEffect(() => { return () => { isMounted.current = false; }; }, []); if(done) { return <div>success</div> } return ( <button onClick={upload}>upload</button> ) }
Warning in useEffect function even though i am not using it in my screen
I am getting a warning message when i login. if i comment setIsLoading(true) then its working. I guess my state is getting updated before the component is mounted. I dont use useEffect function here, its just direct button click. how do i clean up my warning? Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function const SignInScreen = () => { const [isLoading, setIsLoading] = useState(false); const authHandler = async () => { setIsLoading(true); await dispatch(AuthReducer.signIn(uname, pwd)); setIsLoading(false); }; }; JSX, return ( {isLoading ? ( <ActivityIndicator size="small"/> ) : ( <TouchableOpacity onPress={authHandler}> Login </TouchableOpacity> )} ); Action method, export const signIn = (username, password) => async (dispatch) => { try { const response1 = await axios.post("/Mobile/mlogin", {uname,pwd}); const response2 = await axios.post("...............); const response3 = await axios.get(...............); catch(err) {} };
You should clean - what they call - subscriptions. In your case that would be something like that: useEffect(() => { let mounted = true const authHandler = async () => { if (mounted) { setIsLoading(true) await dispatch(AuthReducer.signIn(uname, pwd)) setIsLoading(false) } } authHandler() return () => mounted = false; }, []); Read here for reference: https://www.debuggr.io/react-update-unmounted-component/#:~:text=Warning%3A%20Can't%20perform%20a,in%20a%20useEffect%20cleanup%20function.
React-hooks. Can't perform a React state update on an unmounted component
I get this error: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function. when fetching of data is started and component was unmounted, but function is trying to update state of unmounted component. What is the best way to solve this? CodePen example. default function Test() { const [notSeenAmount, setNotSeenAmount] = useState(false) useEffect(() => { let timer = setInterval(updateNotSeenAmount, 2000) return () => clearInterval(timer) }, []) async function updateNotSeenAmount() { let data // here i fetch data setNotSeenAmount(data) // here is problem. If component was unmounted, i get error. } async function anotherFunction() { updateNotSeenAmount() //it can trigger update too } return <button onClick={updateNotSeenAmount}>Push me</button> //update can be triggered manually }
The easiest solution is to use a local variable that keeps track of whether the component is mounted or not. This is a common pattern with the class based approach. Here is an example that implement it with hooks: function Example() { const [text, setText] = React.useState("waiting..."); React.useEffect(() => { let isCancelled = false; simulateSlowNetworkRequest().then(() => { if (!isCancelled) { setText("done!"); } }); return () => { isCancelled = true; }; }, []); return <h2>{text}</h2>; } Here is an alternative with useRef (see below). Note that with a list of dependencies this solution won't work. The value of the ref will stay true after the first render. In that case the first solution is more appropriate. function Example() { const isCancelled = React.useRef(false); const [text, setText] = React.useState("waiting..."); React.useEffect(() => { fetch(); return () => { isCancelled.current = true; }; }, []); function fetch() { simulateSlowNetworkRequest().then(() => { if (!isCancelled.current) { setText("done!"); } }); } return <h2>{text}</h2>; } You can find more information about this pattern inside this article. Here is an issue inside the React project on GitHub that showcase this solution.
If you are fetching data from axios(using hooks) and the error still occurs, just wrap the setter inside the condition let isRendered = useRef(false); useEffect(() => { isRendered = true; axios .get("/sample/api") .then(res => { if (isRendered) { setState(res.data); } return null; }) .catch(err => console.log(err)); return () => { isRendered = false; }; }, []);
TL;DR Here is a CodeSandBox example The other answers work of course, I just wanted to share a solution I came up with. I built this hook that works just like React's useState, but will only setState if the component is mounted. I find it more elegant because you don't have to mess arround with an isMounted variable in your component ! Installation : npm install use-state-if-mounted Usage : const [count, setCount] = useStateIfMounted(0); You can find more advanced documentation on the npm page of the hook.
Here is a simple solution for this. This warning is due to when we do some fetch request while that request is in the background (because some requests take some time.)and we navigate back from that screen then react cannot update the state. here is the example code for this. write this line before every state Update. if(!isScreenMounted.current) return; Here is Complete Example import React , {useRef} from 'react' import { Text,StatusBar,SafeAreaView,ScrollView, StyleSheet } from 'react-native' import BASEURL from '../constants/BaseURL'; const SearchScreen = () => { const isScreenMounted = useRef(true) useEffect(() => { return () => isScreenMounted.current = false },[]) const ConvertFileSubmit = () => { if(!isScreenMounted.current) return; setUpLoading(true) var formdata = new FormData(); var file = { uri: `file://${route.params.selectedfiles[0].uri}`, type:`${route.params.selectedfiles[0].minetype}`, name:`${route.params.selectedfiles[0].displayname}`, }; formdata.append("file",file); fetch(`${BASEURL}/UploadFile`, { method: 'POST', body: formdata, redirect: 'manual' }).then(response => response.json()) .then(result => { if(!isScreenMounted.current) return; setUpLoading(false) }).catch(error => { console.log('error', error) }); } return( <> <StatusBar barStyle="dark-content" /> <SafeAreaView> <ScrollView contentInsetAdjustmentBehavior="automatic" style={styles.scrollView}> <Text>Search Screen</Text> </ScrollView> </SafeAreaView> </> ) } export default SearchScreen; const styles = StyleSheet.create({ scrollView: { backgroundColor:"red", }, container:{ flex:1, justifyContent:"center", alignItems:"center" } })
This answer is not related to the specific question but I got the same Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function. and as a React newcomer could not find a solution to it. My problem was related to useState in an unmounted component. I noticed that I was calling a set state function (setIsLoading) after the function that unmounted my component: const Login = () => { const [isLoading, setIsLoading] = useState(false); const handleLogin = () => { setIsLoading(true); firebase.auth().then( functionToUnMountLoginSection(); // the problem is here setIsLoading(false); ) } } The correct way is to call setIsLoading when the component is still mounted, before calling the function to unmount/process user login in my specific case: firebase.auth().then( setIsLoading(false); functionToUnMountLoginSection(); )
You add the state related datas into the useEffect body for not rerunning them every rerendering process. This method will solve the problem. useEffect(() => { let timer = setInterval(updateNotSeenAmount, 2000) return () => clearInterval(timer) }, [notSeenAmount]) REF: Tip: Optimizing Performance by Skipping Effects
Custom Hook Solution (ReactJs/NextJs) Create a new folder named 'shared' and add two folders named 'hooks', 'utils' in it. Add a new file called 'commonFunctions.js' inside utils folder and add the code snippet below. export const promisify = (fn) => { return new Promise((resolve, reject) => { fn .then(response => resolve(response)) .catch(error => reject(error)); }); }; Add a new file called 'fetch-hook.js' inside hooks folder and add the code snippet below. import { useCallback, useEffect, useRef } from "react"; import { promisify } from "../utils/commonFunctions"; export const useFetch = () => { const isUnmounted = useRef(false); useEffect(() => { isUnmounted.current = false; return () => { isUnmounted.current = true; }; }, []); const call = useCallback((fn, onSuccess, onError = null) => { promisify(fn).then(response => { console.group('useFetch Hook response', response); if (!isUnmounted.current) { console.log('updating state..'); onSuccess(response.data); } else console.log('aborted state update!'); console.groupEnd(); }).catch(error => { console.log("useFetch Hook error", error); if (!isUnmounted.current) if (onError) onError(error); }); }, []); return { call } }; Folder Structure Our custom hook is now ready. We use it in our component like below const OurComponent = (props) => { //.. const [subscriptions, setSubscriptions] = useState<any>([]); //.. const { call } = useFetch(); // example method, change with your own const getSubscriptions = useCallback(async () => { call( payment.companySubscriptions(userId), // example api call, change with your own (data) => setSubscriptions(data), ); }, [userId]); //.. const updateSubscriptions = useCallback(async () => { setTimeout(async () => { await getSubscriptions(); }, 5000);// 5 seconds delay }, [getSubscriptions]); //.. } In our component, we call 'updateSubscriptions' method. It will trigger 'getSubscriptions' method in which we used our custom hook. If we try to navigate to a different page after calling updateSubscriptions method before 5 seconds over, our custom hook will abort state update and prevent that warning on the title of this question Wanna see opposite? Change 'getSubscriptions' method with the one below const getSubscriptions = useCallback(async () => { const response = await payment.companySubscriptions(userId); setSubscriptions(response); }, [userId]); Now try to call 'updateSubscriptions' method and navigate to a different page before 5 seconds over
Try this custom hook: import { useEffect, useRef } from 'react'; export const useIsMounted = () => { const isMounted = useRef(false); useEffect(() => { isMounted.current = true; return () => (isMounted.current = false); }, []); return isMounted; }; function Example() { const isMounted = useIsMounted(); const [text, setText] = useState(); const safeSetState = useCallback((callback, ...args) => { if (isMounted.current) { callback(...args); } }, []); useEffect(() => { safeSetState(setText, 'Hello') }); }, []); return <h2>{text}</h2>; }