bilingual program in console application in C - c
I have been trying to implement a way to make my program bilingual : the user could chose if the program should display French or English (in my case).
I have made lots of researches and googling but I still cannot find a good example on how to do that :/
I read about gettext, but since this is for a school's project we are not allowed to use external libraries (and I must admit I have nooo idea how to make it work even though I tried !)
Someone also suggested to me the use of arrays one for each language, I could definitely make this work but I find the solution super ugly.
Another way I thought of is to have to different files, with sentences on each line and I would be able to retrieve the right line for the right language when I need to. I think I could make this work but it also doesn't seem like the most elegant solution.
At last, a friend said I could use DLL for that. I have looked up into that and it indeed seems to be one of the best ways I could find... the problem is that most resources I could find on that matter were coded for C# and C++ and I still have no idea how I would do to implement in C :/
I can grasp the idea behind it, but have no idea how to handle it in C (at all ! I do not know how to create the DLL, call it, retrieve the right stuff from it or anything >_<)
Could someone point me to some useful resources that I could use, or write a piece of code to explain the way things work or should be done ?
It would be seriously awesome !
Thanks a lot in advance !
(Btw, I use visual studio 2012 and code in C) ^^
If you can't use a third party lib then write your own one! No need for a dll.
The basic idea is the have a file for each locale witch contains a mapping (key=value) for text resources.
The name of the file could be something like
resources_<locale>.txt
where <locale> could be something like en, fr, de etc.
When your program stars it reads first the resource file for specified locale.
Preferably you will have to store each key/value pair in a simple struct.
Your read function reads all key/value pair into a hash table witch offers a very good access speed. An alternative would be to sort the array containing the key/value pairs by key and then use binary search on lookup (not the best option, but far better than iterating over all entries each time).
Then you'll have to write a function get_text witch takes as argument the key of the text resource to be looked up an return the corresponding text in as read for the specified locale. You have to handle keys witch have no mapping, the simplest way would be to return key back.
Here is some sample code (using qsort and bsearch):
#include<stdio.h>
#include<stdlib.h>
#include<string.h>
#define DEFAULT_LOCALE "en"
#define NULL_ARG "[NULL]"
typedef struct localized_text {
char* key;
char* value;
} localized_text_t;
localized_text_t* localized_text_resources = NULL;
int counter = 0;
char* get_text(char*);
void read_localized_text_resources(char*);
char* read_line(FILE*);
void free_localized_text_resources();
int compare_keys(const void*, const void*);
void print_localized_text_resources();
int main(int argc, char** argv)
{
argv++;
argc--;
char* locale = DEFAULT_LOCALE;
if(! *argv) {
printf("No locale provided, default to %s\n", locale);
} else {
locale = *argv;
printf("Locale provided is %s\n", locale);
}
read_localized_text_resources(locale);
printf("\n%s, %s!\n", get_text("HELLO"), get_text("WORLD"));
printf("\n%s\n", get_text("foo"));
free_localized_text_resources();
return 0;
}
char* get_text(char* key)
{
char* text = NULL_ARG;
if(key) {
text = key;
localized_text_t tmp;
tmp.key = key;
localized_text_t* result = bsearch(&tmp, localized_text_resources, counter, sizeof(localized_text_t), compare_keys);
if(result) {
text = result->value;
}
}
return text;
}
void read_localized_text_resources(char* locale)
{
if(locale) {
char localized_text_resources_file_name[64];
sprintf(localized_text_resources_file_name, "resources_%s.txt", locale);
printf("Read localized text resources from file %s\n", localized_text_resources_file_name);
FILE* localized_text_resources_file = fopen(localized_text_resources_file_name, "r");
if(! localized_text_resources_file) {
perror(localized_text_resources_file_name);
exit(1);
}
int size = 10;
localized_text_resources = malloc(size * sizeof(localized_text_t));
if(! localized_text_resources) {
perror("Unable to allocate memory for text resources");
}
char* line;
while((line = read_line(localized_text_resources_file))) {
if(strlen(line) > 0) {
if(counter == size) {
size += 10;
localized_text_resources = realloc(localized_text_resources, size * sizeof(localized_text_t));
}
localized_text_resources[counter].key = line;
while(*line != '=') {
line++;
}
*line = '\0';
line++;
localized_text_resources[counter].value = line;
counter++;
}
}
qsort(localized_text_resources, counter, sizeof(localized_text_t), compare_keys);
// print_localized_text_resources();
printf("%d text resource(s) found in file %s\n", counter, localized_text_resources_file_name);
}
}
char* read_line(FILE* p_file)
{
int len = 10, i = 0, c = 0;
char* line = NULL;
if(p_file) {
line = malloc(len * sizeof(char));
c = fgetc(p_file);
while(c != EOF) {
if(i == len) {
len += 10;
line = realloc(line, len * sizeof(char));
}
line[i++] = c;
c = fgetc(p_file);
if(c == '\n' || c == '\r') {
break;
}
}
line[i] = '\0';
while(c == '\n' || c == '\r') {
c = fgetc(p_file);
}
if(c != EOF) {
ungetc(c, p_file);
}
if(strlen(line) == 0 && c == EOF) {
free(line);
line = NULL;
}
}
return line;
}
void free_localized_text_resources()
{
if(localized_text_resources) {
while(counter--) {
free(localized_text_resources[counter].key);
}
free(localized_text_resources);
}
}
int compare_keys(const void* e1, const void* e2)
{
return strcmp(((localized_text_t*) e1)->key, ((localized_text_t*) e2)->key);
}
void print_localized_text_resources()
{
int i = 0;
for(; i < counter; i++) {
printf("Key=%s value=%s\n", localized_text_resources[i].key, localized_text_resources[i].value);
}
}
Used with the following resource files
resources_en.txt
WORLD=World
HELLO=Hello
resources_de.txt
HELLO=Hallo
WORLD=Welt
resources_fr.txt
HELLO=Hello
WORLD=Monde
run
(1) out.exe /* default */
(2) out.exe en
(3) out.exe de
(4) out.exe fr
output
(1) Hello, World!
(2) Hello, World!
(3) Hallo, Welt!
(4) Hello, Monde!
gettext is the obvious answer but it seems it's not possible in your case. Hmmm. If you really, really need a custom solution... throwing out a wild idea here...
1: Create a custom multilingual string type. The upside is that you can easily add new languages afterwards, if you want. The downside you'll see in #4.
//Terrible name, change it
typedef struct
{
char *french;
char *english;
} MyString;
2: Define your strings as needed.
MyString s;
s.french = "Bonjour!";
s.english = "Hello!";
3: Utility enum and function
enum
{
ENGLISH,
FRENCH
};
char* getLanguageString(MyString *myStr, int language)
{
switch(language)
{
case ENGLISH:
return myStr->english;
break;
case FRENCH:
return myStr->french;
break;
default:
//How you handle other values is up to you. You could decide on a default, for instance
//TODO
}
}
4: Create wrapper functions instead of using plain old C standard functions. For instance, instead of printf :
//Function should use the variable arguments and allow a custom format, too
int myPrintf(const char *format, MyString *myStr, int language, ...)
{
return printf(format, getLanguageString(myStr, language));
}
That part is the painful one : you'll need to override every function you use strings with to handle custom strings. You could also specify a global, default language variable to use when one isn't specified.
Again : gettext is much, much better. Implement this only if you really need to.
the main idea of making programs translatable is using in all places you use texts any kind of id. Then before displaying the test you get the text using the id form the appropriate language-table.
Example:
instead of writing
printf("%s","Hello world");
You write
printf("%s",myGetText(HELLO_WORLD));
Often instead of id the native-language string itself is used. e.g.:
printf("%s",myGetText("Hello world"));
Finally, the myGetText function is usually implemented as a Macro, e.g.:
printf("%s", tr("Hello world"));
This macro could be used by an external parser (like in gettext) for identifying texts to be translated in source code and store them as list in a file.
The myGetText could be implemented as follows:
std::map<std::string, std::map<std::string, std::string> > LangTextTab;
std::string GlobalVarLang="en"; //change to de for obtaining texts in German
void readLanguagesFromFile()
{
LangTextTab["de"]["Hello"]="Hallo";
LangTextTab["de"]["Bye"]="Auf Wiedersehen";
LangTextTab["en"]["Hello"]="Hello";
LangTextTab["en"]["Bye"]="Bye";
}
const char * myGetText( const char* origText )
{
return LangTextTab[GlobalVarLang][origText ].c_str();
}
Please consider the code as pseudo-code. I haven't compiled it. Many issues are still to mention: unicode, thread-safety, etc...
I hope however the example will give you the idea how to start.
Related
Strcmp generate a core dump
So i have a std::unordered_map, i want to acces to strings stored intro this map. I want to search intro intro all words inside the map and compare with a given word. If the strings are same then continue execution of the if statement. { public: bool CheckFoo(const char* word); protected: typedef std::unordered_map<std::string, bool> word_map; word_map words_map; }; bool CheckFoo(const char* word) { if (words_map.empty()) { return false; } auto it = words_map.begin(); while (it != words_map.end()) { const std::string &r = it->first; const char* tmp = word; if (strcmp(tmp, r.c_str() ) == 0) { return true; } } return false; } if ( CheckFoo("wordFoo") ) { // bla bla } The problem is that those codes generate a .core dump file.. Do you see any mistakes in my codes? The crash core analyze point me to strcmp line
Can't write comments yet but, Like Nunchy wrote, tmp is not defined in that context. I also noticed that your code never increments the map iterator, which would result in a never ending loop. I'm assuming you did not copy your actual code into your post but instead rewrote it hastily which resulted in some typos, but if not, try making sure you're using temp and not tmp in your call to strcmp, and make sure the loop actually increments the iterator. Like one of the comments on your post points out as well, make sure you actually have data in the map, and the function parameter.
You are declaring temp then referencing tmp which doesn't exist: const char* temp = word; if (strcmp(tmp, r.c_str() ) == 0) Does this compile? Surely it should be: const char* temp = word; if (strcmp(temp, r.c_str() ) == 0) ?
Strategy for cycling trough preexisting set of variables in c
I’m trying to program a HMI console to read a file from an USB pen drive and display its data on the screen. This is a csv file and the objective is to store the interpreted data to HMI console memory, which the HMI console later interprets. The macros on these consoles run in C (not C++). I have no issue with both reading and interpreting the file, the issue that the existing function (not accessible to me, shown below) to write in the console memory only interprets char. int WriteLocal( const char *type, int addr, int nRegs, void *buf , int flag ); Parameter: type is the string of "LW","LB" etc; address is the Operation address ; nRegs is the length of read or write ; buf is the buffer which store the reading or writing data flag is 0,then codetype is BIN,is 1 then codetype is BCD; return value : 1 , Operation success 0 , Operation fail. As my luck would have it I need to write integer values. What are available to me are the variables for each memory position. These are preexisting and are named individually such as: int WR_LW200; int WR_LW202; int WR_LW204; ... int WR_LW20n; Ideally we could have a vector with all the names of the variables but unfortunately this is not possible. I could manually write every single variable but I need to do 300 of these… must be a better way, right?
Just to give you a look on how it ended up looking: int* arr[50][5] = { {&WR_LW200, &WR_LW400, &WR_LW600, &WR_LW800, &WR_LW1000}, {&WR_LW202, &WR_LW402, &WR_LW602, &WR_LW802, &WR_LW1002}, {&WR_LW204, &WR_LW404, &WR_LW604, &WR_LW804, &WR_LW1004}, {&WR_LW206, &WR_LW406, &WR_LW606, &WR_LW806, &WR_LW1006}, {&WR_LW208, &WR_LW408, &WR_LW608, &WR_LW808, &WR_LW1008}, {&WR_LW210, &WR_LW410, &WR_LW610, &WR_LW810, &WR_LW1010}, {&WR_LW212, &WR_LW412, &WR_LW612, &WR_LW812, &WR_LW1012}, {&WR_LW214, &WR_LW414, &WR_LW614, &WR_LW814, &WR_LW1014}, {&WR_LW216, &WR_LW416, &WR_LW616, &WR_LW816, &WR_LW1016}, {&WR_LW218, &WR_LW418, &WR_LW618, &WR_LW818, &WR_LW1018}, {&WR_LW220, &WR_LW420, &WR_LW620, &WR_LW820, &WR_LW1020}, {&WR_LW222, &WR_LW422, &WR_LW622, &WR_LW822, &WR_LW1022}, {&WR_LW224, &WR_LW424, &WR_LW624, &WR_LW824, &WR_LW1024}, {&WR_LW226, &WR_LW426, &WR_LW626, &WR_LW826, &WR_LW1026}, {&WR_LW228, &WR_LW428, &WR_LW628, &WR_LW828, &WR_LW1028}, {&WR_LW230, &WR_LW430, &WR_LW630, &WR_LW830, &WR_LW1030}, {&WR_LW232, &WR_LW432, &WR_LW632, &WR_LW832, &WR_LW1032}, {&WR_LW234, &WR_LW434, &WR_LW634, &WR_LW834, &WR_LW1034}, {&WR_LW236, &WR_LW436, &WR_LW636, &WR_LW836, &WR_LW1036}, {&WR_LW238, &WR_LW438, &WR_LW638, &WR_LW838, &WR_LW1038}, {&WR_LW240, &WR_LW440, &WR_LW640, &WR_LW840, &WR_LW1040}, {&WR_LW242, &WR_LW442, &WR_LW642, &WR_LW842, &WR_LW1042}, {&WR_LW244, &WR_LW444, &WR_LW644, &WR_LW844, &WR_LW1044}, {&WR_LW246, &WR_LW446, &WR_LW646, &WR_LW846, &WR_LW1046}, {&WR_LW248, &WR_LW448, &WR_LW648, &WR_LW848, &WR_LW1048}, {&WR_LW250, &WR_LW450, &WR_LW650, &WR_LW850, &WR_LW1050}, {&WR_LW252, &WR_LW452, &WR_LW652, &WR_LW852, &WR_LW1052}, {&WR_LW254, &WR_LW454, &WR_LW654, &WR_LW854, &WR_LW1054}, {&WR_LW256, &WR_LW456, &WR_LW656, &WR_LW856, &WR_LW1056}, {&WR_LW258, &WR_LW458, &WR_LW658, &WR_LW858, &WR_LW1058}, {&WR_LW260, &WR_LW460, &WR_LW660, &WR_LW860, &WR_LW1060}, {&WR_LW262, &WR_LW462, &WR_LW662, &WR_LW862, &WR_LW1062}, {&WR_LW264, &WR_LW464, &WR_LW664, &WR_LW864, &WR_LW1064}, {&WR_LW266, &WR_LW466, &WR_LW666, &WR_LW866, &WR_LW1066}, {&WR_LW268, &WR_LW468, &WR_LW668, &WR_LW868, &WR_LW1068}, {&WR_LW270, &WR_LW470, &WR_LW670, &WR_LW870, &WR_LW1070}, {&WR_LW272, &WR_LW472, &WR_LW672, &WR_LW872, &WR_LW1072}, {&WR_LW274, &WR_LW474, &WR_LW674, &WR_LW874, &WR_LW1074}, {&WR_LW276, &WR_LW476, &WR_LW676, &WR_LW876, &WR_LW1076}, {&WR_LW278, &WR_LW478, &WR_LW678, &WR_LW878, &WR_LW1078}, {&WR_LW280, &WR_LW480, &WR_LW680, &WR_LW880, &WR_LW1080}, {&WR_LW282, &WR_LW482, &WR_LW682, &WR_LW882, &WR_LW1082}, {&WR_LW284, &WR_LW484, &WR_LW684, &WR_LW884, &WR_LW1084}, {&WR_LW286, &WR_LW486, &WR_LW686, &WR_LW886, &WR_LW1086}, {&WR_LW288, &WR_LW488, &WR_LW688, &WR_LW888, &WR_LW1088}, {&WR_LW290, &WR_LW490, &WR_LW690, &WR_LW890, &WR_LW1090}, {&WR_LW292, &WR_LW492, &WR_LW692, &WR_LW892, &WR_LW1092}, {&WR_LW294, &WR_LW494, &WR_LW694, &WR_LW894, &WR_LW1094}, {&WR_LW296, &WR_LW496, &WR_LW696, &WR_LW896, &WR_LW1096}, {&WR_LW298, &WR_LW498, &WR_LW698, &WR_LW898, &WR_LW1098} }; Big right? I had consurns that this HMI would have issues with such an approach but it did the job. The code below runs trough a string that comes from the csv file. This code runs inside another while cycle to cycle trough the multi dimensional array. it's a little crude but works. while (i<=5) { memset(lineTemp, 0, sizeof lineTemp); // clear lineTemp array while (lineFromFile[index] != delimiter) { if (lineFromFile[index] != delimiter && lineFromFile[index] != '\0') { lineTemp[j] = lineFromFile[index]; index++; j++; } if (lineFromFile[index] == '\0') { i = 5; break; } } index++; lineTemp[j] = '\0'; // NULL TERMINATION j = 0; if (i == -1) { WriteLocal("LW",temp,3,lineTemp,0); } if (i >= 0 && i<=5) { *(arr[x][i]) = atoi(lineTemp); } i++; } Thanks again for the tip. Cheers
Parsing commands shell-like in C
I want to parse user input commands in my C (just C) program. Sample commands: add node ID add arc ID from ID to ID print exit and so on. Then I want to do some validation with IDs and forward them to specified functions. Functions and validations are of course ready. It's all about parsing and matching functions... I've made it with many ifs and strtoks, but I'm sure it's not the best way... Any ideas (libs)?
I think what you want is something like this: while (1) { char *line = malloc(128); // we need to be able to increase the pointer char *origLine = line; fgets(line, 128, stdin); char command[20]; sscanf(line, "%20s ", command); line = strchr(line, ' '); printf("The Command is: %s\n", command); unsigned argumentsCount = 0; char **arguments = malloc(sizeof(char *)); while (1) { char arg[20]; if (line && (sscanf(++line, "%20s", arg) == 1)) { arguments[argumentsCount] = malloc(sizeof(char) * 20); strncpy(arguments[argumentsCount], arg, 20); argumentsCount++; arguments = realloc(arguments, sizeof(char *) * argumentsCount + 1); line = strchr(line, ' '); } else { break; } } for (int i = 0; i < argumentsCount; i++) { printf("Argument %i is: %s\n", i, arguments[i]); } for (int i = 0; i < argumentsCount; i++) { free(arguments[i]); } free(arguments); free(origLine); } You can do what you wish with 'command' and 'arguments' just before you free it all.
It depends on how complicated your command language is. It might be worth going to the trouble of womping up a simple recursive descent parser if you have more than a couple of commands, or if each command can take multiple forms, such as your add command. I've done a couple of RDPs by hand for some projects in the past. It's a bit of work, but it allows you to handle some fairly complex commands that wouldn't be straightforward to parse otherwise. You could also use a parser generator like lex/yacc or flex/bison, although that may be overkill for what you are doing. Otherwise, it's basically what you've described; strok and a bunch of nested if statements.
I just wanted to add something to Richard Ross's reply: Check the returned value from malloc and realloc. It may lead to hard-to-find crashes in your program.
All your command line parameters will be stored into a array of strings called argv. You can access those values using argv[0], argv[1] ... argv[n].
C Struct read/ write garbage value to file
I am diving into C after long time and struggling with reading and writing struct to the simple text file. I debuged this prog and I found out its reading and writing garbage value to the file. Can someone help me. Here is my code #define MAX_UserName_LEN 16 #define MAX_Password_LEN 8 #define MAX_FileName_LEN 32 struct userDetails { char userName[MAX_UserName_LEN]; char password[MAX_Password_LEN]; }; int registration(struct userDetails userInfo) { FILE *userDb; userDb= fopen("UserDataBase.txt","a"); if(fwrite(&userInfo,sizeof(userInfo),1,userDb)) { fclose(userDb); return 1; } else { return 0; } } int authenicate(struct userDetails userInfo) { FILE *userDb; struct userDetails temp; userDb = fopen("UserDataBase.txt","r"); while(!feof(userDb)) { fread(&temp,sizeof(temp),1,userDb); if (temp.userName==userInfo.userName && temp.password==userInfo.password) { printf("Logged In Sucessfully"); return 1; } } return 0; } In main function, I an just declaring one struct variable and accepting user input into that struct and passing it to both above mentioned functions.
The first major problem I see is here: if (temp.userName==userInfo.userName && temp.password==userInfo.password) You are trying to compare strings with ==. You need to use strcmp() instead: if (strcmp(temp.userName, userInfo.userName) == 0 && strcmp(temp.password, userInfo.password) == 0) I'm not sure if this has anything to do with the "garbage" you're getting, but it's definitely an error. As your code stands right now, it will never enter the if-statement.
Write a short code, which prints the userlist, so you'll see wheter the file contains garbage or not. Anyway, passwords should be scrambled somehow. Even a dumb solution is better than nothing, just to make it non-readable for human eyes. Say, for (n = 0; n < strlen(pwd); n++) pwd[n] ^= 0x55;.
How to extract filename from path
There should be something elegant in Linux API/POSIX to extract base file name from full path
See char *basename(char *path). Or run the command "man 3 basename" on your target UNIX/POSIX system.
Use basename (which has odd corner case semantics) or do it yourself by calling strrchr(pathname, '/') and treating the whole string as a basename if it does not contain a '/' character.
Here's an example of a one-liner (given char * whoami) which illustrates the basic algorithm: (whoami = strrchr(argv[0], '/')) ? ++whoami : (whoami = argv[0]); an additional check is needed if NULL is a possibility. Also note that this just points into the original string -- a "strdup()" may be appropriate.
You could use strstr in case you are interested in the directory names too: char *path ="ab/cde/fg.out"; char *ssc; int l = 0; ssc = strstr(path, "/"); do{ l = strlen(ssc) + 1; path = &path[strlen(path)-l+2]; ssc = strstr(path, "/"); }while(ssc); printf("%s\n", path);
The basename() function returns the last component of a path, which could be a folder name and not a file name. There are two versions of the basename() function: the GNU version and the POSIX version. The GNU version can be found in string.h after you include #define _GNU_SOURCE: #define _GNU_SOURCE #include <string.h> The GNU version uses const and does not modify the argument. char * basename (const char *path) This function is overridden by the XPG (POSIX) version if libgen.h is included. char * basename (char *path) This function may modify the argument by removing trailing '/' bytes. The result may be different from the GNU version in this case: basename("foo/bar/") will return the string "bar" if you use the XPG version and an empty string if you use the GNU version. References: basename (3) - Linux Man Pages Function: char * basename (const char *filename), Finding Tokens in a String.
Of course if this is a Gnu/Linux only question then you could use the library functions. https://linux.die.net/man/3/basename And though some may disapprove these POSIX compliant Gnu Library functions do not use const. As library utility functions rarely do. If that is important to you I guess you will have to stick to your own functionality or maybe the following will be more to your taste? #include <stdio.h> #include <string.h> int main(int argc, char *argv[]) { char *fn; char *input; if (argc > 1) input = argv[1]; else input = argv[0]; /* handle trailing '/' e.g. input == "/home/me/myprogram/" */ if (input[(strlen(input) - 1)] == '/') input[(strlen(input) - 1)] = '\0'; (fn = strrchr(input, '/')) ? ++fn : (fn = input); printf("%s\n", fn); return 0; }
template<typename charType> charType* getFileNameFromPath( charType* path ) { if( path == NULL ) return NULL; charType * pFileName = path; for( charType * pCur = path; *pCur != '\0'; pCur++) { if( *pCur == '/' || *pCur == '\\' ) pFileName = pCur+1; } return pFileName; } call: wchar_t * fileName = getFileNameFromPath < wchar_t > ( filePath ); (this is a c++)
You can escape slashes to backslash and use this code: #include <stdio.h> #include <string.h> int main(void) { char path[] = "C:\\etc\\passwd.c"; //string with escaped slashes char temp[256]; //result here char *ch; //define this ch = strtok(path, "\\"); //first split while (ch != NULL) { strcpy(temp, ch);//copy result printf("%s\n", ch); ch = strtok(NULL, "\\");//next split } printf("last filename: %s", temp);//result filename return 0; }
I used a simpler way to get just the filename or last part in a path. char * extract_file_name(char *path) { int len = strlen(path); int flag=0; printf("\nlength of %s : %d",path, len); for(int i=len-1; i>0; i--) { if(path[i]=='\\' || path[i]=='//' || path[i]=='/' ) { flag=1; path = path+i+1; break; } } return path; } Input path = "C:/Users/me/Documents/somefile.txt" Output = "somefile.txt"
#Nikolay Khilyuk offers the best solution except. 1) Go back to using char *, there is absolutely no good reason for using const. 2) This code is not portable and is likely to fail on none POSIX systems where the / is not the file system delimiter depending on the compiler implementation. For some windows compilers you might want to test for '\' instead of '/'. You might even test for the system and set the delimiter based on the results. The function name is long but descriptive, no problem there. There is no way to ever be sure that a function will return a filename, you can only be sure that it can if the function is coded correctly, which you achieved. Though if someone uses it on a string that is not a path obviously it will fail. I would have probably named it basename, as it would convey to many programmers what its purpose was. That is just my preference though based on my bias your name is fine. As far as the length of the string this function will handle and why anyone thought that would be a point? You will unlikely deal with a path name longer than what this function can handle on an ANSI C compiler. As size_t is defined as a unsigned long int which has a range of 0 to 4,294,967,295. I proofed your function with the following. #include <stdio.h> #include <string.h> char* getFileNameFromPath(char* path); int main(int argc, char *argv[]) { char *fn; fn = getFileNameFromPath(argv[0]); printf("%s\n", fn); return 0; } char* getFileNameFromPath(char* path) { for(size_t i = strlen(path) - 1; i; i--) { if (path[i] == '/') { return &path[i+1]; } } return path; } Worked great, though Daniel Kamil Kozar did find a 1 off error that I corrected above. The error would only show with a malformed absolute path but still the function should be able to handle bogus input. Do not listen to everyone that critiques you. Some people just like to have an opinion, even when it is not worth anything. I do not like the strstr() solution as it will fail if filename is the same as a directory name in the path and yes that can and does happen especially on a POSIX system where executable files often do not have an extension, at least the first time which will mean you have to do multiple tests and searching the delimiter with strstr() is even more cumbersome as there is no way of knowing how many delimiters there might be. If you are wondering why a person would want the basename of an executable think busybox, egrep, fgrep etc... strrchar() would be cumbersome to implement as it searches for characters not strings so I do not find it nearly as viable or succinct as this solution. I stand corrected by Rad Lexus this would not be as cumbersome as I thought as strrchar() has the side effect of returning the index of the string beyond the character found. Take Care
My example (improved): #include <string.h> const char* getFileNameFromPath(const char* path, char separator = '/') { if(path != nullptr) { for(size_t i = strlen(path); i > 0; --i) { if (path[i-1] == separator) { return &path[i]; } } } return path; }